Merge lp:~azzar1/unity/fix-lp-1458950 into lp:unity

Proposed by Andrea Azzarone
Status: Merged
Approved by: Stephen M. Webb
Approved revision: no longer in the source branch.
Merged at revision: 3980
Proposed branch: lp:~azzar1/unity/fix-lp-1458950
Merge into: lp:unity
Diff against target: 20 lines (+2/-2)
1 file modified
launcher/LauncherController.cpp (+2/-2)
To merge this branch: bzr merge lp:~azzar1/unity/fix-lp-1458950
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Stephen M. Webb (community) Approve
Review via email: mp+260580@code.launchpad.net

Commit message

Make sure new icons are added to the model before calling SortAndUpdate.

Description of the change

Make sure new icons are added to the model before calling SortAndUpdate.

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launcher/LauncherController.cpp'
2--- launcher/LauncherController.cpp 2015-05-12 13:09:39 +0000
3+++ launcher/LauncherController.cpp 2015-05-29 12:47:16 +0000
4@@ -757,14 +757,14 @@
5 *uri_ptr = new_uri;
6 });
7
8+ model_->AddIcon(icon);
9+
10 if (icon->GetIconType() == AbstractLauncherIcon::IconType::APPLICATION)
11 {
12 icon->visibility_changed.connect(sigc::hide(sigc::mem_fun(this, &Impl::SortAndUpdate)));
13 SortAndUpdate();
14 }
15
16- model_->AddIcon(icon);
17-
18 std::string const& path = icon->DesktopFile();
19
20 if (!path.empty())