Merge lp:~azzar1/unity/fix-713432-5.0 into lp:unity/5.0

Proposed by Andrea Azzarone
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: no longer in the source branch.
Merged at revision: 2407
Proposed branch: lp:~azzar1/unity/fix-713432-5.0
Merge into: lp:unity/5.0
Diff against target: 21 lines (+5/-1)
1 file modified
plugins/unityshell/src/DeviceLauncherIcon.cpp (+5/-1)
To merge this branch: bzr merge lp:~azzar1/unity/fix-713432-5.0
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Brandon Schaefer Pending
Review via email: mp+127546@code.launchpad.net

Commit message

Use GMountOperation in g_volume_mount. GMountOperation provides a mechanism for interacting with the use.

Description of the change

== Problem ==
Unity launcher doesn't prompt for password to unlock the device when clicking on a encrypted volume icon.

== Fix ==
Let's use GMountOperation.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1507/console reported an error when processing this lp:~andyrock/unity/fix-713432-5.0 branch.
Not merging it.

Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1508/console reported an error when processing this lp:~andyrock/unity/fix-713432-5.0 branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/DeviceLauncherIcon.cpp'
2--- plugins/unityshell/src/DeviceLauncherIcon.cpp 2012-06-22 17:21:20 +0000
3+++ plugins/unityshell/src/DeviceLauncherIcon.cpp 2012-10-02 17:19:30 +0000
4@@ -300,12 +300,16 @@
5 if (G_IS_MOUNT(mount.RawPtr()))
6 ShowMount(mount);
7 else
8+ {
9+ glib::Object<GMountOperation> mount_op(gtk_mount_operation_new(nullptr));
10+
11 g_volume_mount(volume_,
12 (GMountMountFlags)0,
13- NULL,
14+ mount_op,
15 NULL,
16 (GAsyncReadyCallback)&DeviceLauncherIcon::OnMountReady,
17 this);
18+ }
19 }
20
21 void DeviceLauncherIcon::OnMountReady(GObject* object,

Subscribers

People subscribed via source and target branches

to all changes: