Merge lp:~azzar1/unity/fix-1170720 into lp:~unity-team/unity/libunity-7.0-breakage

Proposed by Andrea Azzarone
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 3120
Proposed branch: lp:~azzar1/unity/fix-1170720
Merge into: lp:~unity-team/unity/libunity-7.0-breakage
Diff against target: 16 lines (+5/-1)
1 file modified
dash/DashView.cpp (+5/-1)
To merge this branch: bzr merge lp:~azzar1/unity/fix-1170720
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+159875@code.launchpad.net

Commit message

Don't close the dash if the mouse is over the vertical line between the dash and the launcher.

Description of the change

== Problem ==
Dash should only close when a icon is dragged outside of the Dash/Launcher area

== Fix ==
Don't close the dash if the mouse is over the vertical line between the dash and the launcher.

== Test ==
Cannot be unit-tested because nux does not allow setting/injecting the current event.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/DashView.cpp'
2--- dash/DashView.cpp 2013-04-17 15:10:39 +0000
3+++ dash/DashView.cpp 2013-04-19 19:19:28 +0000
4@@ -1462,7 +1462,11 @@
5
6 void DashView::ProcessDndEnter()
7 {
8- ubus_manager_.SendMessage(UBUS_OVERLAY_CLOSE_REQUEST);
9+ auto const& event = nux::GetGraphicsDisplay()->GetCurrentEvent();
10+
11+ // Don't close the dash if the mouse is over the vertical line between the dash and the launcher.
12+ if (event.x != GetAbsoluteX())
13+ ubus_manager_.SendMessage(UBUS_OVERLAY_CLOSE_REQUEST);
14 }
15
16 nux::Area* DashView::FindKeyFocusArea(unsigned int key_symbol,

Subscribers

People subscribed via source and target branches

to all changes: