Merge lp:~azzar1/unity/fix-1089888 into lp:unity

Proposed by Andrea Azzarone
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: no longer in the source branch.
Merged at revision: 2980
Proposed branch: lp:~azzar1/unity/fix-1089888
Merge into: lp:unity
Diff against target: 41 lines (+6/-5)
1 file modified
tests/test_overlay_scrollbar.cpp (+6/-5)
To merge this branch: bzr merge lp:~azzar1/unity/fix-1089888
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+139678@code.launchpad.net

Commit message

Use nux::ObjectPtr(s) in test_overlay_scrollbar.cpp

Description of the change

== Problem ==
TestOverlayScrollBar.TestScrollDownSignal segfaults.

== Fix ==
Use nux::ObjectPtr to handle nux::Object pointers.

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Looking good, also - it fixes the segfault for me. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/test_overlay_scrollbar.cpp'
2--- tests/test_overlay_scrollbar.cpp 2012-12-11 20:21:45 +0000
3+++ tests/test_overlay_scrollbar.cpp 2012-12-13 12:00:51 +0000
4@@ -201,11 +201,11 @@
5 MockScrollView(NUX_FILE_LINE_DECL)
6 : nux::ScrollView(NUX_FILE_LINE_PARAM)
7 {
8- scroll_bar_ = std::make_shared<MockScrollBar>(NUX_TRACKER_LOCATION);
9- SetVScrollBar(scroll_bar_.get());
10+ scroll_bar_ = new MockScrollBar(NUX_TRACKER_LOCATION);
11+ SetVScrollBar(scroll_bar_.GetPointer());
12 }
13
14- std::shared_ptr<MockScrollBar> scroll_bar_;
15+ nux::ObjectPtr<MockScrollBar> scroll_bar_;
16 };
17
18 class TestOverlayVScrollBar : public Test
19@@ -217,7 +217,7 @@
20 scroll_layout_->SetGeometry(0,0,1000,5000);
21 scroll_layout_->SetScaleFactor(0);
22
23- scroll_view_ = std::make_shared<MockScrollView>(NUX_TRACKER_LOCATION);
24+ scroll_view_ = new MockScrollView(NUX_TRACKER_LOCATION);
25 scroll_view_->EnableVerticalScrollBar(true);
26 scroll_view_->EnableHorizontalScrollBar(false);
27 scroll_view_->SetLayout(scroll_layout_);
28@@ -226,7 +226,7 @@
29 scroll_view_->scroll_bar_->SetContainerSize(0, 0, 202, 400);
30 }
31
32- std::shared_ptr<MockScrollView> scroll_view_;
33+ nux::ObjectPtr<MockScrollView> scroll_view_;
34 };
35
36 TEST_F(TestOverlayWindow, TestOverlayShows)
37@@ -420,3 +420,4 @@
38 }
39
40 }
41+