Merge lp:~azzar1/unity/fix-1036231 into lp:unity

Proposed by Andrea Azzarone on 2012-08-21
Status: Merged
Approved by: Tim Penhey on 2012-08-22
Approved revision: 2597
Merged at revision: 2607
Proposed branch: lp:~azzar1/unity/fix-1036231
Merge into: lp:unity
Diff against target: 12 lines (+1/-1)
1 file modified
unity-shared/IconRenderer.cpp (+1/-1)
To merge this branch: bzr merge lp:~azzar1/unity/fix-1036231
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve on 2012-08-22
Sam Spilsbury (community) 2012-08-21 Needs Information on 2012-08-21
Review via email:

Commit message

Use linear filtering to draw icons (when needed).

To post a comment you must log in.
Sam Spilsbury (smspillaz) wrote :

LGTM. Is this code covered by tests? Should it be?

review: Needs Information
Andrea Azzarone (azzar1) wrote :

> LGTM. Is this code covered by tests? Should it be?

IconRenderer is test free :/
Btw this is a visual change and we don't need test for visual changes. I'll ask Tim btw.

Tim Penhey (thumper) wrote :

Just visual. OK to land.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'unity-shared/IconRenderer.cpp'
2--- unity-shared/IconRenderer.cpp 2012-08-15 02:51:33 +0000
3+++ unity-shared/IconRenderer.cpp 2012-08-21 09:55:43 +0000
4@@ -522,7 +522,7 @@
5 nux::color::White,
6 colorify,
7 arg.alpha,
8- false,
9+ force_filter,
10 arg.icon->GetTransform(ui::IconTextureSource::TRANSFORM_IMAGE, monitor));
12 // draw overlay shine