Merge lp:~azzar1/unity-control-center/fix-1716359-xenial into lp:unity-control-center/16.04

Proposed by Andrea Azzarone on 2017-10-27
Status: Merged
Merged at revision: 12868
Proposed branch: lp:~azzar1/unity-control-center/fix-1716359-xenial
Merge into: lp:unity-control-center/16.04
Diff against target: 23 lines (+6/-0)
1 file modified
panels/sound/gvc-mixer-dialog.c (+6/-0)
To merge this branch: bzr merge lp:~azzar1/unity-control-center/fix-1716359-xenial
Reviewer Review Type Date Requested Status
Sebastien Bacher 2017-10-27 Approve on 2017-10-31
Review via email: mp+332903@code.launchpad.net

This proposal supersedes a proposal from 2017-10-27.

Commit message

Use row-activated signal instead of selection-changed. This will avoid that hy u-c-c decides which port the system should use after the user unplugs the headset. PulseAudio will do the job for us.

Description of the change

SRU fix.

To post a comment you must log in.
12868. By Andrea Azzarone on 2017-10-27

Use row-activated signal instead of selection-changed. This will avoid that hy u-c-c decides which port the system should use after the user unplugs the headset. PulseAudio will do the job for us.

Sebastien Bacher (seb128) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'panels/sound/gvc-mixer-dialog.c'
2--- panels/sound/gvc-mixer-dialog.c 2014-11-12 09:51:13 +0000
3+++ panels/sound/gvc-mixer-dialog.c 2017-10-27 16:57:56 +0000
4@@ -1509,6 +1509,9 @@
5 gboolean active;
6 guint id;
7
8+ if (gtk_get_current_event_device () == NULL)
9+ return;
10+
11 if (gtk_tree_selection_get_selected (selection, &model, &iter) == FALSE) {
12 g_debug ("Could not get default input from selection");
13 return;
14@@ -1544,6 +1547,9 @@
15 gboolean active;
16 guint id;
17
18+ if (gtk_get_current_event_device () == NULL)
19+ return;
20+
21 if (gtk_tree_selection_get_selected (selection, &model, &iter) == FALSE) {
22 g_debug ("Could not get default output from selection");
23 return;

Subscribers

People subscribed via source and target branches