Merge ~azzar1/ubuntu/+source/gnome-initial-setup:ubuntu/master-ubuntu-firstrun into ~ubuntu-desktop/ubuntu/+source/gnome-initial-setup:ubuntu/master

Proposed by Andrea Azzarone
Status: Merged
Merged at revision: 663c0cc4b2284b16d08562ce2f8c10b02e41c778
Proposed branch: ~azzar1/ubuntu/+source/gnome-initial-setup:ubuntu/master-ubuntu-firstrun
Merge into: ~ubuntu-desktop/ubuntu/+source/gnome-initial-setup:ubuntu/master
Diff against target: 66 lines (+12/-6)
3 files modified
debian/changelog (+6/-0)
debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch (+2/-2)
debian/patches/0001-Make-summary-page-explicitly-request-navigation-butt.patch (+4/-4)
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+356910@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index c1bea68..9394f07 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+gnome-initial-setup (3.30.0-1ubuntu3) UNRELEASED; urgency=medium
7+
8+ * Populate featured snaps from ubuntu-firstrun category
9+
10+ -- Andrea Azzarone <andrea.azzarone@canonical.com> Wed, 17 Oct 2018 10:25:35 +0100
11+
12 gnome-initial-setup (3.30.0-1ubuntu2) cosmic; urgency=medium
13
14 * Add Don-t-show-Facebook-in-Ubuntu.patch:
15diff --git a/debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch b/debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch
16index df7bbdb..3de104b 100644
17--- a/debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch
18+++ b/debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch
19@@ -468,7 +468,7 @@ index 0000000..0d8dd94
20 \ No newline at end of file
21 diff --git a/gnome-initial-setup/pages/apps/gis-apps-page.c b/gnome-initial-setup/pages/apps/gis-apps-page.c
22 new file mode 100644
23-index 0000000..bcd9462
24+index 0000000..1230c61
25 --- /dev/null
26 +++ b/gnome-initial-setup/pages/apps/gis-apps-page.c
27 @@ -0,0 +1,528 @@
28@@ -953,7 +953,7 @@ index 0000000..bcd9462
29 + installed_snaps = snapd_client_list_sync (client, NULL, &error);
30 + if (installed_snaps == NULL)
31 + g_warning ("Failed to get installed snaps: %s", error->message);
32-+ featured_snaps = snapd_client_find_section_sync (client, SNAPD_FIND_FLAGS_NONE, "featured", NULL, NULL, NULL, &error);
33++ featured_snaps = snapd_client_find_section_sync (client, SNAPD_FIND_FLAGS_NONE, "ubuntu-firstrun", NULL, NULL, NULL, &error);
34 + if (featured_snaps != NULL) {
35 + guint i, n_tiles = 0, n_extra = 0;
36 +
37diff --git a/debian/patches/0001-Make-summary-page-explicitly-request-navigation-butt.patch b/debian/patches/0001-Make-summary-page-explicitly-request-navigation-butt.patch
38index 8bad3a5..623f566 100644
39--- a/debian/patches/0001-Make-summary-page-explicitly-request-navigation-butt.patch
40+++ b/debian/patches/0001-Make-summary-page-explicitly-request-navigation-butt.patch
41@@ -166,11 +166,10 @@ index 8564935..64272ba 100644
42 obj_props[PROP_NEEDS_ACCEPT] =
43 g_param_spec_boolean ("needs-accept", "", "", FALSE,
44 G_PARAM_STATIC_STRINGS | G_PARAM_READWRITE);
45-@@ -282,6 +293,21 @@ gis_page_set_skippable (GisPage *page, gboolean skippable)
46- g_object_notify_by_pspec (G_OBJECT (page), obj_props[PROP_SKIPPABLE]);
47+@@ -283,6 +294,21 @@ gis_page_set_skippable (GisPage *page, gboolean skippable)
48 }
49
50-+gboolean
51+ gboolean
52 +gis_page_get_hide_navigation (GisPage *page)
53 +{
54 + GisPagePrivate *priv = gis_page_get_instance_private (page);
55@@ -185,9 +184,10 @@ index 8564935..64272ba 100644
56 + g_object_notify_by_pspec (G_OBJECT (page), obj_props[PROP_HIDE_NAVIGATION]);
57 +}
58 +
59- gboolean
60++gboolean
61 gis_page_get_needs_accept (GisPage *page)
62 {
63+ GisPagePrivate *priv = gis_page_get_instance_private (page);
64 diff --git a/gnome-initial-setup/gis-page.h b/gnome-initial-setup/gis-page.h
65 index b9a3e9a..3862caf 100644
66 --- a/gnome-initial-setup/gis-page.h

Subscribers

People subscribed via source and target branches