Merge ~azzar1/ubuntu/+source/gnome-control-center:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master

Proposed by Andrea Azzarone
Status: Merged
Merged at revision: f141ed564a0784281a046f625ecefe5c2d9147f5
Proposed branch: ~azzar1/ubuntu/+source/gnome-control-center:ubuntu/master
Merge into: ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master
Diff against target: 101 lines (+19/-11)
3 files modified
debian/patches/52_region_language.patch (+4/-4)
debian/patches/privacy-panel-whoopsie.patch (+11/-3)
debian/patches/ubuntu-printer-support.patch (+4/-4)
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+356324@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

The change looks good to me, thx

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/patches/52_region_language.patch b/debian/patches/52_region_language.patch
2index 56df791..92cff89 100644
3--- a/debian/patches/52_region_language.patch
4+++ b/debian/patches/52_region_language.patch
5@@ -340,10 +340,11 @@ index b20106d..7f78dbd 100644
6 }
7
8 gtk_widget_destroy (GTK_WIDGET (chooser));
9-@@ -384,6 +388,47 @@ set_system_region (CcRegionPanel *self,
10+@@ -383,6 +387,47 @@ set_system_region (CcRegionPanel *self,
11+ set_localed_locale (self);
12 }
13
14- static void
15++static void
16 +set_formats_locale (const gchar *formats_locale)
17 +{
18 + GDBusProxy *proxy;
19@@ -384,10 +385,9 @@ index b20106d..7f78dbd 100644
20 + g_free (user_path);
21 +}
22 +
23-+static void
24+ static void
25 update_region (CcRegionPanel *self,
26 const gchar *region)
27- {
28 @@ -392,6 +437,7 @@ update_region (CcRegionPanel *self,
29 } else {
30 if (g_strcmp0 (region, self->region) == 0)
31diff --git a/debian/patches/privacy-panel-whoopsie.patch b/debian/patches/privacy-panel-whoopsie.patch
32index 407351e..c3114f5 100644
33--- a/debian/patches/privacy-panel-whoopsie.patch
34+++ b/debian/patches/privacy-panel-whoopsie.patch
35@@ -5,10 +5,10 @@ Subject: [PATCH] panels/privacy: add Whoopsie support to privacy panel
36 ---
37 meson.build | 11 ++-
38 meson_options.txt | 3 +-
39- panels/privacy/cc-privacy-panel.c | 200 +++++++++++++++++++++++++++++++++++---
40+ panels/privacy/cc-privacy-panel.c | 201 +++++++++++++++++++++++++++++++++++---
41 panels/privacy/meson.build | 3 +
42 panels/privacy/privacy.ui | 86 +++++++++++++++-
43- 5 files changed, 286 insertions(+), 17 deletions(-)
44+ 5 files changed, 287 insertions(+), 17 deletions(-)
45
46 diff --git a/meson.build b/meson.build
47 index 2a8519c..5ef0cd5 100644
48@@ -51,7 +51,7 @@ index a347168..ce462a7 100644
49 +option('wayland', type: 'boolean', value: true, description: 'build with Wayland support')
50 +option('whoopsie', type: 'boolean', value: false, description: 'build with Whoopsie support')
51 diff --git a/panels/privacy/cc-privacy-panel.c b/panels/privacy/cc-privacy-panel.c
52-index 8f1abbd..71d5588 100644
53+index 8f1abbd..04291fd 100644
54 --- a/panels/privacy/cc-privacy-panel.c
55 +++ b/panels/privacy/cc-privacy-panel.c
56 @@ -35,6 +35,12 @@ typedef struct _NMClient NMClient;
57@@ -295,6 +295,14 @@ index 8f1abbd..71d5588 100644
58 }
59
60 #if defined(BUILD_NETWORK) && NM_CHECK_VERSION(1,10,0)
61+@@ -1348,6 +1520,7 @@ cc_privacy_panel_finalize (GObject *object)
62+ g_clear_pointer (&self->location_app_switches, g_hash_table_unref);
63+ g_clear_object (&self->nm_client);
64+ g_clear_pointer (&self->connectivity_check_dialog, gtk_widget_destroy);
65++ g_clear_object (&self->whoopsie);
66+
67+ G_OBJECT_CLASS (cc_privacy_panel_parent_class)->finalize (object);
68+ }
69 diff --git a/panels/privacy/meson.build b/panels/privacy/meson.build
70 index b1eec8a..3215b79 100644
71 --- a/panels/privacy/meson.build
72diff --git a/debian/patches/ubuntu-printer-support.patch b/debian/patches/ubuntu-printer-support.patch
73index 2afc304..bb6f4e6 100644
74--- a/debian/patches/ubuntu-printer-support.patch
75+++ b/debian/patches/ubuntu-printer-support.patch
76@@ -26,10 +26,11 @@ index f05a3ec..4d20ab7 100644
77 #include <glib/gi18n-lib.h>
78 #include <glib/gstdio.h>
79 #include <polkit/polkit.h>
80-@@ -1108,6 +1109,32 @@ printer_add_cb (GtkToolButton *toolbutton,
81+@@ -1107,6 +1108,32 @@ printer_add_cb (GtkToolButton *toolbutton,
82+ self);
83 }
84
85- static void
86++static void
87 +show_system_config_printer (void)
88 +{
89 + GAppInfo *app_info;
90@@ -55,10 +56,9 @@ index f05a3ec..4d20ab7 100644
91 + g_object_unref (ctx);
92 +}
93 +
94-+static void
95+ static void
96 update_sensitivity (gpointer user_data)
97 {
98- CcPrintersPanelPrivate *priv;
99 @@ -1424,6 +1451,14 @@ cc_printers_panel_init (CcPrintersPanel *self)
100 gtk_builder_get_object (priv->builder, "printer-add-button2");
101 g_signal_connect (widget, "clicked", G_CALLBACK (printer_add_cb), self);

Subscribers

People subscribed via source and target branches