Code review comment for ~azzar1/ubiquity:fix_regain_privileges_save
Revision history for this message
| Didier Roche-Tolomelli (didrocks) wrote | # |
review:
Needs Information
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
9fcfff1
(Get the code!)
@vanvugt: I think ubiquity just moved to git
From my comments on IRC:
I don't understand why we don't call directly os.setresuid(0, egid, 0) for instance. This is probably because os.setgroups([]) has an incidence, but I've never used that one
Preservering the euid and geuid is needed for sure and replacing with 0 for uid/guid was a mistake
but I don't understand why the calls in 2 steps. Do you mind expanding (and adding a comment?)