Code review comment for lp:~azzar1/software-properties/new-auth-dialog

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Thank you for the work, looks good to me, some small details
>
> * that's not the exact same string but in https://user-images.githubuserconten
> t.com/19801137/38986966-1632a352-43c6-11e8-9f30-4fada71b78ce.png mpt used the
> string
>
> 'Ubuntu One account' where you wrote '*A*ccount' ... is that wanted?
>
> * The dialog is titled "software-properties-gtk" which is not that nice, can
> we get ride of the title or use something better/more user friendly?
>
> * When I click on the sign in/register button (on disco, testing with an
> hacked lsb-release to have the UI showing) I get that error
>
> 'Traceback (most recent call last):
> File "/usr/lib/python3/dist-packages/softwareproperties/gtk/DialogAuth.py",
> line 237, in _button_continue_clicked_cb
> self._button_add_another_clicked_cb(self, self.button_add_another)
> TypeError: _button_add_another_clicked_cb() takes 2 positional arguments but 3
> were given'

Branch updated!

« Back to merge proposal