Nux

Merge lp:~azzar1/nux/view-added into lp:nux

Proposed by Andrea Azzarone
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 838
Merged at revision: 841
Proposed branch: lp:~azzar1/nux/view-added
Merge into: lp:nux
Diff against target: 23 lines (+2/-0)
2 files modified
Nux/Layout.cpp (+1/-0)
Nux/LinearLayout.cpp (+1/-0)
To merge this branch: bzr merge lp:~azzar1/nux/view-added
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+207763@code.launchpad.net

Commit message

Emit nux::Layout::ViewAdded when a layout is added too. In future would be nice to rename the signal name in AreaAdded. We need for a11y reasons.

Description of the change

Emit nux::Layout::ViewAdded when a layout is added too. In future would be nice to rename the signal name in AreaAdded. We need for a11y reasons.

See: https://code.launchpad.net/~andyrock/unity/lockscreen/+merge/206291

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Nux/Layout.cpp'
2--- Nux/Layout.cpp 2012-11-05 21:31:06 +0000
3+++ Nux/Layout.cpp 2014-02-22 04:00:38 +0000
4@@ -252,6 +252,7 @@
5 _layout_element_list.insert(pos, layout);
6 }
7
8+ ViewAdded.emit(this, layout);
9 }
10
11 //! Add an object to the layout.
12
13=== modified file 'Nux/LinearLayout.cpp'
14--- Nux/LinearLayout.cpp 2012-11-05 21:31:06 +0000
15+++ Nux/LinearLayout.cpp 2014-02-22 04:00:38 +0000
16@@ -95,6 +95,7 @@
17 _layout_element_list.insert(pos, layout);
18 }
19
20+ ViewAdded.emit(this, layout);
21 }
22
23 //! Add an object to the layout.

Subscribers

People subscribed via source and target branches