Created by Andrea Azzarone and last modified
Get this branch:
bzr branch lp:~azzar1/nux/please-dont-focus-me-on-mouse-down
Only Andrea Azzarone can upload to this branch. If you are Andrea Azzarone please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Andrea Azzarone

Recent revisions

533. By Andrea Azzarone

Adds the possiblity to don't get the focus on mouse down.

532. By Jay Taoko

* Removed API:
   GraphicsDisplay& GetWindow();
   GraphicsEngine& GetGraphicsEngine();
   NThread* GetThreadApplication();
   WindowThread* GetGraphicsThread();

* Modified code to to use GetWindowThread() to access its internal objects.

* Added tests:
   - WindowThread
   - StaticText
. Fixes: . Appoved by Jason Smith.

531. By Jay Taoko

Added separate file for GLib main loop functions
* Cleanup: variable renaming
* Marked some functions as obsolete
* Core objects take the WindowThread as a constructor parameters: Painter, WindowCompositor.... Fixes: . Appoved by Jason Smith.

530. By Andrea Azzarone

Makes sure that the scroll wheel works with nux::VScrollbar. Fixes: Appoved by Jay Taoko.

529. By Andrea Azzarone

Fixes GridHlayout key navigation and add three automated tests. I need this fix to implement properly the new dash key navigation design.. Fixes: . Appoved by Jay Taoko.

528. By Jay Taoko

* Added support for text alignment inside view
* Fixed layout bug
* Added example layout example (for a shortcut key view). Fixes: . Appoved by Jay Taoko, Andrea Azzarone.

527. By Jay Taoko

* Fix: look for ABI.h in $(builddir) rather than $(srcdir) in case the builddir is different from the srcdir.
* Fix: "make distcheck" was failing. Fixes: . Appoved by Didier Roche.

526. By Gord Allott

Updates nux to nux 2.0 - including pc file and libs. Fixes: . Appoved by Didier Roche, Tim Penhey, Jay Taoko.

525. By Jay Taoko

* Added ABI.h file to signal ABI or API breaks in Nux.. Fixes: . Reviewed by Didier Roche.

524. By Andrea Azzarone

    * Added mouse button test: only mouse buttons 1, 2 and 3 should generate mouse down/up events (jaytaoko)

    * Merged with Nux Trunk.

    * Tries to fix:
    [*] Bug #775872: Menubar - horizontal scroll over a menu opens it
    [*] Bug #809717: Horizontal scroll on maximize/restore window control restores window.
    [*] Bug #837004: Horizontally scrolling while highlighting an item in the dash or on an indicator will open the item.
    [*] a not reported bug: horizontally scrolling on minimize window control (-) blows up unity (at least on my laptop).

    - Preface:
    In X11 the horizontal scroll and the vertical one are emulated using a wheel-to-button mapping. The wheel-to-button mapping always generates a press followed instantly by a release.
    As you know currently nux doesn't support horizontal scroll.

    - What happens in nux
    So in the mouse_press function (GraphicsDisplayX11.cpp) and in the mouse_release one is setted to NUX_MOUSE_PRESSED and NUX_MOUSE_RELEASED not only when button1, button2 or button3 are pressed/released, but also when button4, button5, button6 and button7 are pressed/released.

    Regarding vertical scoll we have no problems because in MouseEventCycle function (WindowCompositorX11.cpp), NUX_MOUSE_WHEEL has an higher priority then NUX_MOUSE_PRESSED, so the mouse_wheel signal is emitted.

    As said in the preface nux doesn't support horizontal scroll. So NUX_MOUSE_WHEEL is not setted and in MouseEventCycle because NUX_MOUSE_PRESSED is setted, the mouse_click (or mouse_up) signal is emitted.

    - Solution
    Don't set NUX_MOUSE_PRESSED (or NUX_MOUSE_RELEASED) if it's a scroll.

    - P.S.
    No regressions found during my manual test. I cannot imagine any kind of regression. Please let me know if something is wrong.
. Fixes: . Reviewed by Jay Taoko.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
This branch contains Public information 
Everyone can see this information.