Nux

Merge lp:~azzar1/nux/fix-893670 into lp:nux/2.0

Proposed by Andrea Azzarone
Status: Merged
Merged at revision: 536
Proposed branch: lp:~azzar1/nux/fix-893670
Merge into: lp:nux/2.0
Diff against target: 42 lines (+5/-9)
2 files modified
NuxGraphics/GraphicsDisplayX11.cpp (+0/-8)
NuxGraphics/XInputWindow.cpp (+5/-1)
To merge this branch: bzr merge lp:~azzar1/nux/fix-893670
Reviewer Review Type Date Requested Status
Mirco Müller (community) Approve
Review via email: mp+88623@code.launchpad.net

Description of the change

This branch is a partial fix for the bug #893670. It requires also:
- https://code.launchpad.net/~andyrock/compiz-core/scale-left-padding/+merge/88622
- https://code.launchpad.net/~andyrock/unity/scale-left-padding/+merge/88625

But you can test it setting the spacing option in the scale ccsm panel to 100.

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

This branch is a partial fix for the bug #893670.

Revision history for this message
Mirco Müller (macslow) wrote :

Looks fine.

review: Approve
Revision history for this message
Andrea Azzarone (azzar1) wrote :

We're waiting for the the other two branches.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NuxGraphics/GraphicsDisplayX11.cpp'
--- NuxGraphics/GraphicsDisplayX11.cpp 2012-01-06 18:43:37 +0000
+++ NuxGraphics/GraphicsDisplayX11.cpp 2012-01-15 23:24:26 +0000
@@ -1682,12 +1682,6 @@
1682 {1682 {
1683 //nuxDebugMsg("[GraphicsDisplay::ProcessXEvents]: MapNotify event.");1683 //nuxDebugMsg("[GraphicsDisplay::ProcessXEvents]: MapNotify event.");
1684 m_pEvent->type = NUX_WINDOW_MAP;1684 m_pEvent->type = NUX_WINDOW_MAP;
1685
1686 XSetInputFocus(xevent.xany.display,
1687 xevent.xany.window,
1688 RevertToParent,
1689 CurrentTime);
1690
1691 }1685 }
1692 1686
1693 break;1687 break;
@@ -2727,5 +2721,3 @@
2727 }2721 }
27282722
2729}2723}
2730
2731
27322724
=== modified file 'NuxGraphics/XInputWindow.cpp'
--- NuxGraphics/XInputWindow.cpp 2011-11-01 15:58:46 +0000
+++ NuxGraphics/XInputWindow.cpp 2012-01-15 23:24:26 +0000
@@ -335,10 +335,14 @@
335 {335 {
336 XMapRaised(display_, window_);336 XMapRaised(display_, window_);
337 mapped_ = true;337 mapped_ = true;
338
339 XEvent xevent;
340 while (XCheckTypedWindowEvent(display_, window_, MapNotify, &xevent));
341 XSetInputFocus(display_, window_, RevertToParent, CurrentTime);
342
338 }343 }
339 XMoveResizeWindow(display_, window_,344 XMoveResizeWindow(display_, window_,
340 geometry_.x, geometry_.y,345 geometry_.x, geometry_.y,
341 geometry_.width, geometry_.height);346 geometry_.width, geometry_.height);
342 }347 }
343}348}
344

Subscribers

People subscribed via source and target branches

to all changes: