Nux

Merge lp:~azzar1/nux/dnd-fix into lp:nux/2.0

  1. dnd-fix
  2. Merge into 2.0
Proposed by Andrea Azzarone
Status: Merged
Approved by: Jay Taoko
Approved revision: 588
Merged at revision: 594
Proposed branch: lp:~azzar1/nux/dnd-fix
Merge into: lp:nux/2.0
Diff against target: 12 lines (+1/-1)
1 file modified
NuxGraphics/GraphicsDisplayX11.cpp (+1/-1)
To merge this branch: bzr merge lp:~azzar1/nux/dnd-fix
Reviewer Review Type Date Requested Status
Thomi Richards (community) Approve
Review via email: mp+95971@code.launchpad.net

Description of the change

The problem
-----------
Read bug #947362

The fix
-------
Draw the icon out of the screen the first time

Test
---
No idea how we can test it.

To post a comment you must log in.
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

I can't see how we can test this either. Is there anything we can do to make sure that this particular mistake doesn't get repeated in the future>

review: Approve
Revision history for this message
Andrea Azzarone (azzar1) wrote :

> I can't see how we can test this either. Is there anything we can do to make
> sure that this particular mistake doesn't get repeated in the future?

I cannot see something really useful to avoid this...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NuxGraphics/GraphicsDisplayX11.cpp'
2--- NuxGraphics/GraphicsDisplayX11.cpp 2012-01-26 23:01:57 +0000
3+++ NuxGraphics/GraphicsDisplayX11.cpp 2012-03-05 18:50:25 +0000
4@@ -2114,7 +2114,7 @@
5 // Second this window will grab and own the XdndSelection Selection
6 _dnd_source_window = XCreateWindow(display,
7 root,
8- 100, 100,
9+ -1000, -1000,
10 width, height,
11 0,
12 vinfo.depth,

Subscribers

People subscribed via source and target branches

to all changes: