Merge lp:~azzar1/indicator-datetime/drop-dep-from-ubuntu-app-launch into lp:indicator-datetime

Proposed by Andrea Azzarone
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 487
Merged at revision: 487
Proposed branch: lp:~azzar1/indicator-datetime/drop-dep-from-ubuntu-app-launch
Merge into: lp:indicator-datetime
Diff against target: 62 lines (+2/-14)
3 files modified
CMakeLists.txt (+1/-2)
debian/control (+0/-1)
src/notifications.cpp (+1/-11)
To merge this branch: bzr merge lp:~azzar1/indicator-datetime/drop-dep-from-ubuntu-app-launch
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
unity-api-1-bot continuous-integration Needs Fixing
Review via email: mp+328579@code.launchpad.net

Commit message

Drop the dependency from ubuntu-app-launch.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ack

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2017-02-27 14:29:11 +0000
3+++ CMakeLists.txt 2017-08-04 14:09:28 +0000
4@@ -52,8 +52,7 @@
5 properties-cpp>=0.0.1
6 libaccounts-glib>=1.18
7 messaging-menu>=12.10
8- uuid>=2.25
9- ubuntu-app-launch-3)
10+ uuid>=2.25)
11 include_directories (SYSTEM ${SERVICE_DEPS_INCLUDE_DIRS})
12
13 ##
14
15=== modified file 'debian/control'
16--- debian/control 2017-06-05 23:25:57 +0000
17+++ debian/control 2017-08-04 14:09:28 +0000
18@@ -38,7 +38,6 @@
19 # messaging menu integration
20 libmessaging-menu-dev,
21 uuid-dev,
22- libubuntu-app-launch3-dev (>= 0.9),
23 # to locate the place to put systemd files
24 systemd,
25 Standards-Version: 3.9.3
26
27=== modified file 'src/notifications.cpp'
28--- src/notifications.cpp 2017-02-27 14:29:11 +0000
29+++ src/notifications.cpp 2017-08-04 14:09:28 +0000
30@@ -24,9 +24,6 @@
31 #include <messaging-menu/messaging-menu-app.h>
32 #include <messaging-menu/messaging-menu-message.h>
33
34-#include <libubuntu-app-launch-3/ubuntu-app-launch/appid.h>
35-#include <libubuntu-app-launch-3/ubuntu-app-launch/registry.h>
36-
37 #include <uuid/uuid.h>
38
39 #include <gio/gdesktopappinfo.h>
40@@ -37,7 +34,6 @@
41 #include <vector>
42 #include <memory>
43
44-
45 namespace unity {
46 namespace indicator {
47 namespace notifications {
48@@ -461,13 +457,7 @@
49
50 static std::string calendar_app_id()
51 {
52- auto registry = std::make_shared<ubuntu::app_launch::Registry>();
53- auto app_id = ubuntu::app_launch::AppID::discover(registry, "ubuntu-calendar-app");
54- if (!app_id.empty())
55- // Due the use of old API by messaging_menu we need append a extra ".desktop" to the app_id.
56- return std::string(app_id) + ".desktop";
57- else
58- return std::string();
59+ return "org.gnome.Calendar.desktop";
60 }
61
62 static std::string calendar_app_icon()

Subscribers

People subscribed via source and target branches