Merge lp:~azzar1/indicator-datetime/31-june-its-not-a-thing into lp:indicator-datetime

Proposed by Andrea Azzarone on 2017-08-29
Status: Merged
Approved by: Marco Trevisan (Treviño) on 2017-08-30
Approved revision: 490
Merged at revision: 489
Proposed branch: lp:~azzar1/indicator-datetime/31-june-its-not-a-thing
Merge into: lp:indicator-datetime
Prerequisite: lp:~3v1n0/indicator-datetime/calendar-data-files
Diff against target: 107 lines (+8/-9)
7 files modified
tests/test-eds-ics-all-day-events.cpp (+1/-1)
tests/test-eds-ics-missing-trigger.cpp (+2/-3)
tests/test-eds-ics-non-attending-alarms.cpp (+1/-1)
tests/test-eds-ics-non-selected-source.cpp (+1/-1)
tests/test-eds-ics-nonrepeating-events.cpp (+1/-1)
tests/test-eds-ics-repeating-events.cpp (+1/-1)
tests/test-eds-ics-repeating-valarms.cpp (+1/-1)
To merge this branch: bzr merge lp:~azzar1/indicator-datetime/31-june-its-not-a-thing
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) 2017-08-29 Approve on 2017-08-30
unity-api-1-bot continuous-integration Approve on 2017-08-29
Review via email: mp+329819@code.launchpad.net

Commit message

Use 30-jun instaed of 31-jun.

Description of the change

Use 30-jun instaed of 31-jun.

To post a comment you must log in.
490. By Andrea Azzarone on 2017-08-29

As we removed a day we need to edit the test too.

unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:490
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-datetime-ci/29/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1940
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1947
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1727
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1727/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1727
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1727/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1727
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1727/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1727
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1727/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1727
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1727/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1727
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1727/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-datetime-ci/29/rebuild

review: Approve (continuous-integration)
Marco Trevisan (Treviño) (3v1n0) wrote :

What the hell!

I want 30 February too...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/test-eds-ics-all-day-events.cpp'
--- tests/test-eds-ics-all-day-events.cpp 2016-05-14 02:07:10 +0000
+++ tests/test-eds-ics-all-day-events.cpp 2017-08-29 15:19:46 +0000
@@ -52,7 +52,7 @@
52 // make a planner that looks at the first half of 2015 in EDS52 // make a planner that looks at the first half of 2015 in EDS
53 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);53 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);
54 const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};54 const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};
55 const DateTime range_end {gtz, 2015,6,31,23,59,59.5};55 const DateTime range_end {gtz, 2015,6,30,23,59,59.5};
56 planner->range().set(std::make_pair(range_begin, range_end));56 planner->range().set(std::make_pair(range_begin, range_end));
5757
58 // give EDS a moment to load58 // give EDS a moment to load
5959
=== modified file 'tests/test-eds-ics-missing-trigger.cpp'
--- tests/test-eds-ics-missing-trigger.cpp 2016-05-14 02:07:10 +0000
+++ tests/test-eds-ics-missing-trigger.cpp 2017-08-29 15:19:46 +0000
@@ -52,7 +52,7 @@
52 // make a planner that looks at the first half of 2015 in EDS52 // make a planner that looks at the first half of 2015 in EDS
53 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);53 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);
54 const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};54 const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};
55 const DateTime range_end {gtz, 2015,6,31,23,59,59.5};55 const DateTime range_end {gtz, 2015,6,30,23,59,59.5};
56 planner->range().set(std::make_pair(range_begin, range_end));56 planner->range().set(std::make_pair(range_begin, range_end));
5757
58 // give EDS a moment to load58 // give EDS a moment to load
@@ -87,7 +87,7 @@
87 a.uid = "20150617T211913Z-6217-32011-2036-5@ubuntu-phablet";87 a.uid = "20150617T211913Z-6217-32011-2036-5@ubuntu-phablet";
88 a.summary = "Recurring Alarm";88 a.summary = "Recurring Alarm";
89 a.alarms[0].text = a.summary;89 a.alarms[0].text = a.summary;
90 std::array<DateTime,14> recurrences {90 std::array<DateTime,13> recurrences {
91 DateTime{ gtz, 2015, 6, 18, 10, 1, 0 },91 DateTime{ gtz, 2015, 6, 18, 10, 1, 0 },
92 DateTime{ gtz, 2015, 6, 19, 10, 1, 0 },92 DateTime{ gtz, 2015, 6, 19, 10, 1, 0 },
93 DateTime{ gtz, 2015, 6, 20, 10, 1, 0 },93 DateTime{ gtz, 2015, 6, 20, 10, 1, 0 },
@@ -101,7 +101,6 @@
101 DateTime{ gtz, 2015, 6, 28, 10, 1, 0 },101 DateTime{ gtz, 2015, 6, 28, 10, 1, 0 },
102 DateTime{ gtz, 2015, 6, 29, 10, 1, 0 },102 DateTime{ gtz, 2015, 6, 29, 10, 1, 0 },
103 DateTime{ gtz, 2015, 6, 30, 10, 1, 0 },103 DateTime{ gtz, 2015, 6, 30, 10, 1, 0 },
104 DateTime{ gtz, 2015, 7, 1, 10, 1, 0 }
105 };104 };
106 for (const auto& time : recurrences) {105 for (const auto& time : recurrences) {
107 a.begin = a.end = a.alarms[0].time = time;106 a.begin = a.end = a.alarms[0].time = time;
108107
=== modified file 'tests/test-eds-ics-non-attending-alarms.cpp'
--- tests/test-eds-ics-non-attending-alarms.cpp 2016-05-14 02:16:53 +0000
+++ tests/test-eds-ics-non-attending-alarms.cpp 2017-08-29 15:19:46 +0000
@@ -52,7 +52,7 @@
52 // make a planner that looks at the first half of 2016 in EDS52 // make a planner that looks at the first half of 2016 in EDS
53 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);53 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);
54 const DateTime range_begin {gtz, 2016,1, 1, 0, 0, 0.0};54 const DateTime range_begin {gtz, 2016,1, 1, 0, 0, 0.0};
55 const DateTime range_end {gtz, 2016,6,31,23,59,59.5};55 const DateTime range_end {gtz, 2016,6,30,23,59,59.5};
56 planner->range().set(std::make_pair(range_begin, range_end));56 planner->range().set(std::make_pair(range_begin, range_end));
5757
58 // give EDS a moment to load58 // give EDS a moment to load
5959
=== modified file 'tests/test-eds-ics-non-selected-source.cpp'
--- tests/test-eds-ics-non-selected-source.cpp 2016-06-21 21:39:39 +0000
+++ tests/test-eds-ics-non-selected-source.cpp 2017-08-29 15:19:46 +0000
@@ -50,7 +50,7 @@
50 // make a planner that looks at the first half of 2015 in EDS50 // make a planner that looks at the first half of 2015 in EDS
51 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);51 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);
52 const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};52 const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};
53 const DateTime range_end {gtz, 2015,6,31,23,59,59.5};53 const DateTime range_end {gtz, 2015,6,30,23,59,59.5};
54 planner->range().set(std::make_pair(range_begin, range_end));54 planner->range().set(std::make_pair(range_begin, range_end));
5555
56 // give EDS a moment to load56 // give EDS a moment to load
5757
=== modified file 'tests/test-eds-ics-nonrepeating-events.cpp'
--- tests/test-eds-ics-nonrepeating-events.cpp 2016-05-14 02:07:10 +0000
+++ tests/test-eds-ics-nonrepeating-events.cpp 2017-08-29 15:19:46 +0000
@@ -52,7 +52,7 @@
52 // make a planner that looks at the first half of 2015 in EDS52 // make a planner that looks at the first half of 2015 in EDS
53 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);53 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);
54 const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};54 const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};
55 const DateTime range_end {gtz, 2015,6,31,23,59,59.5};55 const DateTime range_end {gtz, 2015,6,30,23,59,59.5};
56 planner->range().set(std::make_pair(range_begin, range_end));56 planner->range().set(std::make_pair(range_begin, range_end));
5757
58 // give EDS a moment to load58 // give EDS a moment to load
5959
=== modified file 'tests/test-eds-ics-repeating-events.cpp'
--- tests/test-eds-ics-repeating-events.cpp 2016-05-14 02:07:10 +0000
+++ tests/test-eds-ics-repeating-events.cpp 2017-08-29 15:19:46 +0000
@@ -52,7 +52,7 @@
52 // make a planner that looks at the first half of 2015 in EDS52 // make a planner that looks at the first half of 2015 in EDS
53 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);53 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);
54 const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};54 const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};
55 const DateTime range_end {gtz, 2015,6,31,23,59,59.5};55 const DateTime range_end {gtz, 2015,6,30,23,59,59.5};
56 planner->range().set(std::make_pair(range_begin, range_end));56 planner->range().set(std::make_pair(range_begin, range_end));
5757
58 // give EDS a moment to load58 // give EDS a moment to load
5959
=== modified file 'tests/test-eds-ics-repeating-valarms.cpp'
--- tests/test-eds-ics-repeating-valarms.cpp 2016-05-14 02:07:10 +0000
+++ tests/test-eds-ics-repeating-valarms.cpp 2017-08-29 15:19:46 +0000
@@ -52,7 +52,7 @@
52 // make a planner that looks at the first half of 2015 in EDS52 // make a planner that looks at the first half of 2015 in EDS
53 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);53 auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);
54 const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};54 const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};
55 const DateTime range_end {gtz, 2015,6,31,23,59,59.5};55 const DateTime range_end {gtz, 2015,6,30,23,59,59.5};
56 planner->range().set(std::make_pair(range_begin, range_end));56 planner->range().set(std::make_pair(range_begin, range_end));
5757
58 // give EDS a moment to load58 // give EDS a moment to load

Subscribers

People subscribed via source and target branches