Merge lp:~azzar1/compiz/revert-3513 into lp:compiz/0.9.9

[Andrea Azzarone]

Revert r3513. It causes a regression with unity.
(LP: #1089811)

== Problem ==
[Regression] Minimizing a window creates an input-insensitive area

== Temporary fix ==
Let's revert r3513 for the moment.

[Daniel van Vugt (vanvugt)]

Actually I just had a though...

Can we look at a proper fix for the regression? r3513 is technically correct.

I suspect a proper fix would be to modify PrivateWindow::updateRegion and add:
  if (window->minimized()) return;

That will ensure priv->inputRegion is not set if and when Unity is doing its pseudo-minimized thing.

review: Needs Information

[Daniel van Vugt (vanvugt)]

Note: You will need the very latest lp:unity for the proper fix to work since I only fixed UnityWindow::minimized() today.

[Daniel van Vugt (vanvugt)]

Sorry, my suggestion was over-simplified but I now have a working solution that does work without reverting r3513 (which itself is useful).

[Daniel van Vugt (vanvugt)]

Have a look at this instead:
https://code.launchpad.net/~vanvugt/compiz/fix-1089811/+merge/139652

review: Disapprove

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3529
http://jenkins.qa.ubuntu.com/job/compiz-ci/324/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-ci/./build=pbuilder,distribution=quantal,flavor=amd64/324/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/compiz-ci/324//rebuild/?

review: Approve (continuous-integration)

[Daniel van Vugt (vanvugt)]

Hmm, since the proper fix poses a new potential problem I will approve this despite it being logically incorrect. It's at least safer to return to the old logic we've been using for such a long time already. Even though it contains bug 1087193...

review: Approve

[Daniel van Vugt (vanvugt)]

Argh, now my reasoning is in question. Maybe we can fix this properly. Refer back to the other proposal...

review: Disapprove

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
Approved revid is not set in launchpad (maybe a permission problem?).
http://jenkins.qa.ubuntu.com/job/compiz-mbs-autolanding/149/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-mbs-autolanding/./build=panda-pbuilder,distribution=quantal,flavor=armhf/149/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/149/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/149/console

review: Needs Fixing (continuous-integration)

Unmerged revisions

3529. By Andrea Azzarone on 2012-12-13

Revert r3513.

=== modified file 'src/window.cpp'
--- src/window.cpp	2012-12-13 08:39:22 +0000
+++ src/window.cpp	2012-12-13 09:12:22 +0000
@@ -932,7 +932,7 @@
     if (nInput < 1)
     {
 	inputShapeRects = &r;
-	nInput = 1;
+	nBounding = 1;
     }
 
     priv->region += rectsToRegion (nBounding, boundingShapeRects);