Merge lp:~azzar1/compiz/gcc5 into lp:compiz/0.9.12

Proposed by Andrea Azzarone
Status: Work in progress
Proposed branch: lp:~azzar1/compiz/gcc5
Merge into: lp:compiz/0.9.12
Prerequisite: lp:~azzar1/compiz/c++11
Diff against target: 66 lines (+4/-9)
5 files modified
cmake/CompizCommon.cmake (+0/-5)
plugins/decor/src/decor.cpp (+1/-1)
plugins/opengl/src/programcache.cpp (+1/-1)
plugins/splash/src/splash.cpp (+1/-1)
src/privatescreen/tests/test-privatescreen.cpp (+1/-1)
To merge this branch: bzr merge lp:~azzar1/compiz/gcc5
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Compiz Maintainers Pending
Review via email: mp+266580@code.launchpad.net

Commit message

Enable building compiz from sources using gcc5.

Description of the change

Enable building compiz from sources using gcc5.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

3965. By Andrea Azzarone <email address hidden>

Fixes for gcc5.

3964. By Andrea Azzarone <email address hidden>

Remove use of -Wno-unused-private-field. Seems like it's not supported anymore with gcc5+

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/CompizCommon.cmake'
2--- cmake/CompizCommon.cmake 2015-07-31 14:53:31 +0000
3+++ cmake/CompizCommon.cmake 2015-07-31 14:53:32 +0000
4@@ -53,11 +53,6 @@
5 # Almost everything is a shared library now, so almost everything needs -fPIC
6 set (COMMON_FLAGS "-fPIC -Wall")
7
8-option (COMPIZ_UNUSED_PRIVATE_FIELD_WARNINGS "Warn unused private fields" OFF)
9-if (NOT COMPIZ_UNUSED_PRIVATE_FIELD_WARNINGS)
10- set (COMMON_FLAGS "${COMMON_FLAGS} -Wno-unused-private-field")
11-endif ()
12-
13 option (COMPIZ_UNUSED_LOCAL_TYPEDEFS_WARNINGS "Warn about unused local typedefs" OFF)
14 if (NOT COMPIZ_UNUSED_LOCAL_TYPEDEFS_WARNINGS)
15 set (COMMON_FLAGS "${COMMON_FLAGS} -Wno-unused-local-typedefs")
16
17=== modified file 'plugins/decor/src/decor.cpp'
18--- plugins/decor/src/decor.cpp 2013-10-30 18:02:12 +0000
19+++ plugins/decor/src/decor.cpp 2015-07-31 14:53:32 +0000
20@@ -2537,7 +2537,7 @@
21 {
22 DECOR_WINDOW (w);
23
24- if (dw->isSwitcher && !event->xproperty.state == PropertyDelete)
25+ if (dw->isSwitcher && event->xproperty.state != PropertyDelete)
26 dw->updateSwitcher ();
27 }
28 }
29
30=== modified file 'plugins/opengl/src/programcache.cpp'
31--- plugins/opengl/src/programcache.cpp 2013-01-10 08:19:56 +0000
32+++ plugins/opengl/src/programcache.cpp 2015-07-31 14:53:32 +0000
33@@ -159,7 +159,7 @@
34 // update most recently used GLProgram
35 access_history_t::iterator it = access_history.insert (access_history.end (), name);
36
37- cache.insert (std::make_pair (name, std::make_pair (program, it)));
38+ cache.insert (std::make_pair (name, std::make_pair (boost::shared_ptr<GLProgram>(program), it)));
39 }
40
41 void PrivateProgramCache::evict ()
42
43=== modified file 'plugins/splash/src/splash.cpp'
44--- plugins/splash/src/splash.cpp 2013-05-09 13:43:07 +0000
45+++ plugins/splash/src/splash.cpp 2015-07-31 14:53:32 +0000
46@@ -233,7 +233,7 @@
47 {
48 tex->enable (GLTexture::Good);
49
50- if (!screen->outputDevs ().size () > 1)
51+ if (screen->outputDevs ().size () <= 1)
52 {
53 CompRect headOutputRect =
54 splashGetCurrentOutputRect ();
55
56=== modified file 'src/privatescreen/tests/test-privatescreen.cpp'
57--- src/privatescreen/tests/test-privatescreen.cpp 2014-12-02 18:08:41 +0000
58+++ src/privatescreen/tests/test-privatescreen.cpp 2015-07-31 14:53:32 +0000
59@@ -352,7 +352,7 @@
60 // tell GLib not to use the slice-allocator implementation
61 // and avoid spurious valgrind reporting
62 void glib_nice_for_valgrind() { setenv("G_SLICE", "always-malloc", true); }
63-int const init = (glib_nice_for_valgrind(), 0);
64+__attribute__ ((unused)) int const init = (glib_nice_for_valgrind(), 0);
65
66 PluginFilesystem const* PluginFilesystem::instance = 0;
67

Subscribers

People subscribed via source and target branches