Code review comment for lp:~azzar1/compiz/fix-960652

Daniel van Vugt (vanvugt) wrote :

I can't see any problems. And the fix itself is much simpler and more benign than I initially imagined it would be. I also can't find any regressions in playing with it.

This region of code is very fragile, so any automated tests would have to be external (not modifying code).

I'm happy to ignore the bool/int conversions for now, since the spec does at least allow for it. But not recommended in future.

review: Approve

« Back to merge proposal