This looks correct, as we discussed. You can probably change statements like
> 19 + handled |= match && eventManager.triggerRelease (action, state, arguments);
changed to
bool success = false;
if (match) success = eventManager.triggerRelease (action, state, arguments);
handled |= success;
(|= with bool is safe AIUI)
Are you planning to add any tests for this? Preferably not manual?
« Back to merge proposal
This looks correct, as we discussed. You can probably change statements like
> 19 + handled |= match && eventManager. triggerRelease (action, state, arguments);
changed to
bool success = false;
if (match) triggerRelease (action, state, arguments);
success = eventManager.
handled |= success;
(|= with bool is safe AIUI)
Are you planning to add any tests for this? Preferably not manual?