Merge lp:~azzar1/compiz/fix-960652 into lp:compiz/0.9.8
Proposed by
Andrea Azzarone
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Daniel van Vugt | ||||
Approved revision: | 3300 | ||||
Merged at revision: | 3305 | ||||
Proposed branch: | lp:~azzar1/compiz/fix-960652 | ||||
Merge into: | lp:compiz/0.9.8 | ||||
Diff against target: |
100 lines (+24/-9) 1 file modified
src/event.cpp (+24/-9) |
||||
To merge this branch: | bzr merge lp:~azzar1/compiz/fix-960652 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve | ||
Review via email: mp+117933@code.launchpad.net |
Commit message
Always call terminate callbacks for key bindings. ATM we call just the first
callback. (LP: #960652)
To post a comment you must log in.
This looks correct, as we discussed. You can probably change statements like
> 19 + handled |= match && eventManager. triggerRelease (action, state, arguments);
changed to
bool success = false;
if (match) triggerRelease (action, state, arguments);
success = eventManager.
handled |= success;
(|= with bool is safe AIUI)
Are you planning to add any tests for this? Preferably not manual?