Merge lp:~azzar1/compiz/disable-show-desktop-key into lp:compiz/0.9.10

Proposed by Andrea Azzarone
Status: Merged
Approved by: Francis Ginther
Approved revision: 3778
Merged at revision: 3778
Proposed branch: lp:~azzar1/compiz/disable-show-desktop-key
Merge into: lp:compiz/0.9.10
Diff against target: 31 lines (+3/-4)
1 file modified
debian/patches/ubuntu-config.patch (+3/-4)
To merge this branch: bzr merge lp:~azzar1/compiz/disable-show-desktop-key
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Sam Spilsbury Approve
Review via email: mp+176552@code.launchpad.net

Commit message

Disable show_desktop_key by default on ubuntu. Will provide the same option under the unityshell panel.

Description of the change

Disable show desktop key by default on ubuntu. Will provide the same option under the unity panel.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~andyrock/compiz/disable-show-desktop-key/+merge/176552/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3778
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~andyrock/compiz/disable-show-desktop-key/+merge/176552/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/compiz-team-compiz-0.9.10-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-team-compiz-0.9.10-saucy-amd64-ci/3
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-team-compiz-0.9.10-saucy-armhf-ci/1/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-team-compiz-0.9.10-saucy-i386-ci/3

Click here to trigger a rebuild:
http://s-jenkins:8080/job/compiz-team-compiz-0.9.10-ci/3/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

I missed removal of the coverage collection for armhf. Re-approving?

Revision history for this message
Francis Ginther (fginther) wrote :

Re-approving!

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/patches/ubuntu-config.patch'
2--- debian/patches/ubuntu-config.patch 2013-06-26 08:19:21 +0000
3+++ debian/patches/ubuntu-config.patch 2013-07-23 23:36:27 +0000
4@@ -38,16 +38,15 @@
5 </option>
6 <option name="maximize_window_horizontally_key" type="key">
7 <_short>Maximize Window Horizontally</_short>
8-@@ -215,7 +215,7 @@
9+@@ -215,7 +215,6 @@
10 <option name="show_desktop_key" type="key">
11 <_short>Show Desktop</_short>
12 <_long>Hide all windows and focus desktop</_long>
13 - <default>&lt;Control&gt;&lt;Alt&gt;d</default>
14-+ <default>&lt;Control&gt;&lt;Super&gt;d</default>
15 </option>
16 <option name="show_desktop_edge" type="edge">
17 <_short>Show Desktop</_short>
18-@@ -225,6 +225,7 @@
19+@@ -225,6 +224,7 @@
20 <option name="toggle_window_maximized_key" type="key">
21 <_short>Toggle Window Maximized</_short>
22 <_long>Toggle active window maximized</_long>
23@@ -55,7 +54,7 @@
24 </option>
25 <option name="toggle_window_maximized_button" type="button">
26 <_short>Toggle Window Maximized</_short>
27-@@ -249,7 +250,7 @@
28+@@ -249,7 +249,7 @@
29 <option name="hsize" type="int">
30 <_short>Horizontal Virtual Size</_short>
31 <_long>Screen size multiplier for horizontal virtual size</_long>

Subscribers

People subscribed via source and target branches