lp:~axwalk/juju-core/lp1321492-provideropenstack-tests-gccgo

Created by Andrew Wilkins on 2014-05-22 and last modified on 2014-05-22
Get this branch:
bzr branch lp:~axwalk/juju-core/lp1321492-provideropenstack-tests-gccgo
Only Andrew Wilkins can upload to this branch. If you are Andrew Wilkins please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Andrew Wilkins
Project:
juju-core
Status:
Development

Recent revisions

2765. By Andrew Wilkins on 2014-05-22

provider/openstack: fix tests under gccgo

SameContents again.

Fixes lp:1321492

2764. By Jesse Meek on 2014-05-22

[r=waigani] Validate usernames

Move username regex validation into
names.IsUser. Update codebase to
ensure usernames are validated
where need.

https://codereview.appspot.com/92560043/

R=menno.smits, waigani

2763. By Jesse Meek on 2014-05-21

[r=waigani],[bug=1307241] Fix 1307241. Isolate tests.

Add the following mock functions to
environs/tools/testing/testing.go:

GetMockBundleTools
GetMockBuildTools

Make envtools.BundleTools mockable.
Patch functions in tests where
needed to ensure tests pass without
dependencies on jujud.

2762. By Casey Marshall on 2014-05-21

[r=cmars] Log supercommand name.

In SuperCommand.Run, log the supercommand's name instead of hard-coded 'juju'.

https://codereview.appspot.com/92440046/

2761. By Ian Booth on 2014-05-21

[r=wallyworld] Fix store tests which use bzr

The various test suites in store should
embed FakeHomeSuite not BaseSuite

https://codereview.appspot.com/100590048/

2760. By Andrew Wilkins on 2014-05-21

[r=axwalk],[bug=1321461] replicaset: clean up, extend timeout

Various cleanups, factoring out code, etc.;
uncovered a bit of code that was leaking
an *mgo.Session.

I've extended the attempt strategy total
for replset modifications to 2 minutes,
since the mongo docs say that operations
inducing a renegotiation of primary may
incur downtime of >1m.

I was able to reproduce the error initially
on my machine by running the test in a loop;
I have not reproduced it with these changes.

Fixes lp:1321461

https://codereview.appspot.com/95550044/

2759. By Dave Cheney on 2014-05-21

[r=dave-cheney],[bug=1321521] Fix lp 1321521

Constraints are an unordered set, use SameContents rather than DeepEqual.

2758. By Dave Cheney on 2014-05-21

[r=dave-cheney] Remove thirdparty/pbkdf2

In preparation for the migration to github remove the private copy of pbkdf2.

It is probable that when this package was added, somewhere around 18 months ago, we did not have godeps or a established way of managing dependencies, so vendoring the package made sense at the time.

The only differences between our privat copy and the upstream is our inclusion of our note that the package is a fork.

2757. By Dave Cheney on 2014-05-21

[r=wallyworld] update errgo and loggo deps

Update errgo to pickup the change that removed loggo as a direct dependency as discussed on the mailing list

Update loggo while we're here as Thumper landed a fix to loggo on the 17th.

https://codereview.appspot.com/97570045/

2756. By Dave Cheney on 2014-05-21

[r=dave-cheney],[bug=1320738] constraints: fix lp 1320738

Fixes lp 1320738

Although the red and blue constraints sets are sets, for consistency sort them before looking for the intersection to return predictable error messages. For no particular reason constraints will be sorted by name.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:~go-bot/juju-core/trunk
This branch contains Public information 
Everyone can see this information.

Subscribers