lp:~axwalk/juju-core/lp1260171-stopinstances-ids

Created by Andrew Wilkins on 2014-05-13 and last modified on 2014-05-14
Get this branch:
bzr branch lp:~axwalk/juju-core/lp1260171-stopinstances-ids
Only Andrew Wilkins can upload to this branch. If you are Andrew Wilkins please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Andrew Wilkins
Project:
juju-core
Status:
Merged

Recent revisions

2724. By Andrew Wilkins on 2014-05-14

Make StopInstances variadic

2723. By Andrew Wilkins on 2014-05-13

Change StopInstances to take []instance.Id

StopInstances previously took []instance.Instance,
which is unnecessary for most providers, and imposes
an unnecessary cost for callers that only have IDs
initially. We change StopInstances to

The openstack provider's StopInstances is now slightly
more expensive than before, requiring an additional call
to Instances. This cost will disappear when we fix the
security groups/open-port implementation.

Drive-by: the maas provider now uses a bulk "release"
in StopInstances.

Live tested on ec2, local, virtual MAAS, canonistack, azure.
I lack a Joyent account, but I think it should be fine.

Fixes lp:1260171
Fixes lp:1316272

2722. By Andrew Wilkins on 2014-05-13

[r=axwalk],[bug=1317197] Take hook exec lock in container host init

When initialising the host for a container type,
we will install packages (lxc, kvm, etc.); this can
conflict with hook execution. This CL modifies the
container initialisation code to acquire the hook
execution lock when initialisting the host to avoid
the conflict.

Fixes lp:1317197

https://codereview.appspot.com/91350044/

2721. By Andrew Wilkins on 2014-05-13

[r=axwalk] Invert envcmd relationship

Previously we embedded EnvCommandBase in all commands
requring an environment, and EnvCommandBase included
everything (SetFlags, and Init). The problem with this
is that it was easy to miss initialisation of the
EnvCommandBase type (this happened a few times), which
leads to bad things happening like sync-tools destroying
environments.

I have inverted the relationship so that we now have
envcmd.EnvironCommand, an interface that extends Command
with a SetEnvName method, and EnvCommandBase, which
implements EnvironCommand. A new method, envcmd.Wrap takes
an EnvironCommand and creates a Command that calls
SetEnvName prior to the wrapped method's Init method. If
the environment name cannot be determined, the wrapping
command will error out early.

https://codereview.appspot.com/94350045/

2720. By John A Meinel on 2014-05-12

[r=jameinel],[bug=1301353] testing/mgo: use /usr/lib/juju/bin/mongod

As part of fixing bug #130135, the test suite can now search PATH for
'mongod' and if it doesn't find it, also search for
'/usr/lib/juju/bin/mongod' and disable the store's JS tests.

I came across some other parts of the codebase that were panic() ing
when mongod failed to start, so I fixed that as well.

https://codereview.appspot.com/100380044/

2719. By Menno Finlay-Smits on 2014-05-12

[r=menno.smits] juju/cmd: use RunCommand throughout BootstrapSuite

Replaced uses of cmd.Main with with the RunCommand test helper in
the bootstrap command tests to avoids test boilerplate and make
checking of test results more straightforward.

https://codereview.appspot.com/97330044/

R=thumper

2718. By Jesse Meek on 2014-05-12

[r=waigani],[bug=1318429] Correct debug-log help

Change help message for exclude to read:
"do not show log messages for these entities"

https://codereview.appspot.com/91380044/
R=axwalk

2717. By Jesse Meek on 2014-05-11

[r=waigani],[bug=1299120] Fix 1299120 command aliases

Fix bug 1299120 by ensuring that the
preferred command is not displayed as
an alias of another command in juju
help commands.

Change file and function names to
be consistant with the preferred
command.

https://codereview.appspot.com/92080046/

R=fwereade

2716. By Curtis Hovey on 2014-05-11

[r=sinzui] Increment juju devel to 1.19.3.

Update juju version and win installer to 1.19.3.

https://codereview.appspot.com/94350044/

2715. By Ian Booth on 2014-05-09

[r=wallyworld],[bug=1316869] Merge 1.18 into trunk

This primarily is to pick up the work done
in 1.18 to fix lp:1316869.
It also keeps trunk in sync with 1.18

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:~go-bot/juju-core/trunk
This branch contains Public information 
Everyone can see this information.

Subscribers