Please take a look.
https://codereview.appspot.com/103900045/diff/1/nova/local_test.go File nova/local_test.go (right):
https://codereview.appspot.com/103900045/diff/1/nova/local_test.go#newcode251 nova/local_test.go:251: c.Assert(err, IsNil) On 2014/06/06 04:33:17, dfc wrote: > Are these zones guaranteed to be returned in order? Should this be > jc.SameContents
Yes, they are sorted by the server.
https://codereview.appspot.com/103900045/diff/1/testservices/novaservice/service.go File testservices/novaservice/service.go (right):
https://codereview.appspot.com/103900045/diff/1/testservices/novaservice/service.go#newcode826 testservices/novaservice/service.go:826: sort.Sort(azByName(zones)) On 2014/06/06 04:33:17, dfc wrote: > Please document the order of az's is stored.
Added to the doc comment of this function. There's no user-facing place to add a comment.
https://codereview.appspot.com/103900045/diff/1/testservices/novaservice/service_http_test.go File testservices/novaservice/service_http_test.go (right):
https://codereview.appspot.com/103900045/diff/1/testservices/novaservice/service_http_test.go#newcode1196 testservices/novaservice/service_http_test.go:1196: c.Assert(expected.Zones, DeepEquals, zones) On 2014/06/06 04:33:17, dfc wrote: > jc.SameContents
They are sorted by the server. No need to introduce a dependency on juju/testing/checkers here.
https://codereview.appspot.com/103900045/
« Back to merge proposal
Please take a look.
https:/ /codereview. appspot. com/103900045/ diff/1/ nova/local_ test.go
File nova/local_test.go (right):
https:/ /codereview. appspot. com/103900045/ diff/1/ nova/local_ test.go# newcode251 test.go: 251: c.Assert(err, IsNil)
nova/local_
On 2014/06/06 04:33:17, dfc wrote:
> Are these zones guaranteed to be returned in order? Should this be
> jc.SameContents
Yes, they are sorted by the server.
https:/ /codereview. appspot. com/103900045/ diff/1/ testservices/ novaservice/ service. go novaservice/ service. go (right):
File testservices/
https:/ /codereview. appspot. com/103900045/ diff/1/ testservices/ novaservice/ service. go#newcode826 novaservice/ service. go:826: sort.Sort( azByName( zones))
testservices/
On 2014/06/06 04:33:17, dfc wrote:
> Please document the order of az's is stored.
Added to the doc comment of this function. There's no user-facing place
to add a comment.
https:/ /codereview. appspot. com/103900045/ diff/1/ testservices/ novaservice/ service_ http_test. go novaservice/ service_ http_test. go (right):
File testservices/
https:/ /codereview. appspot. com/103900045/ diff/1/ testservices/ novaservice/ service_ http_test. go#newcode1196 novaservice/ service_ http_test. go:1196: expected. Zones, DeepEquals, zones)
testservices/
c.Assert(
On 2014/06/06 04:33:17, dfc wrote:
> jc.SameContents
They are sorted by the server. No need to introduce a dependency on checkers here.
juju/testing/
https:/ /codereview. appspot. com/103900045/