Merge lp:~axwalk/charms/trusty/mysql/trunk into lp:charms/trusty/mysql

[Andrew Wilkins]

Add support for "storage" feature

This will cause a filesystem to be mounted at "/var/lib/mysql" before installation. By specifying storage constraints, you can choose how to provision the storage; if no storage constraints are specified then rootfs will be used, which is comparable to existing deployments.

The storage subordinate relation is retained for backwards-compatibility.

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #11021 mysql for axwalk mp272679
    LINT FAIL: lint-test failed
    LINT FAIL: charm-proof failed

LINT Results (max last 2 lines):
make: *** [lint] Error 200
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/12608055/
Build: http://10.245.162.77:8080/job/charm_lint_check/11021/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #10231 mysql for axwalk mp272679
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/10231/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #6870 mysql for axwalk mp272679
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12608521/
Build: http://10.245.162.77:8080/job/charm_amulet_test/6870/

[Ryan Beisner (1chb1n)]

Amulet test failure was infrastructure related. Re-running amulet test.

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #6877 mysql for axwalk mp272679
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12615304/
Build: http://10.245.162.77:8080/job/charm_amulet_test/6877/

[Marco Ceppi (marcoceppi)]

I'd argue the storage relation should be removed at this point to encourage users to leverage the existing Juju tools rather than these bolt ons. Since storage isn't GA (yet?) it's Ok to keep.

OSCI seems to be having issues so I'm running this now in the charm testing CI

[Andrew Wilkins (axwalk)]

I think we'll need NFS support in core before we can really consider removing the storage relation.

Also, I was reminded of an issue holding us back from updating the postgresql charm in a similar way: we can't yet upgrade deployments if the new charm revision includes required storage, and the old one did not. We'll have to fix that before storage is GA, at which point I'll swing back around to this.

Unmerged revisions

150. By Andrew Wilkins on 2015-09-25

Add support for "storage" feature

This will cause a filesystem to be mounted
at "/var/lib/mysql" before installation.
If storage is unspecified, then rootfs will
be used, which would be comparable to existing
deployments.

The storage subordinate relation is retained
for backwards-compatibility.

=== modified file 'metadata.yaml'
--- metadata.yaml	2015-07-01 20:47:28 +0000
+++ metadata.yaml	2015-09-29 02:55:48 +0000
@@ -42,3 +42,7 @@
   ha:
     interface: hacluster
     scope: container
+storage:
+  data:
+    type: filesystem
+    location: /var/lib/mysql