Merge lp:~axlrose112/midori/webmedia-now-playing into lp:midori

Proposed by axlrose112
Status: Merged
Approved by: Cris Dywan
Approved revision: no longer in the source branch.
Merged at revision: 6732
Proposed branch: lp:~axlrose112/midori/webmedia-now-playing
Merge into: lp:midori
Diff against target: 36 lines (+2/-10)
1 file modified
extensions/webmedia-now-playing.vala (+2/-10)
To merge this branch: bzr merge lp:~axlrose112/midori/webmedia-now-playing
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+221640@code.launchpad.net

Commit message

Keep storing the last web media tab played.

Description of the change

keep storing the last tab played,

To post a comment you must log in.
6714. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6715. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6716. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6717. By Darcy Luís Neves Brás da Silva

Make middle clicking reload button duplicate the current tab, similar to other browsers

6718. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6719. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6720. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6721. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6722. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6723. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6724. By Cris Dywan

Allocate CookiePermissionManagerModalInfobar correctly

6725. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6726. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6727. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6728. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6729. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6730. By Paweł Forysiuk

Skip compiling webmedia extension on windows

Revision history for this message
Cris Dywan (kalikiana) wrote :

Makes sense.

review: Approve
6731. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6732. By axlrose112

Keep storing the last web media tab played.

Revision history for this message
axlrose112 (axlrose112) wrote :

if user open 10 tabs of youtube, the last tab opnned which will be only registred in dbus, and also if user play video and after switch to wikipedia for example , dbus will keep the title of this video

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/webmedia-now-playing.vala'
2--- extensions/webmedia-now-playing.vala 2014-04-07 21:39:36 +0000
3+++ extensions/webmedia-now-playing.vala 2014-06-01 19:12:05 +0000
4@@ -26,10 +26,6 @@
5 }
6
7 void youtube_validation (string title, string uri) {
8-
9- /* FIXED ME, i used this way because broweser notify send
10- many request and when can not check the right title and also
11- to have one notify*/
12 if(uri == title || uri.contains(title)) return;
13 if (web_media_uri == uri) return;
14 if (web_media_title == title) return;
15@@ -55,11 +51,7 @@
16 dbus_service.video_uri = web_media_uri;
17 web_media_notify.show_notify();
18 }
19- } else {
20- dbus_service.dbus_empty();
21- web_media_title = null;
22- web_media_uri = null;
23- }
24+ }
25 } catch(RegexError e) {
26 warning ("%s", e.message);
27 }
28@@ -125,7 +117,7 @@
29 }
30 }
31 }
32-
33+
34 public class WebMediaNotify {
35 public string notify_video_title { get; set; }
36 public string notify_media { get; set; }

Subscribers

People subscribed via source and target branches

to all changes: