Midori Web Browser

Merge lp:~axlrose112/midori/RemoveCMakeListsWarnings into lp:midori

  1. RemoveCMakeListsWarnings
  2. Merge into trunk
Proposed by axlrose112
Status: Approved
Approved by: Cris Dywan
Approved revision: 7172
Proposed branch: lp:~axlrose112/midori/RemoveCMakeListsWarnings
Merge into: lp:midori
Prerequisite: lp:~midori/midori/webKit2Gtk3only
Diff against target: 12 lines (+1/-1)
1 file modified
CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~axlrose112/midori/RemoveCMakeListsWarnings
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+334262@code.launchpad.net

This proposal supersedes a proposal from 2017-11-24.

Description of the change

Replace -Wno-discarded-qualifiers with -Wno-ignored-qualifiers. Vala warnings.

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Nice catch. Thanks!

review: Approve
Reply

Unmerged revisions

7172. By axlrose112

Replace -Wno-discarded-qualifiers with -Wno-ignored-qualifiers

7171. By Cris Dywan

Drop non-WebKit2 website saving code path

7170. By Cris Dywan

Non-conditional skipping of non-WebKit2 extensions

7169. By Cris Dywan

Drop non-WebKit2/ non-libnotify code paths

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2017-11-24 18:36:50 +0000
3+++ CMakeLists.txt 2017-11-24 18:36:50 +0000
4@@ -204,7 +204,7 @@
5 OR (CMAKE_C_COMPILER_ID STREQUAL "Clang" AND CMAKE_C_COMPILER_VERSION VERSION_GREATER "3.0.0"))
6 set(VALA_CFLAGS "${VALA_CFLAGS} -Werror=implicit-function-declaration")
7 set(VALA_CFLAGS "${VALA_CFLAGS} -Wno-incompatible-pointer-types")
8- set(VALA_CFLAGS "${VALA_CFLAGS} -Wno-discarded-qualifiers")
9+ set(VALA_CFLAGS "${VALA_CFLAGS} -Wno-ignored-qualifiers")
10 set(VALA_CFLAGS "${VALA_CFLAGS} -Wno-deprecated-declarations")
11 else ()
12 set(VALA_CFLAGS "${VALA_CFLAGS} -w")

Subscribers

People subscribed via source and target branches

to all changes: