Prometheus SNMP Exporter Charm

Merge ~axino/prometheus-snmp-exporter-charm:axino into prometheus-snmp-exporter-charm:master

  1. Git
  2. lp:~axino/prometheus-snmp-exporter-charm
  3. axino
  4. Merge into master
Proposed by Junien F
Status: Merged
Approved by: Jay Kuri
Approved revision: 3a3a91c08bb15d6c40fd6aaaa6decde5f95239da
Merged at revision: 4d535ced22643201973dfe33cbb9a744866643f3
Proposed branch: ~axino/prometheus-snmp-exporter-charm:axino
Merge into: prometheus-snmp-exporter-charm:master
Diff against target: 11 lines (+1/-1)
1 file modified
reactive/prometheus-snmp-exporter.py (+1/-1)
Reviewer Review Type Date Requested Status
Canonical IS Reviewers Pending
Prometheus Charmers Pending
Review via email: mp+402512@code.launchpad.net

Commit message

the "http" interface changed, so fix accordingly

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 4d535ced22643201973dfe33cbb9a744866643f3

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reactive/prometheus-snmp-exporter.py b/reactive/prometheus-snmp-exporter.py
2index e897c01..07074aa 100644
3--- a/reactive/prometheus-snmp-exporter.py
4+++ b/reactive/prometheus-snmp-exporter.py
5@@ -86,5 +86,5 @@ def restart_snmp_exporter():
6 # Relations
7 @when('snmp-exporter.started')
8 @when('snmp-exporter.available') # Relation name is "snmp-exporter"
9-def configure_snmp_exporter_relation(target):
10+def configure_snmp_exporter_relation(self, target):
11 target.configure(PORT_DEF)

Subscribers

People subscribed via source and target branches

to all changes: