Juju Charms Collection
postgresql package

Merge lp:~axino/charms/trusty/postgresql/write-nagios-service-files into lp:charms/trusty/postgresql

  1. Trusty Tahr (14.04)
  2. write-nagios-service-files
  3. Merge into trunk
Proposed by Junien F
Status: Merged
Merged at revision: 136
Proposed branch: lp:~axino/charms/trusty/postgresql/write-nagios-service-files
Merge into: lp:charms/trusty/postgresql
Diff against target: 10 lines (+1/-0)
1 file modified
hooks/definitions.py (+1/-0)
To merge this branch: bzr merge lp:~axino/charms/trusty/postgresql/write-nagios-service-files
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Review Queue (community) automated testing Needs Fixing
Review via email: mp+280726@code.launchpad.net

Description of the change

add missing 'nagios.update_nrpe_config' in definitions.py

Without this, the service__ files are never written.

To post a comment you must log in.
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/1851/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/1831/

review: Needs Fixing (automated testing)
Revision history for this message
Stuart Bishop (stub) wrote :

Whoops. And we wouldn't have noticed on existing deploys as the files would already be there.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/definitions.py'
2--- hooks/definitions.py 2015-08-20 11:31:28 +0000
3+++ hooks/definitions.py 2015-12-16 15:00:47 +0000
4@@ -64,6 +64,7 @@
5
6 replication.ensure_replication_user,
7 nagios.ensure_nagios_user,
8+ nagios.update_nrpe_config,
9 service.install_administrative_scripts,
10 service.update_postgresql_crontab,
11

Subscribers

People subscribed via source and target branches

to all changes: