snappy-hwe-snaps

Merge ~awe/snappy-hwe-snaps/+git/tpm:rm-dup-getpubek into ~snappy-hwe-team/snappy-hwe-snaps/+git/tpm:master

  1. Git
  2. lp:~awe/snappy-hwe-snaps/+git/tpm
  3. rm-dup-getpubek
  4. Merge into master
Proposed by Tony Espy
Status: Merged
Approved by: Simon Fels
Approved revision: 31f915a33d9eebe3c1cd60f834b6ec2c1f532ce1
Merged at revision: 359fccaf8e4c8f407d973b461d4e047bfec88e3a
Proposed branch: ~awe/snappy-hwe-snaps/+git/tpm:rm-dup-getpubek
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/tpm:master
Diff against target: 14 lines (+0/-3)
1 file modified
snapcraft.yaml (+0/-3)
Reviewer Review Type Date Requested Status
Simon Fels Approve
Review via email: mp+305416@code.launchpad.net

Description of the change

This change removes a duplicate app definition for tpm_getpubek command.

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) wrote :

Interesting that the snapcraft build doesn't get this. Looks like a dictionary problem. However, LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 92945e2..db62c2d 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -39,9 +39,6 @@ apps:
6 clear:
7 command: sbin/tpm_clear
8 plugs: [network]
9- getpubek:
10- command: sbin/tpm_getpubek
11- plugs: [network]
12 nvinfo:
13 command: sbin/tpm_nvinfo
14 plugs: [network]

Subscribers

People subscribed via source and target branches

to all changes: