Avishai,
Some comments. Sorry for taking so long to see this.
* BIN_PATHS: I would really prefer that we just use PATH to look for executables. If the system is not set up to have PATH set correctly, the user should just use a full path. ie, the right way to get your executable found is to put it in PATH.
* repo_path': '/var/lib/cloud/chef_repo'
doesn't this fit better somewhere else ? I"m not entirely opposed to it, but it just seems like there is likely somewhere else to look. Also, if you're using /var/lib/cloud, please get it through 'cloud_dir' in the Paths object (cloud.paths).
* some tests would be nice.
Thanks for the submission, sorry its taken so long to get around to it.
Avishai, cloud/chef_ repo'
Some comments. Sorry for taking so long to see this.
* BIN_PATHS: I would really prefer that we just use PATH to look for executables. If the system is not set up to have PATH set correctly, the user should just use a full path. ie, the right way to get your executable found is to put it in PATH.
* repo_path': '/var/lib/
doesn't this fit better somewhere else ? I"m not entirely opposed to it, but it just seems like there is likely somewhere else to look. Also, if you're using /var/lib/cloud, please get it through 'cloud_dir' in the Paths object (cloud.paths).
* some tests would be nice.
Thanks for the submission, sorry its taken so long to get around to it.