Code review comment for lp:~attente/unity-settings-daemon/gnome-key-grabber

Revision history for this message
Sebastien Bacher (seb128) wrote :

You didn't misunderstood, we though it would be the case, but it turned out that some flavors/session feel like they are closer from unity (they use indicators, they don't want the new GtkHeaderBars, they want menus) ... so we are revisiting the approch and going to make those sessions be variant of Unity rather than GNOME.

Thanks for updating it

One small comment, we usually do check for XDG_CURRENT_DESKTOP=GNOME|Unity, is there any reason to look at DESKTOP_SESSION there?

review: Needs Information

« Back to merge proposal