Merge lp:~attente/unity-gtk-module/1313184 into lp:unity-gtk-module/14.10

[William Hua]

Make up a bad state name if we can't infer a good name from a radio menu item's label or action.

Make up a bad state name if we can't infer a good name from a radio menu item's label or action.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:327
http://jenkins.qa.ubuntu.com/job/unity-gtk-module-ci/52/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-gtk-module-utopic-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-gtk-module-utopic-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/unity-gtk-module-utopic-armhf-ci/6/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-gtk-module-ci/52/rebuild

review: Approve (continuous-integration)

[Charles Kerr (charlesk)]

This is a sane fallback imo.

review: Approve

=== modified file 'lib/unity-gtk-action-group.c'
--- lib/unity-gtk-action-group.c	2014-03-25 21:48:16 +0000
+++ lib/unity-gtk-action-group.c	2014-05-28 13:42:56 +0000
@@ -777,6 +777,18 @@
                 }
             }
         }
+
+      if (name == NULL)
+        {
+          /*
+           * We tried to find a good name for this radio menu item state, but
+           * the application wasn't nice enough to give us one, either by label
+           * or by action. So we have to pick a bad name which is unique for
+           * any given UnityGtkMenuItem.
+           */
+
+          name = g_strdup_printf ("%p", item);
+        }
     }
 
   return name;