lp:~attente/unity-gtk-module/1294947-fix-criticals

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity-gtk-module/14.04 at revision 323

Robert Ancell: Approve on 2014-03-23

PS Jenkins bot (community): Approve (continuous-integration) on 2014-03-23

Diff: 11 lines (+2/-0)

1 file modified

lib/unity-gtk-menu-item.c (+2/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1294947: Inkscape mnemonics parsed incorrectly

High

Fix Released

Link a bug report

Related blueprints

321. By William Hua on 2014-03-23

Forgot to NULL-terminate duplicated string.

320. By PS Jenkins bot on 2014-03-19

Releasing 0.0.0+14.04.20140319-0ubuntu1

319. By William Hua on 2014-03-19

Watch use-underline property on GtkMenuItems. Fixes: 1260777

318. By PS Jenkins bot on 2014-03-11

Releasing 0.0.0+14.04.20140311-0ubuntu1

317. By PS Jenkins bot on 2014-03-11

Release trunk to the archive

316. By William Hua on 2014-03-06

Dispatch gtk_menu_item_activate () in a GDK idle. Fixes: https://bugs.launchpad.net/bugs/1258669.

Approved by Charles Kerr, PS Jenkins bot.

315. By William Hua on 2014-03-06

Filter out mnemonics when the gtk-enable-mnemonics setting is cleared. Workaround for LP: #1282782. Fixes: https://bugs.launchpad.net/bugs/1282782.

Approved by Sebastien Bacher, PS Jenkins bot.

314. By PS Jenkins bot on 2014-02-13

Releasing 0.0.0+14.04.20140213.2-0ubuntu1 (revision 313 from lp:unity-gtk-module).

Approved by PS Jenkins bot.

313. By William Hua on 2014-01-13

Remove our g_ptr_array_insert (), it's added in GLib 2.40.

Approved by PS Jenkins bot, Lars Uebernickel.

312. By William Hua on 2013-12-13

Relax the preconditions for disconnecting action groups from shells. (LP: #1198471)

If we have this situation:

  Menu A (action group G)
    Menu B (action group G)
      Menu C (action group G) <- about to be destroyed
        Menu D (action group G)
          Menu E (action group G)

and Menu C is destroyed, we get:

  Menu A (action group G)
    Menu B (action group G)
      Menu C (no action group)
        Menu D (no action group)
          Menu E (no action group)

So when Menu A is disconnected from G, this causes the warnings from LP: #1198471.

One thing we could have tried was just removing the tree rooted at Menu C, but then that would break removing the entire tree rooted at Menu A. Also, we'd have to end up doing this by having the Menu C unref itself.

It's really easiest to treat it as a dead sub-tree that will be finalized when the entire tree is finalized. Let's relax the preconditions on the unity_gtk_action_group_disconnect_item and unity_gtk_action_group_disconnect_shell functions, and allow the case where the shell's action group is already set to NULL. Fixes: https://bugs.launchpad.net/bugs/1198471.

Approved by Lars Uebernickel, PS Jenkins bot.