Merge lp:~attente/unity-control-center/fix-ftbfs-inline-zoom-options into lp:unity-control-center

Proposed by William Hua on 2015-11-25
Status: Merged
Approved by: Sebastien Bacher on 2015-12-14
Approved revision: 12840
Merged at revision: 12842
Proposed branch: lp:~attente/unity-control-center/fix-ftbfs-inline-zoom-options
Merge into: lp:unity-control-center
Diff against target: 39 lines (+6/-6)
1 file modified
panels/universal-access/zoom-options.c (+6/-6)
To merge this branch: bzr merge lp:~attente/unity-control-center/fix-ftbfs-inline-zoom-options
Reviewer Review Type Date Requested Status
Didier Roche 2015-11-25 Approve on 2015-11-27
Review via email: mp+278655@code.launchpad.net

Commit message

Fix FTBFS due to non-deterministic compilation of non-static inline functions.

Description of the change

Fix FTBFS due to non-deterministic compilation of non-static inline functions.

To post a comment you must log in.
Didier Roche (didrocks) wrote :

I can't reproduce the FTBFS with the latest version from the archive on my xenial sbuild. How do you see it? I wonder if we shouldn't rather bundle that with another landing (I didn't see any silo shipping those, and so, no FTBFS there either).

review: Needs Information
William Hua (attente) wrote :

Just for reference, this is the comment from upstream that explains its irreproducibility: https://bugzilla.gnome.org/show_bug.cgi?id=723994#c0

Didier Roche (didrocks) wrote :

As discussed, we will bundle this with next u-c-c upload

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'panels/universal-access/zoom-options.c'
2--- panels/universal-access/zoom-options.c 2012-08-15 18:07:56 +0000
3+++ panels/universal-access/zoom-options.c 2015-11-25 22:11:01 +0000
4@@ -63,9 +63,9 @@
5 NULL
6 };
7
8-inline void set_active (GtkWidget* toggle, gboolean sense);
9-inline gboolean get_active (GtkWidget* toggle);
10-inline void set_sensitive (GtkWidget *widget, gboolean sense);
11+static void set_active (GtkWidget* toggle, gboolean sense);
12+static gboolean get_active (GtkWidget* toggle);
13+static void set_sensitive (GtkWidget *widget, gboolean sense);
14
15 static void set_enable_screen_part_ui (GtkWidget *widget, ZoomOptionsPrivate *priv);
16 static void mouse_tracking_notify_cb (GSettings *settings, const gchar *key, ZoomOptionsPrivate *priv);
17@@ -79,19 +79,19 @@
18
19 /* Utilties to save on line length */
20
21-inline void
22+static void
23 set_active (GtkWidget* toggle, gboolean sense)
24 {
25 gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (toggle), sense);
26 }
27
28-inline gboolean
29+static gboolean
30 get_active (GtkWidget* toggle)
31 {
32 return gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (toggle));
33 }
34
35-inline void
36+static void
37 set_sensitive (GtkWidget *widget, gboolean sense)
38 {
39 gtk_widget_set_sensitive (widget, sense);

Subscribers

People subscribed via source and target branches