Merge lp:~attente/indicator-keyboard/accountsservice into lp:indicator-keyboard

[William Hua]

Use accountsservice and make work under unity-greeter.

Use accountsservice and make work under unity-greeter.

This branch depends on the debdiff from https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1209227.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:99
http://jenkins.qa.ubuntu.com/job/indicator-keyboard-ci/4/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-amd64-ci/4/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-armhf-ci/4/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/indicator-keyboard-ci/4/rebuild

review: Needs Fixing (continuous-integration)

[Sebastien Bacher (seb128)]

seems fine to me and we have the accountsservice patch in now

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/indicator-keyboard-autolanding/8/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/generic-cleanup-mbs/1613/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-amd64-autolanding/8/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-armhf-autolanding/8/console

review: Needs Fixing (continuous-integration)

[lp:~attente/indicator-keyboard/accountsservice]

100. By William Hua on 2013-08-22

Merge trunk.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:100
http://jenkins.qa.ubuntu.com/job/indicator-keyboard-ci/19/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-amd64-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-armhf-ci/19

Click here to trigger a rebuild:
http://s-jenkins:8080/job/indicator-keyboard-ci/19/rebuild

review: Approve (continuous-integration)

=== modified file 'configure.ac'
--- configure.ac	2013-08-08 18:41:27 +0000
+++ configure.ac	2013-08-22 10:36:45 +0000
@@ -70,6 +70,14 @@
 AC_SUBST([IBUS_CFLAGS])
 AC_SUBST([IBUS_LIBS])
 
+PKG_CHECK_MODULES([ACCOUNTSSERVICE], [accountsservice])
+AC_SUBST([ACCOUNTSSERVICE_CFLAGS])
+AC_SUBST([ACCOUNTSSERVICE_LIBS])
+
+PKG_CHECK_MODULES([LIGHTDM], [liblightdm-gobject-1])
+AC_SUBST([LIGHTDM_CFLAGS])
+AC_SUBST([LIGHTDM_LIBS])
+
 PKG_CHECK_MODULES([BAMF], [libbamf3])
 AC_SUBST([BAMF_CFLAGS])
 AC_SUBST([BAMF_LIBS])

=== modified file 'data/Makefile.am'
--- data/Makefile.am	2013-07-18 22:01:28 +0000
+++ data/Makefile.am	2013-08-22 10:36:45 +0000
@@ -48,6 +48,9 @@
 	             echo 'ObjectPath=/com/canonical/indicator/keyboard';                     \
 	             echo '';                                                                 \
 	             echo '[desktop]';                                                        \
+	             echo 'ObjectPath=/com/canonical/indicator/keyboard/desktop';             \
+	             echo '';                                                                 \
+	             echo '[desktop_greeter]';                                                \
 	             echo 'ObjectPath=/com/canonical/indicator/keyboard/desktop') > $@.tmp && \
 	            mv $@.tmp $@
 

=== modified file 'debian/control'
--- debian/control	2013-08-07 15:20:47 +0000
+++ debian/control	2013-08-22 10:36:45 +0000
@@ -8,6 +8,7 @@
                dh-autoreconf,
                dh-translations,
                dbus,
+               libaccountsservice-dev,
                libbamf3-dev,
                libgee-dev,
                libgirepository1.0-dev,
@@ -15,6 +16,7 @@
                libgnomekbd-dev,
                libgtk-3-dev,
                libibus-1.0-dev (>= 1.5.0),
+               liblightdm-gobject-1-dev,
                valac,
                xauth,
                xvfb,

=== modified file 'lib/Makefile.am'
--- lib/Makefile.am	2013-08-07 19:11:32 +0000
+++ lib/Makefile.am	2013-08-22 10:36:45 +0000
@@ -9,32 +9,38 @@
 indicator_keyboard_service_SOURCES = main.vala   \
                                      source.vala \
                                      common.vala
-indicator_keyboard_service_VALAFLAGS = $(AM_VALAFLAGS)         \
-                                       --pkg gee-1.0           \
-                                       --pkg posix             \
-                                       --pkg pangocairo        \
-                                       --pkg gtk+-3.0          \
-                                       --pkg GDesktopEnums-3.0 \
-                                       --pkg gnome-desktop-3.0 \
-                                       --pkg Xkl-1.0           \
-                                       --pkg Gkbd-3.0          \
-                                       --pkg ibus-1.0          \
+indicator_keyboard_service_VALAFLAGS = $(AM_VALAFLAGS)            \
+                                       --pkg gee-1.0              \
+                                       --pkg posix                \
+                                       --pkg pangocairo           \
+                                       --pkg gtk+-3.0             \
+                                       --pkg GDesktopEnums-3.0    \
+                                       --pkg gnome-desktop-3.0    \
+                                       --pkg Xkl-1.0              \
+                                       --pkg Gkbd-3.0             \
+                                       --pkg ibus-1.0             \
+                                       --pkg accountsservice      \
+                                       --pkg liblightdm-gobject-1 \
                                        --pkg libbamf3
-indicator_keyboard_service_CFLAGS = $(AM_CFLAGS)            \
-                                    $(GEE_CFLAGS)           \
-                                    $(PANGOCAIRO_CFLAGS)    \
-                                    $(GTK_CFLAGS)           \
-                                    $(GNOME_DESKTOP_CFLAGS) \
-                                    $(LIBXKLAVIER_CFLAGS)   \
-                                    $(LIBGNOMEKBD_CFLAGS)   \
-                                    $(IBUS_CFLAGS)          \
+indicator_keyboard_service_CFLAGS = $(AM_CFLAGS)              \
+                                    $(GEE_CFLAGS)             \
+                                    $(PANGOCAIRO_CFLAGS)      \
+                                    $(GTK_CFLAGS)             \
+                                    $(GNOME_DESKTOP_CFLAGS)   \
+                                    $(LIBXKLAVIER_CFLAGS)     \
+                                    $(LIBGNOMEKBD_CFLAGS)     \
+                                    $(IBUS_CFLAGS)            \
+                                    $(ACCOUNTSSERVICE_CFLAGS) \
+                                    $(LIGHTDM_CFLAGS)         \
                                     $(BAMF_CFLAGS)
-indicator_keyboard_service_LDFLAGS = $(AM_LDFLAGS)         \
-                                     $(GEE_LIBS)           \
-                                     $(PANGOCAIRO_LIBS)    \
-                                     $(GTK_LIBS)           \
-                                     $(GNOME_DESKTOP_LIBS) \
-                                     $(LIBXKLAVIER_LIBS)   \
-                                     $(LIBGNOMEKBD_LIBS)   \
-                                     $(IBUS_LIBS)          \
+indicator_keyboard_service_LDFLAGS = $(AM_LDFLAGS)           \
+                                     $(GEE_LIBS)             \
+                                     $(PANGOCAIRO_LIBS)      \
+                                     $(GTK_LIBS)             \
+                                     $(GNOME_DESKTOP_LIBS)   \
+                                     $(LIBXKLAVIER_LIBS)     \
+                                     $(LIBGNOMEKBD_LIBS)     \
+                                     $(IBUS_LIBS)            \
+                                     $(ACCOUNTSSERVICE_LIBS) \
+                                     $(LIGHTDM_LIBS)         \
                                      $(BAMF_LIBS)

=== modified file 'lib/main.vala'
--- lib/main.vala	2013-08-12 01:33:27 +0000
+++ lib/main.vala	2013-08-22 10:36:45 +0000
@@ -29,6 +29,7 @@
 	private Settings indicator_settings;
 	private Settings source_settings;
 	private Settings per_window_settings;
+	private SList<Act.User> users;
 	private Bamf.Matcher? matcher;
 	private Gee.HashMap<string, uint>? window_sources;
 
@@ -67,6 +68,11 @@
 	}
 
 	[DBus (visible = false)]
+	private static bool is_login_user () {
+		return Environment.get_user_name () == "lightdm";
+	}
+
+	[DBus (visible = false)]
 	private static IBus.Bus get_ibus () {
 		if (ibus == null) {
 			IBus.init ();
@@ -91,64 +97,177 @@
 
 	[DBus (visible = false)]
 	private void migrate_keyboard_layouts () {
-		if (!indicator_settings.get_boolean ("migrated")) {
-			var builder = new VariantBuilder (new VariantType ("a(ss)"));
-			var length = 0;
-
-			var layout_settings = new Settings ("org.gnome.libgnomekbd.keyboard");
-			var layouts = layout_settings.get_strv ("layouts");
-
-			foreach (var layout in layouts) {
-				var source = layout;
-
-				source = source.replace (" ", "+");
-				source = source.replace ("\t", "+");
-
-				builder.add ("(ss)", "xkb", source);
-				length++;
+		if (is_login_user ()) {
+			Act.UserManager manager = Act.UserManager.get_default ();
+
+			if (manager.is_loaded) {
+				users = manager.list_users ();
+
+				foreach (var user in users) {
+					if (user.is_loaded) {
+						migrate_input_sources ();
+					} else {
+						user.notify["is-loaded"].connect ((pspec) => {
+							if (user.is_loaded) {
+								migrate_input_sources ();
+							}
+						});
+					}
+				}
+			} else {
+				manager.notify["is-loaded"].connect ((pspec) => {
+					if (manager.is_loaded) {
+						users = manager.list_users ();
+
+						foreach (var user in users) {
+							if (user.is_loaded) {
+								migrate_input_sources ();
+							} else {
+								user.notify["is-loaded"].connect ((pspec) => {
+									if (user.is_loaded) {
+										migrate_input_sources ();
+									}
+								});
+							}
+						}
+					}
+				});
 			}
-
-			var engines = get_ibus ().list_active_engines ();
-
-			foreach (var engine in engines) {
-				if (length == 0 || engine.name.has_prefix ("xkb")) {
-					var source = "us";
-					string? layout = engine.get_layout ();
-					string? variant = engine.get_layout_variant ();
-
-					if (layout != null && ((!) layout).length == 0) {
-						layout = null;
-					}
-
-					if (variant != null && ((!) variant).length == 0) {
-						variant = null;
-					}
-
-					if (layout != null && variant != null) {
-						source = @"$((!) layout)+$((!) variant)";
-					} else if (layout != null) {
-						source = (!) layout;
-					}
+		} else {
+			if (!indicator_settings.get_boolean ("migrated")) {
+				var builder = new VariantBuilder (new VariantType ("a(ss)"));
+				var length = 0;
+
+				var layout_settings = new Settings ("org.gnome.libgnomekbd.keyboard");
+				var layouts = layout_settings.get_strv ("layouts");
+
+				foreach (var layout in layouts) {
+					var source = layout;
+					source = source.replace (" ", "+");
+					source = source.replace ("\t", "+");
 
 					builder.add ("(ss)", "xkb", source);
 					length++;
 				}
 
-				if (!engine.name.has_prefix ("xkb")) {
-					builder.add ("(ss)", "ibus", engine.name);
-					length++;
-				}
-			}
-
-			source_settings.set_value ("sources", builder.end ());
-
-			indicator_settings.set_boolean ("migrated", true);
+				var engines = get_ibus ().list_active_engines ();
+
+				foreach (var engine in engines) {
+					if (length == 0 || engine.name.has_prefix ("xkb")) {
+						var source = "us";
+						string? layout = engine.get_layout ();
+						string? variant = engine.get_layout_variant ();
+
+						if (layout != null && ((!) layout).length == 0) {
+							layout = null;
+						}
+
+						if (variant != null && ((!) variant).length == 0) {
+							variant = null;
+						}
+
+						if (layout != null && variant != null) {
+							source = @"$((!) layout)+$((!) variant)";
+						} else if (layout != null) {
+							source = (!) layout;
+						}
+
+						builder.add ("(ss)", "xkb", source);
+						length++;
+					}
+
+					if (!engine.name.has_prefix ("xkb")) {
+						builder.add ("(ss)", "ibus", engine.name);
+						length++;
+					}
+				}
+
+				source_settings.set_value ("sources", builder.end ());
+				indicator_settings.set_boolean ("migrated", true);
+			}
+		}
+	}
+
+	[DBus (visible = false)]
+	private void migrate_input_sources () {
+		var list = new Gee.LinkedList<string> ();
+		var added = new Gee.HashSet<string> ();
+
+		foreach (var user in users) {
+			if (user.is_loaded) {
+				var sources = user.input_sources;
+				var layouts = user.xkeyboard_layouts;
+
+				VariantIter outer;
+				VariantIter inner;
+
+				sources.get ("aa{ss}", out outer);
+
+				while (outer.next ("a{ss}", out inner)) {
+					unowned string key;
+					unowned string source;
+
+					while (inner.next ("{&s&s}", out key, out source)) {
+						if (key == "xkb") {
+							if (!added.contains (source)) {
+								list.add (source);
+								added.add (source);
+							}
+						}
+					}
+				}
+
+				foreach (var layout in layouts) {
+					var source = layout;
+					source = source.replace (" ", "+");
+					source = source.replace ("\t", "+");
+
+					if (!added.contains (source)) {
+						list.add (source);
+						added.add (source);
+					}
+				}
+			}
+		}
+
+		var builder = new VariantBuilder (new VariantType ("a(ss)"));
+
+		foreach (var layout in list) {
+			builder.add ("(ss)", "xkb", layout);
+		}
+
+		source_settings.set_value ("sources", builder.end ());
+	}
+
+	[DBus (visible = false)]
+	private void update_login_layout () {
+		unowned List<LightDM.Layout> layouts = LightDM.get_layouts ();
+		var current = source_settings.get_uint ("current");
+
+		if (current < get_sources ().length) {
+			var source = get_sources ()[current];
+			string? name = null;
+
+			if (source.layout != null && source.variant != null) {
+				name = @"$((!) source.layout)\t$((!) source.variant)";
+			} else if (source.layout != null) {
+				name = source.layout;
+			}
+
+			if (name != null) {
+				foreach (var layout in layouts) {
+					if (layout.name == (!) name) {
+						LightDM.set_layout (layout);
+						break;
+					}
+				}
+			}
 		}
 	}
 
 	[DBus (visible = false)]
 	private void update_window_sources () {
-		if (use_bamf) {
+		if (use_bamf && !is_login_user ()) {
 			var group_per_window = per_window_settings.get_boolean ("group-per-window");
 
 			if (group_per_window != (window_sources != null)) {
@@ -324,11 +443,13 @@
 
 		submenu.append_section (null, section_menu);
 
-		var section = new Menu ();
-		section.append (_ ("Character Map"), "indicator.map");
-		section.append (_ ("Keyboard Layout Chart"), "indicator.chart");
-		section.append (_ ("Text Entry Settings..."), "indicator.settings");
-		submenu.append_section (null, section);
+		if (!is_login_user ()) {
+			var section = new Menu ();
+			section.append (_ ("Character Map"), "indicator.map");
+			section.append (_ ("Keyboard Layout Chart"), "indicator.chart");
+			section.append (_ ("Text Entry Settings..."), "indicator.settings");
+			submenu.append_section (null, section);
+		}
 
 		var indicator = new MenuItem.submenu ("x", submenu);
 		indicator.set_attribute ("x-canonical-type", "s", "com.canonical.indicator.root");
@@ -355,6 +476,7 @@
 	[DBus (visible = false)]
 	private void handle_changed_current (string key) {
 		update_indicator_action ();
+		update_login_layout ();
 	}
 
 	[DBus (visible = false)]
@@ -363,6 +485,7 @@
 
 		update_sources_menu ();
 		update_indicator_action ();
+		update_login_layout ();
 	}
 
 	[DBus (visible = false)]