Merge lp:~attente/indicator-keyboard/1291962 into lp:indicator-keyboard

[William Hua]

Export separate menus for desktop and greeter.

Export separate menus for desktop and greeter.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:319
http://jenkins.qa.ubuntu.com/job/indicator-keyboard-ci/53/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-trusty-amd64-ci/20
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-trusty-armhf-ci/20
        deb: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-trusty-armhf-ci/20/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-keyboard-ci/53/rebuild

review: Approve (continuous-integration)

[lp:~attente/indicator-keyboard/1291962]

320. By William Hua on 2014-03-27

Merge 1290881.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:320
http://jenkins.qa.ubuntu.com/job/indicator-keyboard-ci/54/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-trusty-amd64-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-trusty-armhf-ci/21
        deb: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-trusty-armhf-ci/21/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-keyboard-ci/54/rebuild

review: Approve (continuous-integration)

[Ted Gould (ted)]

I think that this is wrong:

+Breaks: ibus (<< 1.5.5-1ubuntu3),

Will Ibus be broken or do we need a version of Ibus newer than that?

review: Needs Information

[William Hua (attente)]

IBus won't be broken, but we want to prevent this version of indicator-keyboard to be unpacked if the IBus on the user's system doesn't have the patch introduced by 1.5.5-1ubuntu3. I think that's what the Breaks relationship does based on https://www.debian.org/doc/debian-policy/ch-relationships.html#s-breaks.

[Sebastien Bacher (seb128)]

The other branch your merged in r320 landed to trunk, you might want to redo those changes based on trunk to have a diff easier to read (seems like some of the current one is from the other changes). One way to avoid that issue is to list the vcs you are based on/include as a prerequire (needs to resubmit the change though)

[William Hua (attente)]

Ok, I can re-submit a new branch. I only merged those in because I expected there to be merge conflicts with those other branches.

[William Hua (attente)]

Re-submitted as https://code.launchpad.net/~attente/indicator-keyboard/1291962-2/+merge/213346.

Unmerged revisions

=== modified file '.bzrignore'
--- .bzrignore	2013-08-08 22:15:00 +0000
+++ .bzrignore	2014-03-27 10:43:37 +0000
@@ -29,6 +29,8 @@
 po/POTFILES
 po/stamp-it
 tests/config.vala
+tests/dconf-service
+tests/gvfs
 tests/indicator-keyboard-test
 tests/indicator-keyboard-test.trs
 tests/indicator-keyboard-tests
@@ -39,4 +41,4 @@
 m4/lt~obsolete.m4
 m4/ltoptions.m4
 m4/ltsugar.m4
-m4/ltversion.m4
\ No newline at end of file
+m4/ltversion.m4

=== modified file 'data/Makefile.am'
--- data/Makefile.am	2014-03-11 13:25:54 +0000
+++ data/Makefile.am	2014-03-27 10:43:37 +0000
@@ -54,10 +54,10 @@
 	             echo 'ObjectPath=/com/canonical/indicator/keyboard/desktop';             \
 	             echo '';                                                                 \
 	             echo '[desktop_greeter]';                                                \
-	             echo 'ObjectPath=/com/canonical/indicator/keyboard/desktop';             \
+	             echo 'ObjectPath=/com/canonical/indicator/keyboard/desktop_greeter';     \
 	             echo '';                                                                 \
 	             echo '[desktop_lockscreen]';                                             \
-	             echo 'ObjectPath=/com/canonical/indicator/keyboard/desktop';             \
+	             echo 'ObjectPath=/com/canonical/indicator/keyboard/desktop_greeter';     \
 	             echo '';                                                                 \
 	             echo '[ubiquity]';                                                       \
 	             echo 'ObjectPath=/com/canonical/indicator/keyboard/desktop') > $@.tmp && \

=== modified file 'debian/control'
--- debian/control	2013-11-22 16:44:45 +0000
+++ debian/control	2014-03-27 10:43:37 +0000
@@ -30,6 +30,7 @@
 Architecture: any
 Depends: ${misc:Depends},
          ${shlibs:Depends},
+Breaks: ibus (<< 1.5.5-1ubuntu3),
 Description: Keyboard indicator
  This package contains the keyboard indicator, which should show as an icon in
  the top panel when using the Unity environment. It can be used to switch

=== modified file 'lib/Makefile.am'
--- lib/Makefile.am	2014-02-19 16:10:54 +0000
+++ lib/Makefile.am	2014-03-27 10:43:37 +0000
@@ -6,11 +6,13 @@
                --metadatadir $(top_srcdir)/deps \
                --vapidir $(top_srcdir)/deps
 
-indicator_keyboard_service_SOURCES = main.vala          \
-                                     source.vala        \
-                                     common.vala        \
-                                     ibus-menu.vala     \
-                                     window-stack.vala  \
+indicator_keyboard_service_SOURCES = main.vala           \
+                                     source.vala         \
+                                     common.vala         \
+                                     ibus-menu.vala      \
+                                     ibus-panel.vala     \
+                                     indicator-menu.vala \
+                                     window-stack.vala   \
                                      unity-greeter.vala
 indicator_keyboard_service_VALAFLAGS = $(AM_VALAFLAGS)            \
                                        --pkg gee-1.0              \

=== modified file 'lib/ibus-menu.vala'
--- lib/ibus-menu.vala	2014-02-20 03:59:24 +0000
+++ lib/ibus-menu.vala	2014-03-27 10:43:37 +0000
@@ -23,16 +23,16 @@
 	private IBus.PropList? properties;
 
 	private Menu menu;
-	private SimpleActionGroup? action_group;
+	private ActionMap? action_map;
 
 	private string? radio_name;
 	private SimpleAction? radio_action;
 	private Gee.HashMap<string, IBus.Property> radio_properties;
 
-	// A list of the action names this menu registers
+	/* A list of the action names this menu registers. */
 	private Gee.LinkedList<string> names;
 
-	public IBusMenu (SimpleActionGroup? action_group = null, IBus.PropList? properties = null) {
+	public IBusMenu (ActionMap? action_map = null, IBus.PropList? properties = null) {
 		menu = new Menu ();
 
 		menu.items_changed.connect ((position, removed, added) => {
@@ -40,7 +40,7 @@
 		});
 
 		names = new Gee.LinkedList<string> ();
-		set_action_group (action_group);
+		set_action_map (action_map);
 		set_properties (properties);
 	}
 
@@ -72,12 +72,12 @@
 			name = @"ibus-$key";
 		}
 
-		// Find an unused action name using a counter
-		if (action_group != null && (Action?) ((!) action_group).lookup_action (name) != null) {
+		/* Find an unused action name using a counter. */
+		if (action_map != null && (Action?) ((!) action_map).lookup_action (name) != null) {
 			var i = 0;
 			var unique_name = @"$name-$i";
 
-			while ((Action?) ((!) action_group).lookup_action (unique_name) != null) {
+			while ((Action?) ((!) action_map).lookup_action (unique_name) != null) {
 				i++;
 				unique_name = @"$name-$i";
 			}
@@ -107,10 +107,10 @@
 			if ((string?) property.key != null) {
 				var name = get_action_name (property.key);
 
-				if (action_group != null) {
+				if (action_map != null) {
 					var action = new SimpleAction (name, null);
 					action.activate.connect ((parameter) => { activate (property, property.state); });
-					((!) action_group).add_action (action);
+					((!) action_map).add_action (action);
 					names.add (name);
 				}
 
@@ -124,7 +124,7 @@
 			if ((string?) property.key != null) {
 				var name = get_action_name (property.key);
 
-				if (action_group != null) {
+				if (action_map != null) {
 					var state = new Variant.boolean (property.state == IBus.PropState.CHECKED);
 					var action = new SimpleAction.stateful (name, null, state);
 
@@ -139,7 +139,7 @@
 						}
 					});
 
-					((!) action_group).add_action (action);
+					((!) action_map).add_action (action);
 					names.add (name);
 				}
 
@@ -151,8 +151,8 @@
 	private void append_radio_property (IBus.Property property) {
 		if (property.prop_type == IBus.PropType.RADIO) {
 			if ((string?) property.key != null) {
-				// Create a single action for all radio properties.
-				if (action_group != null && radio_name == null) {
+				/* Create a single action for all radio properties. */
+				if (action_map != null && radio_name == null) {
 					radio_counter++;
 					radio_name = @"-private-radio-$radio_counter";
 					radio_action = new SimpleAction.stateful ((!) radio_name, VariantType.STRING, new Variant.string (""));
@@ -172,7 +172,7 @@
 						}
 					});
 
-					((!) action_group).add_action ((!) radio_action);
+					((!) action_map).add_action ((!) radio_action);
 					names.add ((!) radio_name);
 				}
 
@@ -195,7 +195,7 @@
 
 	private void append_menu_property (IBus.Property property) {
 		if (property.prop_type == IBus.PropType.MENU) {
-			var submenu = new IBusMenu (action_group, ((!) property).sub_props);
+			var submenu = new IBusMenu (action_map, ((!) property).sub_props);
 			submenu.activate.connect ((property, state) => { activate (property, state); });
 			menu.append_submenu (get_label (property), submenu);
 		}
@@ -227,8 +227,7 @@
 	}
 
 	private void update_menu () {
-		// There's a reference cycle between the action group and the submenus.
-		// We need to break it here so that those submenus aren't hanging around.
+		/* Break reference cycle between action map and submenus. */
 		for (var i = 0; i < menu.get_n_items (); i++) {
 			var submenu = menu.get_item_link (i, Menu.LINK_SUBMENU) as IBusMenu;
 
@@ -250,19 +249,19 @@
 		radio_action = null;
 		radio_name = null;
 
-		if (action_group != null) {
+		if (action_map != null) {
 			foreach (var name in names) {
-				((!) action_group).remove_action (name);
+				((!) action_map).remove_action (name);
 			}
 		}
 
 		names.clear ();
 	}
 
-	public void set_action_group (SimpleActionGroup? action_group) {
-		if (action_group != this.action_group) {
+	public void set_action_map (ActionMap? action_map) {
+		if (action_map != this.action_map) {
 			remove_actions ();
-			this.action_group = action_group;
+			this.action_map = action_map;
 			update_menu ();
 		}
 	}
@@ -282,7 +281,7 @@
 		update_menu ();
 	}
 
-	// Forward all menu model calls to our internal menu
+	/* Forward all menu model calls to our internal menu. */
 
 	public override Variant get_item_attribute_value (int item_index, string attribute, VariantType? expected_type) {
 		return menu.get_item_attribute_value (item_index, attribute, expected_type);

=== added file 'lib/ibus-panel.vala'
--- lib/ibus-panel.vala	1970-01-01 00:00:00 +0000
+++ lib/ibus-panel.vala	2014-03-27 10:43:37 +0000
@@ -0,0 +1,26 @@
+/*
+ * Copyright 2014 Canonical Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, version 3 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authors: William Hua <[e-mail]>
+ */
+
+[DBus (name="com.canonical.IBus.Panel.Private")]
+public interface IBusPanel : Object {
+
+	public abstract void activate_property (string name, uint state) throws IOError;
+
+	public signal void properties_registered (Variant variant);
+	public signal void property_updated (Variant variant);
+}

=== added file 'lib/indicator-menu.vala'
--- lib/indicator-menu.vala	1970-01-01 00:00:00 +0000
+++ lib/indicator-menu.vala	2014-03-27 10:43:37 +0000
@@ -0,0 +1,128 @@
+/*
+ * Copyright 2014 Canonical Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, version 3 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authors: William Hua <[e-mail]>
+ */
+
+public class Indicator.Keyboard.IndicatorMenu : MenuModel {
+
+	public enum Options {
+		NONE     = 0x0,
+		IBUS     = 0x1,
+		SETTINGS = 0x2
+	}
+
+	private Options options;
+
+	private Menu indicator_menu;
+	private Menu sources_section;
+	private IBusMenu properties_section;
+
+	public IndicatorMenu (ActionMap? action_map = null, Options options = Options.IBUS | Options.SETTINGS) {
+		var submenu = new Menu ();
+
+		sources_section = new Menu ();
+		submenu.append_section (null, sources_section);
+
+		if ((options & Options.IBUS) != Options.NONE) {
+			properties_section = new IBusMenu (action_map);
+			properties_section.activate.connect ((property, state) => { activate (property, state); });
+			submenu.append_section (null, properties_section);
+		}
+
+		if ((options & Options.SETTINGS) != Options.NONE) {
+			var settings_section = new Menu ();
+			settings_section.append (_ ("Character Map"), "indicator.map");
+			settings_section.append (_ ("Keyboard Layout Chart"), "indicator.chart");
+			settings_section.append (_ ("Text Entry Settings..."), "indicator.settings");
+			submenu.append_section (null, settings_section);
+		}
+
+		var indicator = new MenuItem.submenu (null, submenu);
+		indicator.set_attribute ("x-canonical-type", "s", "com.canonical.indicator.root");
+		indicator.set_attribute ("x-canonical-secondary-action", "s", "indicator.next");
+		indicator.set_attribute ("x-canonical-scroll-action", "s", "indicator.scroll");
+		indicator.set_detailed_action ("indicator.indicator");
+
+		indicator_menu = new Menu ();
+		indicator_menu.append_item (indicator);
+
+		this.options = options;
+	}
+
+	public signal void activate (IBus.Property property, IBus.PropState state);
+
+	public void set_sources (Source[] sources) {
+		sources_section.remove_all ();
+
+		for (var i = 0; i < sources.length; i++) {
+			if (!sources[i].is_ibus || (options & Options.IBUS) != Options.NONE) {
+				var item = new MenuItem (sources[i].name, "indicator.current");
+
+				item.set_attribute (Menu.ATTRIBUTE_TARGET, "u", i);
+
+				if (sources[i].icon != null) {
+					item.set_icon ((!) sources[i].icon);
+				}
+
+				sources_section.append_item (item);
+			}
+		}
+	}
+
+	public void set_properties (IBus.PropList properties) {
+		if ((options & Options.IBUS) != Options.NONE) {
+			properties_section.set_properties (properties);
+		}
+	}
+
+	public void update_property (IBus.Property property) {
+		if ((options & Options.IBUS) != Options.NONE) {
+			properties_section.update_property (property);
+		}
+	}
+
+	public override bool is_mutable () {
+		return indicator_menu.is_mutable ();
+	}
+
+	public override int get_n_items () {
+		return indicator_menu.get_n_items ();
+	}
+
+	public override void get_item_attributes (int item_index, out HashTable<string, Variant>? attributes) {
+		indicator_menu.get_item_attributes (item_index, out attributes);
+	}
+
+	public override void get_item_links (int item_index, out HashTable<string, MenuModel>? links) {
+		indicator_menu.get_item_links (item_index, out links);
+	}
+
+	public override Variant get_item_attribute_value (int item_index, string attribute, VariantType? expected_type) {
+		return indicator_menu.get_item_attribute_value (item_index, attribute, expected_type);
+	}
+
+	public override MenuModel get_item_link (int item_index, string link) {
+		return indicator_menu.get_item_link (item_index, link);
+	}
+
+	public override MenuAttributeIter iterate_item_attributes (int item_index) {
+		return indicator_menu.iterate_item_attributes (item_index);
+	}
+
+	public override MenuLinkIter iterate_item_links (int item_index) {
+		return indicator_menu.iterate_item_links (item_index);
+	}
+}

=== modified file 'lib/main.vala'
--- lib/main.vala	2014-02-27 19:37:55 +0000
+++ lib/main.vala	2014-03-27 10:43:37 +0000
@@ -37,16 +37,16 @@
 	private uint focused_window_id;
 
 	private IBus.Bus? ibus;
-	private IBus.PanelService? panel_service;
+	private IBusPanel? ibus_panel;
+	private ulong ibus_connected_id;
 	private uint panel_timeout;
 
 	private Source[]? sources;
 
 	private SimpleActionGroup? action_group;
 	private SimpleAction? indicator_action;
-	private MenuModel? menu_model;
-	private Menu? sources_menu;
-	private IBusMenu? ibus_menu;
+	private IndicatorMenu? desktop_menu;
+	private IndicatorMenu? desktop_greeter_menu;
 
 	private UnityGreeter? unity_greeter;
 	private string? greeter_user;
@@ -70,8 +70,12 @@
 						}
 					}
 
-					if (sources_menu != null) {
-						update_sources_menu ();
+					if (desktop_menu != null) {
+						get_desktop_menu ().set_sources (get_sources ());
+					}
+
+					if (desktop_greeter_menu != null) {
+						get_desktop_greeter_menu ().set_sources (get_sources ());
 					}
 
 					if (indicator_action != null) {
@@ -132,6 +136,43 @@
 	}
 
 	[DBus (visible = false)]
+	private IBusPanel? get_ibus_panel () {
+		if (ibus_panel == null && get_ibus ().is_connected ()) {
+			var connection = get_ibus ().get_connection ();
+			var name = "org.freedesktop.IBus.Panel";
+			var path = "/org/freedesktop/IBus/Panel";
+
+			try {
+				ibus_panel = connection.get_proxy_sync (name, path);
+
+				((!) ibus_panel).properties_registered.connect ((variant) => {
+					var properties = new IBus.PropList ();
+					properties.deserialize (variant);
+
+					if (properties is IBus.PropList) {
+						handle_properties_registered ((!) (properties as IBus.PropList));
+					}
+				});
+				((!) ibus_panel).property_updated.connect ((variant) => {
+					var type = IBus.PropType.NORMAL;
+					var state = IBus.PropState.INCONSISTENT;
+					var text = new IBus.Text.from_static_string ("");
+					var property = new IBus.Property ("", type, text, null, text, false, false, state, null);
+					property.deserialize (variant);
+
+					if (property is IBus.Property) {
+						handle_property_updated ((!) (property as IBus.Property));
+					}
+				});
+			} catch (IOError error) {
+				warning ("error: %s", error.message);
+			}
+		}
+
+		return ibus_panel;
+	}
+
+	[DBus (visible = false)]
 	public void up () {
 		if (loop == null) {
 			loop = new MainLoop ();
@@ -576,11 +617,12 @@
 					}
 				}
 
-				if (panel_service == null && sources[i].is_ibus) {
-					if (get_ibus ().request_name (IBus.SERVICE_PANEL, IBus.BusNameFlag.REPLACE_EXISTING) > 0) {
-						panel_service = new IBus.PanelService (get_ibus ().get_connection ());
-						((!) panel_service).register_properties.connect (handle_registered_properties);
-						((!) panel_service).update_property.connect (handle_updated_property);
+				if (ibus_connected_id == 0 && sources[i].is_ibus) {
+					ibus_connected_id = get_ibus ().connected.connect (() => { get_ibus_panel (); });
+					get_ibus ().disconnected.connect (() => { ibus_panel = null; });
+
+					if (get_ibus ().is_connected ()) {
+						get_ibus_panel ();
 					}
 				}
 			}
@@ -590,22 +632,22 @@
 	}
 
 	[DBus (visible = false)]
-	private void handle_registered_properties (IBus.PropList list) {
+	private void handle_properties_registered (IBus.PropList list) {
 		if (panel_timeout > 0) {
 			GLib.Source.remove (panel_timeout);
 			panel_timeout = 0;
 		}
 
 		panel_timeout = Timeout.add (PROPERTIES_DELAY, () => {
-			update_ibus_menu (list);
+			get_desktop_menu ().set_properties (list);
 			panel_timeout = 0;
 			return false;
 		});
 	}
 
 	[DBus (visible = false)]
-	private void handle_updated_property (IBus.Property property) {
-		get_ibus_menu ().update_property (property);
+	private void handle_property_updated (IBus.Property property) {
+		get_desktop_menu ().update_property (property);
 	}
 
 	[DBus (visible = false)]
@@ -705,91 +747,34 @@
 	}
 
 	[DBus (visible = false)]
-	private void update_sources_menu () {
-		if (sources_menu != null) {
-			var menu = get_sources_menu ();
-			menu.remove_all ();
-
-			var sources = get_sources ();
-			for (var i = 0; i < sources.length; i++) {
-				var item = new MenuItem (sources[i].name, "indicator.current");
-				item.set_attribute (Menu.ATTRIBUTE_TARGET, "u", i);
-
-				var icon = sources[i].icon;
-				if (icon != null) {
-					item.set_icon ((!) icon);
-				}
-
-				menu.append_item (item);
-			}
-		} else {
-			get_sources_menu ();
-		}
-	}
-
-	[DBus (visible = false)]
-	private Menu get_sources_menu () {
-		if (sources_menu == null) {
-			sources_menu = new Menu ();
-			update_sources_menu ();
-		}
-
-		return (!) sources_menu;
-	}
-
-	[DBus (visible = false)]
-	private void update_ibus_menu (IBus.PropList list) {
-		get_ibus_menu ().set_properties (list);
-	}
-
-	[DBus (visible = false)]
-	private IBusMenu get_ibus_menu () {
-		if (ibus_menu == null) {
-			ibus_menu = new IBusMenu (get_action_group ());
-			((!) ibus_menu).activate.connect ((property, state) => {
-				if (panel_service != null) {
-					((!) panel_service).property_activate (property.key, state);
+	public IndicatorMenu get_desktop_menu () {
+		if (desktop_menu == null) {
+			desktop_menu = new IndicatorMenu (get_action_group ());
+			((!) desktop_menu).set_sources (get_sources ());
+			((!) desktop_menu).activate.connect ((property, state) => {
+				var panel = get_ibus_panel ();
+
+				if (panel != null) {
+					try {
+						((!) panel).activate_property (property.key, state);
+					} catch (IOError error) {
+						warning ("error: %s", error.message);
+					}
 				}
 			});
 		}
 
-		return (!) ibus_menu;
-	}
-
-	[DBus (visible = false)]
-	protected virtual MenuModel create_menu_model (MenuModel sources_menu, MenuModel ibus_menu) {
-		var menu = new Menu ();
-
-		var submenu = new Menu ();
-
-		submenu.append_section (null, sources_menu);
-		submenu.append_section (null, ibus_menu);
-
-		if (!is_login_user ()) {
-			var section = new Menu ();
-			section.append (_ ("Character Map"), "indicator.map");
-			section.append (_ ("Keyboard Layout Chart"), "indicator.chart");
-			section.append (_ ("Text Entry Settings..."), "indicator.settings");
-			submenu.append_section (null, section);
-		}
-
-		var indicator = new MenuItem.submenu ("x", submenu);
-		indicator.set_attribute ("x-canonical-type", "s", "com.canonical.indicator.root");
-		indicator.set_attribute ("x-canonical-secondary-action", "s", "indicator.next");
-		indicator.set_attribute ("x-canonical-scroll-action", "s", "indicator.scroll");
-		indicator.set_detailed_action ("indicator.indicator");
-		menu.append_item (indicator);
-
-		return menu;
-	}
-
-	[DBus (visible = false)]
-	public MenuModel get_menu_model () {
-		if (menu_model == null) {
-			menu_model = create_menu_model (get_sources_menu (), get_ibus_menu ());
-		}
-
-		return (!) menu_model;
+		return (!) desktop_menu;
+	}
+
+	[DBus (visible = false)]
+	public IndicatorMenu get_desktop_greeter_menu () {
+		if (desktop_greeter_menu == null) {
+			desktop_greeter_menu = new IndicatorMenu (get_action_group (), IndicatorMenu.Options.NONE);
+			((!) desktop_greeter_menu).set_sources (get_sources ());
+		}
+
+		return (!) desktop_greeter_menu;
 	}
 
 	[DBus (visible = false)]
@@ -807,7 +792,8 @@
 	private void handle_changed_sources (string key) {
 		sources = null;
 
-		update_sources_menu ();
+		get_desktop_menu ().set_sources (get_sources ());
+		get_desktop_greeter_menu ().set_sources (get_sources ());
 		update_indicator_action ();
 		update_login_layout ();
 	}
@@ -897,7 +883,8 @@
 	private void handle_bus_acquired (DBusConnection connection, string name) {
 		try {
 			connection.export_action_group ("/com/canonical/indicator/keyboard", get_action_group ());
-			connection.export_menu_model ("/com/canonical/indicator/keyboard/desktop", get_menu_model ());
+			connection.export_menu_model ("/com/canonical/indicator/keyboard/desktop", get_desktop_menu ());
+			connection.export_menu_model ("/com/canonical/indicator/keyboard/desktop_greeter", get_desktop_greeter_menu ());
 		} catch (Error error) {
 			warning ("error: %s", error.message);
 		}

=== modified file 'po/POTFILES.in'
--- po/POTFILES.in	2013-09-27 15:10:19 +0000
+++ po/POTFILES.in	2014-03-27 10:43:37 +0000
@@ -1,2 +1,3 @@
 # List of source files which contain translatable strings.
 lib/main.vala
+lib/indicator-menu.vala

=== modified file 'po/POTFILES.skip'
--- po/POTFILES.skip	2013-09-27 15:10:19 +0000
+++ po/POTFILES.skip	2014-03-27 10:43:37 +0000
@@ -1,1 +1,2 @@
 lib/main.c
+lib/indicator-menu.c

=== modified file 'po/indicator-keyboard.pot'
--- po/indicator-keyboard.pot	2013-09-27 15:10:19 +0000
+++ po/indicator-keyboard.pot	2014-03-27 10:43:37 +0000
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2013-09-27 16:28+0200\n"
+"POT-Creation-Date: 2014-03-27 23:39+1300\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[e-mail]>\n"
@@ -17,19 +17,19 @@
 "Content-Type: text/plain; charset=CHARSET\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-#: ../lib/main.vala:427
+#: ../lib/main.vala:670
 #, c-format
 msgid "%s input source"
 msgstr ""
 
-#: ../lib/main.vala:525
+#: ../lib/indicator-menu.vala:47
 msgid "Character Map"
 msgstr ""
 
-#: ../lib/main.vala:526
+#: ../lib/indicator-menu.vala:48
 msgid "Keyboard Layout Chart"
 msgstr ""
 
-#: ../lib/main.vala:527
+#: ../lib/indicator-menu.vala:49
 msgid "Text Entry Settings..."
 msgstr ""