Merge lp:~attente/gtk/drop-git_padding_value into lp:~ubuntu-desktop/gtk/ubuntugtk3

Proposed by William Hua
Status: Merged
Merged at revision: 301
Proposed branch: lp:~attente/gtk/drop-git_padding_value
Merge into: lp:~ubuntu-desktop/gtk/ubuntugtk3
Diff against target: 45 lines (+0/-32)
2 files modified
debian/patches/git_padding_value.patch (+0/-31)
debian/patches/series (+0/-1)
To merge this branch: bzr merge lp:~attente/gtk/drop-git_padding_value
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Review via email: mp+191217@code.launchpad.net

Commit message

Drop debian/patches/git_padding_value.patch.

Description of the change

Drop debian/patches/git_padding_value.patch.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file 'debian/patches/git_padding_value.patch'
2--- debian/patches/git_padding_value.patch 2013-09-30 14:11:19 +0000
3+++ debian/patches/git_padding_value.patch 1970-01-01 00:00:00 +0000
4@@ -1,31 +0,0 @@
5-From 741432351902b5548b5c441cb8dcec635782dfed Mon Sep 17 00:00:00 2001
6-From: Ryan Lortie <desrt@desrt.ca>
7-Date: Thu, 26 Sep 2013 17:37:46 +0000
8-Subject: GtkTreeViewColumn: start padding at 0
9-
10-If we start with a padding of -1 then it can leak out of the size
11-allocation request for the column when the treeview is empty. The
12-GtkTreeView will then collect these -1 values and add them together,
13-returning -n where 'n' is the number of columns.
14-
15-This is usually not a problem because treeviews tend to be used with a
16-scrollbar and the width of the scrollbar will be added to this number
17-bringing it into positive territory again. On Ubuntu, with overlay
18-scrollbars, this is not the case, however.
19-
20-https://bugzilla.gnome.org/show_bug.cgi?id=703062
21----
22-diff --git a/gtk/gtktreeviewcolumn.c b/gtk/gtktreeviewcolumn.c
23-index ea16706..e1846d5 100644
24---- a/gtk/gtktreeviewcolumn.c
25-+++ b/gtk/gtktreeviewcolumn.c
26-@@ -464,7 +464,7 @@ gtk_tree_view_column_init (GtkTreeViewColumn *tree_column)
27- priv->button = NULL;
28- priv->xalign = 0.0;
29- priv->width = 0;
30-- priv->padding = -1;
31-+ priv->padding = 0;
32- priv->min_width = -1;
33- priv->max_width = -1;
34- priv->column_type = GTK_TREE_VIEW_COLUMN_GROW_ONLY;
35-
36
37=== modified file 'debian/patches/series'
38--- debian/patches/series 2013-10-11 13:26:10 +0000
39+++ debian/patches/series 2013-10-15 14:54:36 +0000
40@@ -22,5 +22,4 @@
41 abicheck-dynamic-backends
42 uimanager-guard-against-nested-node-updates.patch
43 git-gtkmodelmenuitem-icon-support.patch
44-git_padding_value.patch
45 git_list_handlers.patch

Subscribers

People subscribed via source and target branches

to all changes: