Merge lp:~attente/gnome-software/20160331 into lp:~ubuntu-desktop/gnome-software/ubuntu
- 20160331
- Merge into ubuntu
Proposed by
William Hua
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 3 | ||||||||
Proposed branch: | lp:~attente/gnome-software/20160331 | ||||||||
Merge into: | lp:~ubuntu-desktop/gnome-software/ubuntu | ||||||||
Diff against target: |
762 lines (+308/-112) 19 files modified
debian/changelog (+10/-0) debian/patches/appstream-refresh.patch (+2/-2) debian/patches/apt-plugin.patch (+12/-11) debian/patches/dedup-source.patch (+2/-2) debian/patches/disable-update-monitor.patch (+2/-2) debian/patches/fwupd-error.patch (+4/-4) debian/patches/hide-empty-fields.patch (+8/-8) debian/patches/minimal-review-limits.patch (+2/-2) debian/patches/no-daemon.patch (+44/-42) debian/patches/no-history.patch (+4/-4) debian/patches/no-kudo-details.patch (+4/-4) debian/patches/no-notification-actions.patch (+169/-0) debian/patches/no-offline-updates.patch (+2/-2) debian/patches/rename-menu-item.patch (+25/-0) debian/patches/series (+2/-0) debian/patches/software-properties.patch (+5/-19) debian/patches/ubuntu-review-submit.patch (+7/-6) debian/patches/update-descriptions.patch (+2/-2) debian/patches/window-decorations.patch (+2/-2) |
||||||||
To merge this branch: | bzr merge lp:~attente/gnome-software/20160331 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Ancell | Approve | ||
Review via email: mp+290674@code.launchpad.net |
Commit message
* New upstream snapshot
* debian/
- Rename 'Software Sources' menu item to 'Software & Updates'
* debian/
- Disable actions in notifications (LP: #1547608)
Description of the change
* New upstream snapshot
* debian/
- Rename 'Software Sources' menu item to 'Software & Updates'
* debian/
- Disable actions in notifications (LP: #1547608)
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'debian/changelog' |
2 | --- debian/changelog 2016-03-29 03:47:46 +0000 |
3 | +++ debian/changelog 2016-04-01 02:07:57 +0000 |
4 | @@ -1,3 +1,13 @@ |
5 | +gnome-software (3.20.1~git20160331.78d1aab-0ubuntu1) xenial; urgency=medium |
6 | + |
7 | + * New upstream snapshot |
8 | + * debian/patches/rename-menu-item.patch: |
9 | + - Rename 'Software Sources' menu item to 'Software & Updates' |
10 | + * debian/patches/no-notification-actions.patch: |
11 | + - Disable actions in notifications (LP: #1547608) |
12 | + |
13 | + -- William Hua <william.hua@canonical.com> Thu, 31 Mar 2016 21:20:12 -0400 |
14 | + |
15 | gnome-software (3.20.0-0ubuntu1) xenial; urgency=medium |
16 | |
17 | * New upstream stable release |
18 | |
19 | === modified file 'debian/patches/appstream-refresh.patch' |
20 | --- debian/patches/appstream-refresh.patch 2016-03-29 03:47:46 +0000 |
21 | +++ debian/patches/appstream-refresh.patch 2016-04-01 02:07:57 +0000 |
22 | @@ -1,7 +1,7 @@ |
23 | -From 0c85a65669e611c9c8fd269f380c6cc5f438aff0 Mon Sep 17 00:00:00 2001 |
24 | +From 0a70a60744336ec12ff0dcb61997b1e0ec4fdf64 Mon Sep 17 00:00:00 2001 |
25 | From: William Hua <william.hua@canonical.com> |
26 | Date: Wed, 16 Mar 2016 12:25:53 -0400 |
27 | -Subject: [PATCH 15/17] Refresh appstream index if needed |
28 | +Subject: [PATCH 15/18] Refresh appstream index if needed |
29 | |
30 | --- |
31 | src/plugins/gs-plugin-appstream.c | 71 +++++++++++++++++++++++++++++++++++++++ |
32 | |
33 | === modified file 'debian/patches/apt-plugin.patch' |
34 | --- debian/patches/apt-plugin.patch 2016-03-29 03:47:46 +0000 |
35 | +++ debian/patches/apt-plugin.patch 2016-04-01 02:07:57 +0000 |
36 | @@ -1,14 +1,14 @@ |
37 | -From 71bfaa1cc702705f52fe3e015c7eec588b20b2e6 Mon Sep 17 00:00:00 2001 |
38 | +From 789cd3a13775799a13ac77cd1409fc9ec93a7929 Mon Sep 17 00:00:00 2001 |
39 | From: Robert Ancell <robert.ancell@canonical.com> |
40 | -Date: Thu, 4 Feb 2016 14:51:21 +1300 |
41 | -Subject: [PATCH 09/17] Add an apt plugin that works with aptdaemon |
42 | +Date: Thu, 31 Mar 2016 19:56:26 -0400 |
43 | +Subject: [PATCH 09/18] Add an apt plugin that works with aptdaemon |
44 | |
45 | --- |
46 | src/gs-app.c | 9 + |
47 | src/plugins/Makefile.am | 19 + |
48 | src/plugins/com.canonical.Unity.Launcher.xml | 15 + |
49 | - src/plugins/gs-plugin-apt.c | 976 +++++++++++++++++++++++++++ |
50 | - 4 files changed, 1019 insertions(+) |
51 | + src/plugins/gs-plugin-apt.c | 977 +++++++++++++++++++++++++++ |
52 | + 4 files changed, 1020 insertions(+) |
53 | create mode 100644 src/plugins/com.canonical.Unity.Launcher.xml |
54 | create mode 100644 src/plugins/gs-plugin-apt.c |
55 | |
56 | @@ -33,7 +33,7 @@ |
57 | if (g_str_has_prefix (tokens[i], "@")) { |
58 | g_string_append_printf (urld, |
59 | diff --git a/src/plugins/Makefile.am b/src/plugins/Makefile.am |
60 | -index b8d16fb..4791b89 100644 |
61 | +index bc4dd98..db0c971 100644 |
62 | --- a/src/plugins/Makefile.am |
63 | +++ b/src/plugins/Makefile.am |
64 | @@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \ |
65 | @@ -44,7 +44,7 @@ |
66 | libgs_plugin_appstream.la \ |
67 | libgs_plugin_dummy.la \ |
68 | libgs_plugin_hardcoded-featured.la \ |
69 | -@@ -132,6 +133,24 @@ libgs_plugin_xdg_app_reviews_la_LDFLAGS = -module -avoid-version |
70 | +@@ -135,6 +136,24 @@ libgs_plugin_xdg_app_reviews_la_LDFLAGS = -module -avoid-version |
71 | libgs_plugin_xdg_app_reviews_la_CFLAGS = $(GS_PLUGIN_CFLAGS) $(WARN_CFLAGS) |
72 | endif |
73 | |
74 | @@ -71,7 +71,7 @@ |
75 | gs-moduleset.h \ |
76 | diff --git a/src/plugins/com.canonical.Unity.Launcher.xml b/src/plugins/com.canonical.Unity.Launcher.xml |
77 | new file mode 100644 |
78 | -index 0000000..b0d7915 |
79 | +index 0000000..b631a2d |
80 | --- /dev/null |
81 | +++ b/src/plugins/com.canonical.Unity.Launcher.xml |
82 | @@ -0,0 +1,15 @@ |
83 | @@ -83,7 +83,7 @@ |
84 | + <arg type='s' name='appstream_app_id' direction='in'/> |
85 | + <arg type='s' name='aptdaemon_task' direction='in'/> |
86 | + </method> |
87 | -+ |
88 | ++ |
89 | + <method name='UpdateLauncherIconFavoriteState'> |
90 | + <arg type='s' name='icon_uri' direction='in'/> |
91 | + <arg type='b' name='is_sticky' direction='in'/> |
92 | @@ -92,10 +92,10 @@ |
93 | +</node> |
94 | diff --git a/src/plugins/gs-plugin-apt.c b/src/plugins/gs-plugin-apt.c |
95 | new file mode 100644 |
96 | -index 0000000..d5c54f1 |
97 | +index 0000000..d9af67a |
98 | --- /dev/null |
99 | +++ b/src/plugins/gs-plugin-apt.c |
100 | -@@ -0,0 +1,976 @@ |
101 | +@@ -0,0 +1,977 @@ |
102 | +/* -*- Mode: C; tab-width: 8; indent-tabs-mode: t; c-basic-offset: 8 -*- |
103 | + * |
104 | + * Copyright (C) 2016 Canonical Ltd |
105 | @@ -1067,6 +1067,7 @@ |
106 | + gs_app_set_management_plugin (app, "dpkg"); |
107 | + gs_app_add_source (app, tokens[0]); |
108 | + gs_app_set_origin (app, path); |
109 | ++ gs_app_set_kind (app, AS_APP_KIND_GENERIC); |
110 | + |
111 | + gs_plugin_add_app (list, app); |
112 | + |
113 | |
114 | === modified file 'debian/patches/dedup-source.patch' |
115 | --- debian/patches/dedup-source.patch 2016-03-29 03:47:46 +0000 |
116 | +++ debian/patches/dedup-source.patch 2016-04-01 02:07:57 +0000 |
117 | @@ -1,7 +1,7 @@ |
118 | -From 0b15cf42a472bb0cba1980e63674b47ac8af000e Mon Sep 17 00:00:00 2001 |
119 | +From e2ff62a7b9d4f93acdffc03c0f0ad1e30c89e919 Mon Sep 17 00:00:00 2001 |
120 | From: Robert Ancell <robert.ancell@canonical.com> |
121 | Date: Wed, 17 Feb 2016 11:31:07 -0800 |
122 | -Subject: [PATCH 10/17] De-dup based on source |
123 | +Subject: [PATCH 10/18] De-dup based on source |
124 | |
125 | --- |
126 | src/gs-plugin.c | 13 ++++++++++--- |
127 | |
128 | === modified file 'debian/patches/disable-update-monitor.patch' |
129 | --- debian/patches/disable-update-monitor.patch 2016-03-29 03:47:46 +0000 |
130 | +++ debian/patches/disable-update-monitor.patch 2016-04-01 02:07:57 +0000 |
131 | @@ -1,7 +1,7 @@ |
132 | -From ab8336e889e136b97d5c1490ac52f98143921901 Mon Sep 17 00:00:00 2001 |
133 | +From 205e51b284dabc8ac68b0365918c77469cdd4eaf Mon Sep 17 00:00:00 2001 |
134 | From: William Hua <william.hua@canonical.com> |
135 | Date: Mon, 7 Mar 2016 09:13:07 -0500 |
136 | -Subject: [PATCH 04/17] Manually disable update monitor |
137 | +Subject: [PATCH 04/18] Manually disable update monitor |
138 | |
139 | Ubuntu already has update-manager for this. This is an Ubuntu-specific change |
140 | and should remain downstream. |
141 | |
142 | === modified file 'debian/patches/fwupd-error.patch' |
143 | --- debian/patches/fwupd-error.patch 2016-03-29 03:47:46 +0000 |
144 | +++ debian/patches/fwupd-error.patch 2016-04-01 02:07:57 +0000 |
145 | @@ -1,17 +1,17 @@ |
146 | -From 79b5ed39606c6032f19260cc6588a80d2f3e9344 Mon Sep 17 00:00:00 2001 |
147 | +From 07b280fafa4f92c9b5cec14701af8b3790e6b2c3 Mon Sep 17 00:00:00 2001 |
148 | From: William Hua <william.hua@canonical.com> |
149 | Date: Wed, 16 Mar 2016 15:03:42 -0400 |
150 | -Subject: [PATCH 14/17] Set error when org.freedesktop.fwupd has no service |
151 | +Subject: [PATCH 14/18] Set error when org.freedesktop.fwupd has no service |
152 | |
153 | --- |
154 | src/plugins/gs-plugin-fwupd.c | 5 ++++- |
155 | 1 file changed, 4 insertions(+), 1 deletion(-) |
156 | |
157 | diff --git a/src/plugins/gs-plugin-fwupd.c b/src/plugins/gs-plugin-fwupd.c |
158 | -index fa28c02..1d8e3d4 100644 |
159 | +index a2bfd9a..312dfcd 100644 |
160 | --- a/src/plugins/gs-plugin-fwupd.c |
161 | +++ b/src/plugins/gs-plugin-fwupd.c |
162 | -@@ -485,7 +485,10 @@ gs_plugin_add_updates (GsPlugin *plugin, |
163 | +@@ -496,7 +496,10 @@ gs_plugin_add_updates (GsPlugin *plugin, |
164 | G_DBUS_ERROR, |
165 | G_DBUS_ERROR_SERVICE_UNKNOWN)) { |
166 | /* the fwupd service might be unavailable, continue in that case */ |
167 | |
168 | === modified file 'debian/patches/hide-empty-fields.patch' |
169 | --- debian/patches/hide-empty-fields.patch 2016-03-29 03:47:46 +0000 |
170 | +++ debian/patches/hide-empty-fields.patch 2016-04-01 02:07:57 +0000 |
171 | @@ -1,7 +1,7 @@ |
172 | -From 74228765054a43b9264a9c140f6cb66bb9c97f5d Mon Sep 17 00:00:00 2001 |
173 | +From 922fe1c5766c4b6df3d2867255483227ed79e9b1 Mon Sep 17 00:00:00 2001 |
174 | From: Robert Ancell <robert.ancell@canonical.com> |
175 | Date: Tue, 29 Mar 2016 11:30:08 +1300 |
176 | -Subject: [PATCH 01/17] Hide licence, updated and category fields if they |
177 | +Subject: [PATCH 01/18] Hide licence, updated and category fields if they |
178 | aren't set |
179 | |
180 | --- |
181 | @@ -9,7 +9,7 @@ |
182 | 1 file changed, 19 insertions(+) |
183 | |
184 | diff --git a/src/gs-shell-details.c b/src/gs-shell-details.c |
185 | -index 9caa854..9540ab7 100644 |
186 | +index 1d59993..4b6ebf5 100644 |
187 | --- a/src/gs-shell-details.c |
188 | +++ b/src/gs-shell-details.c |
189 | @@ -77,13 +77,16 @@ struct _GsShellDetails |
190 | @@ -29,7 +29,7 @@ |
191 | GtkWidget *label_details_updated_value; |
192 | GtkWidget *label_details_version_value; |
193 | GtkWidget *label_failed; |
194 | -@@ -651,9 +654,13 @@ gs_shell_details_refresh_all (GsShellDetails *self) |
195 | +@@ -668,9 +671,13 @@ gs_shell_details_refresh_all (GsShellDetails *self) |
196 | /* TRANSLATORS: this is where the licence is not known */ |
197 | gtk_label_set_label (GTK_LABEL (self->label_details_licence_value), C_("license", "Unknown")); |
198 | gtk_widget_set_tooltip_text (self->label_details_licence_value, NULL); |
199 | @@ -43,7 +43,7 @@ |
200 | } |
201 | |
202 | /* set version */ |
203 | -@@ -683,13 +690,18 @@ gs_shell_details_refresh_all (GsShellDetails *self) |
204 | +@@ -700,13 +707,18 @@ gs_shell_details_refresh_all (GsShellDetails *self) |
205 | if (updated == GS_APP_INSTALL_DATE_UNKNOWN || |
206 | updated == GS_APP_INSTALL_DATE_UNSET) { |
207 | /* TRANSLATORS: this is where the updated date is not known */ |
208 | @@ -62,7 +62,7 @@ |
209 | } |
210 | |
211 | /* set the category */ |
212 | -@@ -698,6 +710,8 @@ gs_shell_details_refresh_all (GsShellDetails *self) |
213 | +@@ -715,6 +727,8 @@ gs_shell_details_refresh_all (GsShellDetails *self) |
214 | /* TRANSLATORS: this is the application isn't in any |
215 | * defined menu category */ |
216 | gtk_label_set_label (GTK_LABEL (self->label_details_category_value), C_("menu category", "None")); |
217 | @@ -71,7 +71,7 @@ |
218 | } else { |
219 | g_autofree gchar *path = NULL; |
220 | if (gtk_widget_get_direction (self->label_details_category_value) == GTK_TEXT_DIR_RTL) |
221 | -@@ -705,6 +719,8 @@ gs_shell_details_refresh_all (GsShellDetails *self) |
222 | +@@ -722,6 +736,8 @@ gs_shell_details_refresh_all (GsShellDetails *self) |
223 | else |
224 | path = g_strjoinv (" → ", menu_path); |
225 | gtk_label_set_label (GTK_LABEL (self->label_details_category_value), path); |
226 | @@ -80,7 +80,7 @@ |
227 | } |
228 | |
229 | /* set the origin */ |
230 | -@@ -1570,13 +1586,16 @@ gs_shell_details_class_init (GsShellDetailsClass *klass) |
231 | +@@ -1587,13 +1603,16 @@ gs_shell_details_class_init (GsShellDetailsClass *klass) |
232 | gtk_widget_class_bind_template_child (widget_class, GsShellDetails, infobar_details_package_baseos); |
233 | gtk_widget_class_bind_template_child (widget_class, GsShellDetails, infobar_details_repo); |
234 | gtk_widget_class_bind_template_child (widget_class, GsShellDetails, label_addons_uninstalled_app); |
235 | |
236 | === modified file 'debian/patches/minimal-review-limits.patch' |
237 | --- debian/patches/minimal-review-limits.patch 2016-03-29 03:47:46 +0000 |
238 | +++ debian/patches/minimal-review-limits.patch 2016-04-01 02:07:57 +0000 |
239 | @@ -1,7 +1,7 @@ |
240 | -From 74ab348a4ee2d03dfc857c99ce9ed7f98b82feb4 Mon Sep 17 00:00:00 2001 |
241 | +From 89bb91224aec3d29276971bc520638343de8a866 Mon Sep 17 00:00:00 2001 |
242 | From: Robert Ancell <robert.ancell@canonical.com> |
243 | Date: Thu, 11 Feb 2016 15:00:22 +1300 |
244 | -Subject: [PATCH 08/17] Use minimal limits for review content |
245 | +Subject: [PATCH 08/18] Use minimal limits for review content |
246 | |
247 | --- |
248 | src/gs-review-dialog.c | 10 +++++----- |
249 | |
250 | === modified file 'debian/patches/no-daemon.patch' |
251 | --- debian/patches/no-daemon.patch 2016-03-29 03:47:46 +0000 |
252 | +++ debian/patches/no-daemon.patch 2016-04-01 02:07:57 +0000 |
253 | @@ -1,63 +1,65 @@ |
254 | -From 728a8f2ca54406891a4c871878741fac5efdeaa8 Mon Sep 17 00:00:00 2001 |
255 | +From 1c71bec4b5ace082c3abdb04df0f964359f80ac5 Mon Sep 17 00:00:00 2001 |
256 | From: William Hua <william.hua@canonical.com> |
257 | -Date: Tue, 1 Mar 2016 17:30:47 -0500 |
258 | -Subject: [PATCH 12/17] Only quit if we're not running as a GApplication |
259 | - service |
260 | - |
261 | -We were destroying the window explicitly even when the application was |
262 | -running as a service, causing subsequent activations to crash since the |
263 | -window was already destroyed. |
264 | - |
265 | -See also |
266 | -https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1552150. |
267 | +Date: Thu, 24 Mar 2016 09:59:58 -0400 |
268 | +Subject: [PATCH 12/18] Terminate immediately on close |
269 | + |
270 | --- |
271 | - src/gs-shell.c | 19 +++++++++++++++++-- |
272 | - 1 file changed, 17 insertions(+), 2 deletions(-) |
273 | + src/gs-application.c | 1 - |
274 | + src/gs-shell.c | 22 ---------------------- |
275 | + 2 files changed, 23 deletions(-) |
276 | |
277 | +diff --git a/src/gs-application.c b/src/gs-application.c |
278 | +index fa24d56..97ff103 100644 |
279 | +--- a/src/gs-application.c |
280 | ++++ b/src/gs-application.c |
281 | +@@ -769,7 +769,6 @@ gs_application_new (void) |
282 | + return g_object_new (GS_APPLICATION_TYPE, |
283 | + "application-id", "org.gnome.Software", |
284 | + "flags", G_APPLICATION_HANDLES_OPEN, |
285 | +- "inactivity-timeout", 12000, |
286 | + NULL); |
287 | + } |
288 | + |
289 | diff --git a/src/gs-shell.c b/src/gs-shell.c |
290 | -index f0844d5..0169a95 100644 |
291 | +index f0844d5..46d7e8a 100644 |
292 | --- a/src/gs-shell.c |
293 | +++ b/src/gs-shell.c |
294 | -@@ -623,6 +623,13 @@ main_window_closed_cb (GtkWidget *dialog, GdkEvent *event, gpointer user_data) |
295 | - return TRUE; |
296 | +@@ -604,25 +604,6 @@ window_button_press_event (GtkWidget *win, GdkEventButton *event, GsShell *shell |
297 | + return GDK_EVENT_STOP; |
298 | } |
299 | |
300 | -+static void |
301 | -+main_window_destroyed_cb (GtkWidget *widget, |
302 | -+ GsShell *shell) |
303 | -+{ |
304 | -+ g_action_group_activate_action (G_ACTION_GROUP (g_application_get_default ()), "quit", NULL); |
305 | -+} |
306 | -+ |
307 | +-static gboolean |
308 | +-main_window_closed_cb (GtkWidget *dialog, GdkEvent *event, gpointer user_data) |
309 | +-{ |
310 | +- GsShell *shell = user_data; |
311 | +- GsShellPrivate *priv = gs_shell_get_instance_private (shell); |
312 | +- BackEntry *entry; |
313 | +- |
314 | +- /* When the window is closed, reset the initial mode to overview */ |
315 | +- priv->mode = GS_SHELL_MODE_OVERVIEW; |
316 | +- |
317 | +- /* ... and clear any remaining entries in the back button stack */ |
318 | +- while ((entry = g_queue_pop_head (priv->back_entry_stack)) != NULL) { |
319 | +- free_back_entry (entry); |
320 | +- } |
321 | +- |
322 | +- gtk_widget_hide (dialog); |
323 | +- return TRUE; |
324 | +-} |
325 | +- |
326 | /** |
327 | * gs_shell_updates_changed_cb: |
328 | */ |
329 | -@@ -698,6 +705,7 @@ void |
330 | - gs_shell_setup (GsShell *shell, GsPluginLoader *plugin_loader, GCancellable *cancellable) |
331 | - { |
332 | - GsShellPrivate *priv = gs_shell_get_instance_private (shell); |
333 | -+ GApplicationFlags flags; |
334 | - GtkWidget *widget; |
335 | - |
336 | - g_return_if_fail (GS_IS_SHELL (shell)); |
337 | -@@ -719,8 +727,15 @@ gs_shell_setup (GsShell *shell, GsPluginLoader *plugin_loader, GCancellable *can |
338 | +@@ -719,9 +700,6 @@ gs_shell_setup (GsShell *shell, GsPluginLoader *plugin_loader, GCancellable *can |
339 | gtk_icon_theme_append_search_path (gtk_icon_theme_get_default (), |
340 | GS_DATA G_DIR_SEPARATOR_S "icons"); |
341 | |
342 | - g_signal_connect (priv->main_window, "delete-event", |
343 | - G_CALLBACK (main_window_closed_cb), shell); |
344 | -+ flags = g_application_get_flags (g_application_get_default ()); |
345 | -+ |
346 | -+ if (flags & G_APPLICATION_IS_SERVICE) { |
347 | -+ g_signal_connect (priv->main_window, "delete-event", |
348 | -+ G_CALLBACK (main_window_closed_cb), shell); |
349 | -+ } else { |
350 | -+ g_signal_connect (priv->main_window, "destroy", |
351 | -+ G_CALLBACK (main_window_destroyed_cb), shell); |
352 | -+ } |
353 | - |
354 | +- |
355 | /* fix up the header bar */ |
356 | widget = GTK_WIDGET (gtk_builder_get_object (priv->builder, "header")); |
357 | + if (in_desktop ("Unity")) { |
358 | -- |
359 | 2.7.4 |
360 | |
361 | |
362 | === modified file 'debian/patches/no-history.patch' |
363 | --- debian/patches/no-history.patch 2016-03-29 03:47:46 +0000 |
364 | +++ debian/patches/no-history.patch 2016-04-01 02:07:57 +0000 |
365 | @@ -1,17 +1,17 @@ |
366 | -From a435a7b3cf74e844b6fa73c78849a6fe73c82c37 Mon Sep 17 00:00:00 2001 |
367 | +From c1b8c79da8dd54db11ffd5e2e4cdc09df9a031b9 Mon Sep 17 00:00:00 2001 |
368 | From: Robert Ancell <robert.ancell@canonical.com> |
369 | Date: Wed, 16 Mar 2016 16:06:23 +1300 |
370 | -Subject: [PATCH 06/17] Disable history button |
371 | +Subject: [PATCH 06/18] Disable history button |
372 | |
373 | --- |
374 | src/gs-shell-details.c | 3 ++- |
375 | 1 file changed, 2 insertions(+), 1 deletion(-) |
376 | |
377 | diff --git a/src/gs-shell-details.c b/src/gs-shell-details.c |
378 | -index 9540ab7..6754bf2 100644 |
379 | +index 4b6ebf5..68cd749 100644 |
380 | --- a/src/gs-shell-details.c |
381 | +++ b/src/gs-shell-details.c |
382 | -@@ -832,7 +832,8 @@ gs_shell_details_refresh_all (GsShellDetails *self) |
383 | +@@ -849,7 +849,8 @@ gs_shell_details_refresh_all (GsShellDetails *self) |
384 | break; |
385 | default: |
386 | gtk_widget_set_sensitive (self->button_history, history->len > 0); |
387 | |
388 | === modified file 'debian/patches/no-kudo-details.patch' |
389 | --- debian/patches/no-kudo-details.patch 2016-03-29 03:47:46 +0000 |
390 | +++ debian/patches/no-kudo-details.patch 2016-04-01 02:07:57 +0000 |
391 | @@ -1,7 +1,7 @@ |
392 | -From 9e2b5e0137fb687f69e0254b7d8927b5e62092a3 Mon Sep 17 00:00:00 2001 |
393 | +From 914aba0bf6c95442b0e437d52496ff7b1e3bb8ab Mon Sep 17 00:00:00 2001 |
394 | From: Robert Ancell <robert.ancell@canonical.com> |
395 | Date: Thu, 25 Feb 2016 12:40:53 +1300 |
396 | -Subject: [PATCH 11/17] Hide the Kudo details - they're not correctly populated |
397 | +Subject: [PATCH 11/18] Hide the Kudo details - they're not correctly populated |
398 | in Ubuntu and probably don't make sense |
399 | |
400 | --- |
401 | @@ -9,10 +9,10 @@ |
402 | 1 file changed, 3 insertions(+), 2 deletions(-) |
403 | |
404 | diff --git a/src/gs-shell-details.c b/src/gs-shell-details.c |
405 | -index 6754bf2..5decf09 100644 |
406 | +index 68cd749..efcb193 100644 |
407 | --- a/src/gs-shell-details.c |
408 | +++ b/src/gs-shell-details.c |
409 | -@@ -816,9 +816,10 @@ gs_shell_details_refresh_all (GsShellDetails *self) |
410 | +@@ -833,9 +833,10 @@ gs_shell_details_refresh_all (GsShellDetails *self) |
411 | |
412 | /* hide the kudo details for non-desktop software */ |
413 | switch (gs_app_get_kind (self->app)) { |
414 | |
415 | === added file 'debian/patches/no-notification-actions.patch' |
416 | --- debian/patches/no-notification-actions.patch 1970-01-01 00:00:00 +0000 |
417 | +++ debian/patches/no-notification-actions.patch 2016-04-01 02:07:57 +0000 |
418 | @@ -0,0 +1,169 @@ |
419 | +From 01a888ef20ccb7d962a244710f6c7ea9c903a443 Mon Sep 17 00:00:00 2001 |
420 | +From: William Hua <william.hua@canonical.com> |
421 | +Date: Wed, 23 Mar 2016 10:27:19 -0400 |
422 | +Subject: [PATCH 17/18] Don't use notification actions under Unity |
423 | + |
424 | +--- |
425 | + src/gs-dbus-helper.c | 14 +++++++++++--- |
426 | + src/gs-update-monitor.c | 37 ++++++++++++++++++++++++++----------- |
427 | + src/gs-utils.c | 22 +++++++++++++++------- |
428 | + 3 files changed, 52 insertions(+), 21 deletions(-) |
429 | + |
430 | +diff --git a/src/gs-dbus-helper.c b/src/gs-dbus-helper.c |
431 | +index e657f2a..b75e950 100644 |
432 | +--- a/src/gs-dbus-helper.c |
433 | ++++ b/src/gs-dbus-helper.c |
434 | +@@ -284,6 +284,12 @@ is_show_confirm_search_set (const gchar *interaction) |
435 | + return ret; |
436 | + } |
437 | + |
438 | ++static gboolean |
439 | ++is_unity (void) |
440 | ++{ |
441 | ++ return g_strcmp0 (g_getenv ("XDG_CURRENT_DESKTOP"), "Unity") == 0; |
442 | ++} |
443 | ++ |
444 | + static void |
445 | + notify_search_resources (GsShellExtrasMode mode, |
446 | + const gchar *desktop_id, |
447 | +@@ -344,9 +350,11 @@ notify_search_resources (GsShellExtrasMode mode, |
448 | + |
449 | + n = g_notification_new (title); |
450 | + g_notification_set_body (n, body); |
451 | +- /* TRANSLATORS: this is a button that launches gnome-software */ |
452 | +- g_notification_add_button_with_target (n, _("Find in Software"), "app.install-resources", "(s^ass)", mode_string, resources, ""); |
453 | +- g_notification_set_default_action_and_target (n, "app.install-resources", "(s^ass)", mode_string, resources, ""); |
454 | ++ if (!is_unity ()) { |
455 | ++ /* TRANSLATORS: this is a button that launches gnome-software */ |
456 | ++ g_notification_add_button_with_target (n, _("Find in Software"), "app.install-resources", "(s^ass)", mode_string, resources, ""); |
457 | ++ g_notification_set_default_action_and_target (n, "app.install-resources", "(s^ass)", mode_string, resources, ""); |
458 | ++ } |
459 | + g_application_send_notification (g_application_get_default (), "install-resources", n); |
460 | + } |
461 | + |
462 | +diff --git a/src/gs-update-monitor.c b/src/gs-update-monitor.c |
463 | +index a37c13c..cd472a5 100644 |
464 | +--- a/src/gs-update-monitor.c |
465 | ++++ b/src/gs-update-monitor.c |
466 | +@@ -57,6 +57,12 @@ reenable_offline_update_notification (gpointer data) |
467 | + return G_SOURCE_REMOVE; |
468 | + } |
469 | + |
470 | ++static gboolean |
471 | ++is_unity (void) |
472 | ++{ |
473 | ++ return g_strcmp0 (g_getenv ("XDG_CURRENT_DESKTOP"), "Unity") == 0; |
474 | ++} |
475 | ++ |
476 | + static void |
477 | + notify_offline_update_available (GsUpdateMonitor *monitor) |
478 | + { |
479 | +@@ -90,17 +96,21 @@ notify_offline_update_available (GsUpdateMonitor *monitor) |
480 | + body = _("It is recommended that you install important updates now"); |
481 | + n = g_notification_new (title); |
482 | + g_notification_set_body (n, body); |
483 | +- g_notification_add_button (n, _("Restart & Install"), "app.reboot-and-install"); |
484 | +- g_notification_set_default_action_and_target (n, "app.set-mode", "s", "updates"); |
485 | ++ if (!is_unity ()) { |
486 | ++ g_notification_add_button (n, _("Restart & Install"), "app.reboot-and-install"); |
487 | ++ g_notification_set_default_action_and_target (n, "app.set-mode", "s", "updates"); |
488 | ++ } |
489 | + g_application_send_notification (monitor->application, "updates-available", n); |
490 | + } else { |
491 | + title = _("Software Updates Available"); |
492 | + body = _("Important OS and application updates are ready to be installed"); |
493 | + n = g_notification_new (title); |
494 | + g_notification_set_body (n, body); |
495 | +- g_notification_add_button (n, _("Not Now"), "app.nop"); |
496 | +- g_notification_add_button_with_target (n, _("View"), "app.set-mode", "s", "updates"); |
497 | +- g_notification_set_default_action_and_target (n, "app.set-mode", "s", "updates"); |
498 | ++ if (!is_unity ()) { |
499 | ++ g_notification_add_button (n, _("Not Now"), "app.nop"); |
500 | ++ g_notification_add_button_with_target (n, _("View"), "app.set-mode", "s", "updates"); |
501 | ++ g_notification_set_default_action_and_target (n, "app.set-mode", "s", "updates"); |
502 | ++ } |
503 | + g_application_send_notification (monitor->application, "updates-available", n); |
504 | + } |
505 | + } |
506 | +@@ -233,7 +243,8 @@ get_upgrades_finished_cb (GObject *object, |
507 | + /* TRANSLATORS: this is a distro upgrade */ |
508 | + n = g_notification_new (_("Software Upgrade Available")); |
509 | + g_notification_set_body (n, body); |
510 | +- g_notification_set_default_action_and_target (n, "app.set-mode", "s", "updates"); |
511 | ++ if (!is_unity ()) |
512 | ++ g_notification_set_default_action_and_target (n, "app.set-mode", "s", "updates"); |
513 | + g_application_send_notification (monitor->application, "upgrades-available", n); |
514 | + } |
515 | + |
516 | +@@ -429,9 +440,11 @@ get_updates_historical_cb (GObject *object, GAsyncResult *res, gpointer data) |
517 | + /* TRANSLATORS: message when we offline updates have failed */ |
518 | + g_notification_set_body (notification, _("An important OS update failed to be installed.")); |
519 | + g_application_send_notification (monitor->application, "offline-updates", notification); |
520 | +- g_notification_add_button (notification, _("Show Details"), "app.show-offline-update-error"); |
521 | +- g_notification_set_default_action (notification, "app.show-offline-update-error"); |
522 | +- g_application_send_notification (monitor->application, "offline-updates", notification); |
523 | ++ if (!is_unity ()) { |
524 | ++ g_notification_add_button (notification, _("Show Details"), "app.show-offline-update-error"); |
525 | ++ g_notification_set_default_action (notification, "app.show-offline-update-error"); |
526 | ++ g_application_send_notification (monitor->application, "offline-updates", notification); |
527 | ++ } |
528 | + } |
529 | + return; |
530 | + } |
531 | +@@ -459,8 +472,10 @@ get_updates_historical_cb (GObject *object, GAsyncResult *res, gpointer data) |
532 | + * users can't express their opinions here. In some languages |
533 | + * "Review (evaluate) something" is a different translation than |
534 | + * "Review (browse) something." */ |
535 | +- g_notification_add_button_with_target (notification, C_("updates", "Review"), "app.set-mode", "s", "updated"); |
536 | +- g_notification_set_default_action_and_target (notification, "app.set-mode", "s", "updated"); |
537 | ++ if (!is_unity ()) { |
538 | ++ g_notification_add_button_with_target (notification, C_("updates", "Review"), "app.set-mode", "s", "updated"); |
539 | ++ g_notification_set_default_action_and_target (notification, "app.set-mode", "s", "updated"); |
540 | ++ } |
541 | + g_application_send_notification (monitor->application, "offline-updates", notification); |
542 | + |
543 | + /* update the timestamp so we don't show again */ |
544 | +diff --git a/src/gs-utils.c b/src/gs-utils.c |
545 | +index fbdb1a6..399f903 100644 |
546 | +--- a/src/gs-utils.c |
547 | ++++ b/src/gs-utils.c |
548 | +@@ -129,6 +129,12 @@ gs_grab_focus_when_mapped (GtkWidget *widget) |
549 | + G_CALLBACK (grab_focus), NULL); |
550 | + } |
551 | + |
552 | ++static gboolean |
553 | ++is_unity (void) |
554 | ++{ |
555 | ++ return g_strcmp0 (g_getenv ("XDG_CURRENT_DESKTOP"), "Unity") == 0; |
556 | ++} |
557 | ++ |
558 | + void |
559 | + gs_app_notify_installed (GsApp *app) |
560 | + { |
561 | +@@ -139,14 +145,16 @@ gs_app_notify_installed (GsApp *app) |
562 | + * has been successfully installed */ |
563 | + summary = g_strdup_printf (_("%s is now installed"), gs_app_get_name (app)); |
564 | + n = g_notification_new (summary); |
565 | +- if (gs_app_get_kind (app) == AS_APP_KIND_DESKTOP) { |
566 | +- /* TRANSLATORS: this is button that opens the newly installed application */ |
567 | +- g_notification_add_button_with_target (n, _("Launch"), |
568 | +- "app.launch", "s", |
569 | +- gs_app_get_id (app)); |
570 | ++ if (!is_unity ()) { |
571 | ++ if (gs_app_get_kind (app) == AS_APP_KIND_DESKTOP) { |
572 | ++ /* TRANSLATORS: this is button that opens the newly installed application */ |
573 | ++ g_notification_add_button_with_target (n, _("Launch"), |
574 | ++ "app.launch", "s", |
575 | ++ gs_app_get_id (app)); |
576 | ++ } |
577 | ++ g_notification_set_default_action_and_target (n, "app.details", "(ss)", |
578 | ++ gs_app_get_id (app), ""); |
579 | + } |
580 | +- g_notification_set_default_action_and_target (n, "app.details", "(ss)", |
581 | +- gs_app_get_id (app), ""); |
582 | + g_application_send_notification (g_application_get_default (), "installed", n); |
583 | + } |
584 | + |
585 | +-- |
586 | +2.7.4 |
587 | + |
588 | |
589 | === modified file 'debian/patches/no-offline-updates.patch' |
590 | --- debian/patches/no-offline-updates.patch 2016-03-29 03:47:46 +0000 |
591 | +++ debian/patches/no-offline-updates.patch 2016-04-01 02:07:57 +0000 |
592 | @@ -1,7 +1,7 @@ |
593 | -From 399b5b1bf8c4ae345e88d96b1147076d94e630d9 Mon Sep 17 00:00:00 2001 |
594 | +From 705442859e27dd7eae0625102f73c4cf855428e2 Mon Sep 17 00:00:00 2001 |
595 | From: Robert Ancell <robert.ancell@canonical.com> |
596 | Date: Wed, 16 Mar 2016 15:09:41 +1300 |
597 | -Subject: [PATCH 03/17] Disable offline updates, they don't work in Ubuntu |
598 | +Subject: [PATCH 03/18] Disable offline updates, they don't work in Ubuntu |
599 | |
600 | --- |
601 | src/gs-shell-updates.c | 6 ++++-- |
602 | |
603 | === added file 'debian/patches/rename-menu-item.patch' |
604 | --- debian/patches/rename-menu-item.patch 1970-01-01 00:00:00 +0000 |
605 | +++ debian/patches/rename-menu-item.patch 2016-04-01 02:07:57 +0000 |
606 | @@ -0,0 +1,25 @@ |
607 | +From 45f7efb3e289e46ea952792cc0085624da736f9c Mon Sep 17 00:00:00 2001 |
608 | +From: William Hua <william.hua@canonical.com> |
609 | +Date: Mon, 14 Mar 2016 10:56:42 -0400 |
610 | +Subject: [PATCH 16/18] 'Software Sources' -> 'Software & Updates' in menu |
611 | + |
612 | +--- |
613 | + src/menus.ui | 2 +- |
614 | + 1 file changed, 1 insertion(+), 1 deletion(-) |
615 | + |
616 | +diff --git a/src/menus.ui b/src/menus.ui |
617 | +index b138ba5..1dc4c18 100644 |
618 | +--- a/src/menus.ui |
619 | ++++ b/src/menus.ui |
620 | +@@ -4,7 +4,7 @@ |
621 | + <menu id="app-menu"> |
622 | + <section> |
623 | + <item> |
624 | +- <attribute name="label" translatable="yes">_Software Sources</attribute> |
625 | ++ <attribute name="label" translatable="yes">_Software & Updates</attribute> |
626 | + <attribute name="action">app.sources</attribute> |
627 | + </item> |
628 | + </section> |
629 | +-- |
630 | +2.7.4 |
631 | + |
632 | |
633 | === modified file 'debian/patches/series' |
634 | --- debian/patches/series 2016-03-29 03:47:46 +0000 |
635 | +++ debian/patches/series 2016-04-01 02:07:57 +0000 |
636 | @@ -13,3 +13,5 @@ |
637 | software-properties.patch |
638 | fwupd-error.patch |
639 | appstream-refresh.patch |
640 | +rename-menu-item.patch |
641 | +no-notification-actions.patch |
642 | |
643 | === modified file 'debian/patches/software-properties.patch' |
644 | --- debian/patches/software-properties.patch 2016-03-29 03:47:46 +0000 |
645 | +++ debian/patches/software-properties.patch 2016-04-01 02:07:57 +0000 |
646 | @@ -1,20 +1,19 @@ |
647 | -From 56aee4f46da074a2116273a4b6817eb865bfc142 Mon Sep 17 00:00:00 2001 |
648 | +From 84e37e449259aa263d33a47ebb8d51c0c09c80b1 Mon Sep 17 00:00:00 2001 |
649 | From: William Hua <william.hua@canonical.com> |
650 | Date: Tue, 1 Mar 2016 13:46:56 -0500 |
651 | -Subject: [PATCH 13/17] Launch software-properties-gtk in place of the sources |
652 | +Subject: [PATCH 13/18] Launch software-properties-gtk in place of the sources |
653 | dialog |
654 | |
655 | https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1551702 |
656 | --- |
657 | src/gs-shell.c | 3 +++ |
658 | - src/menus.ui | 2 +- |
659 | - 2 files changed, 4 insertions(+), 1 deletion(-) |
660 | + 1 file changed, 3 insertions(+) |
661 | |
662 | diff --git a/src/gs-shell.c b/src/gs-shell.c |
663 | -index 0169a95..244b89b 100644 |
664 | +index 46d7e8a..66bbe38 100644 |
665 | --- a/src/gs-shell.c |
666 | +++ b/src/gs-shell.c |
667 | -@@ -899,6 +899,9 @@ gs_shell_show_sources (GsShell *shell) |
668 | +@@ -862,6 +862,9 @@ gs_shell_show_sources (GsShell *shell) |
669 | GsShellPrivate *priv = gs_shell_get_instance_private (shell); |
670 | GtkWidget *dialog; |
671 | |
672 | @@ -24,19 +23,6 @@ |
673 | dialog = gs_sources_dialog_new (priv->main_window, priv->plugin_loader); |
674 | gs_shell_modal_dialog_present (shell, GTK_DIALOG (dialog)); |
675 | } |
676 | -diff --git a/src/menus.ui b/src/menus.ui |
677 | -index b138ba5..1dc4c18 100644 |
678 | ---- a/src/menus.ui |
679 | -+++ b/src/menus.ui |
680 | -@@ -4,7 +4,7 @@ |
681 | - <menu id="app-menu"> |
682 | - <section> |
683 | - <item> |
684 | -- <attribute name="label" translatable="yes">_Software Sources</attribute> |
685 | -+ <attribute name="label" translatable="yes">_Software & Updates</attribute> |
686 | - <attribute name="action">app.sources</attribute> |
687 | - </item> |
688 | - </section> |
689 | -- |
690 | 2.7.4 |
691 | |
692 | |
693 | === modified file 'debian/patches/ubuntu-review-submit.patch' |
694 | --- debian/patches/ubuntu-review-submit.patch 2016-03-29 03:47:46 +0000 |
695 | +++ debian/patches/ubuntu-review-submit.patch 2016-04-01 02:07:57 +0000 |
696 | @@ -1,7 +1,8 @@ |
697 | -From 3dff001e45bfa4af3e98390ff3af808af8c3a0ec Mon Sep 17 00:00:00 2001 |
698 | +From 1f8e790853347fc22a86e4893d8d58e0caf1299d Mon Sep 17 00:00:00 2001 |
699 | From: Robert Ancell <robert.ancell@canonical.com> |
700 | -Date: Fri, 19 Feb 2016 11:22:37 -0800 |
701 | -Subject: [PATCH 07/17] Add support for submiting reviews to reviews.ubuntu.com |
702 | +Date: Thu, 31 Mar 2016 19:55:07 -0400 |
703 | +Subject: [PATCH 07/18] Add support for submitting reviews to |
704 | + reviews.ubuntu.com |
705 | |
706 | Authentication work done by William Hua |
707 | --- |
708 | @@ -21,7 +22,7 @@ |
709 | create mode 100644 src/plugins/gs-ubuntu-login-dialog.ui |
710 | |
711 | diff --git a/configure.ac b/configure.ac |
712 | -index 0f00591..cb9a3b9 100644 |
713 | +index 6c86c62..27d5566 100644 |
714 | --- a/configure.ac |
715 | +++ b/configure.ac |
716 | @@ -68,6 +68,8 @@ PKG_CHECK_MODULES(SQLITE, sqlite3) |
717 | @@ -86,7 +87,7 @@ |
718 | G_END_DECLS |
719 | |
720 | diff --git a/src/plugins/Makefile.am b/src/plugins/Makefile.am |
721 | -index 07546c4..b8d16fb 100644 |
722 | +index 5ea32be..bc4dd98 100644 |
723 | --- a/src/plugins/Makefile.am |
724 | +++ b/src/plugins/Makefile.am |
725 | @@ -13,6 +13,8 @@ AM_CPPFLAGS = \ |
726 | @@ -98,7 +99,7 @@ |
727 | -DBINDIR=\"$(bindir)\" \ |
728 | -DDATADIR=\"$(datadir)\" \ |
729 | -DGS_MODULESETDIR=\"$(datadir)/gnome-software/modulesets.d\" \ |
730 | -@@ -165,8 +167,15 @@ libgs_plugin_hardcoded_blacklist_la_LDFLAGS = -module -avoid-version |
731 | +@@ -168,8 +170,15 @@ libgs_plugin_hardcoded_blacklist_la_LDFLAGS = -module -avoid-version |
732 | libgs_plugin_hardcoded_blacklist_la_CFLAGS = $(GS_PLUGIN_CFLAGS) $(WARN_CFLAGS) |
733 | |
734 | libgs_plugin_ubuntu_reviews_la_SOURCES = \ |
735 | |
736 | === modified file 'debian/patches/update-descriptions.patch' |
737 | --- debian/patches/update-descriptions.patch 2016-03-29 03:47:46 +0000 |
738 | +++ debian/patches/update-descriptions.patch 2016-04-01 02:07:57 +0000 |
739 | @@ -1,7 +1,7 @@ |
740 | -From 83b465f747a55a8055fe4a3e89ce4b66c3392315 Mon Sep 17 00:00:00 2001 |
741 | +From 6a50d4676fe50d8116e744fa212194cc03e6a622 Mon Sep 17 00:00:00 2001 |
742 | From: Robert Ancell <robert.ancell@canonical.com> |
743 | Date: Tue, 15 Mar 2016 14:12:13 +1300 |
744 | -Subject: [PATCH 05/17] Format update descriptions to be suitable for Ubuntu. |
745 | +Subject: [PATCH 05/18] Format update descriptions to be suitable for Ubuntu. |
746 | |
747 | Don't show the update descriptions on the updates page - it's too complex to fit. |
748 | Don't try and use markup - it doesn't work well with the information sourced from debian/changelog. |
749 | |
750 | === modified file 'debian/patches/window-decorations.patch' |
751 | --- debian/patches/window-decorations.patch 2016-03-29 03:47:46 +0000 |
752 | +++ debian/patches/window-decorations.patch 2016-04-01 02:07:57 +0000 |
753 | @@ -1,7 +1,7 @@ |
754 | -From 5bbb53e15237746f0129d3dffc930bde66483817 Mon Sep 17 00:00:00 2001 |
755 | +From 3ad704bda0701aa1df5cbc8ab309193ce26d3ec5 Mon Sep 17 00:00:00 2001 |
756 | From: Robert Ancell <robert.ancell@canonical.com> |
757 | Date: Thu, 3 Mar 2016 15:13:50 +1300 |
758 | -Subject: [PATCH 02/17] Use traditional window decorations in Unity |
759 | +Subject: [PATCH 02/18] Use traditional window decorations in Unity |
760 | |
761 | --- |
762 | src/gs-shell.c | 29 +++++++++++++++++++++++++---- |
LGTM