Merge lp:~attente/gnome-settings-daemon/input-sources-type-mismatch into lp:~ubuntu-desktop/gnome-settings-daemon/ubuntu

Proposed by William Hua
Status: Merged
Merged at revision: 422
Proposed branch: lp:~attente/gnome-settings-daemon/input-sources-type-mismatch
Merge into: lp:~ubuntu-desktop/gnome-settings-daemon/ubuntu
Diff against target: 87 lines (+30/-10)
2 files modified
debian/changelog (+7/-0)
debian/patches/53_sync_input_sources_to_accountsservice.patch (+23/-10)
To merge this branch: bzr merge lp:~attente/gnome-settings-daemon/input-sources-type-mismatch
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Review via email: mp+184721@code.launchpad.net

Commit message

Fix input sources type mismatch between g-s-d and accountsservice.

Description of the change

The type for user's input sources changed at some point, I neglected to make the corresponding change in g-s-d.

Fix input sources type mismatch between g-s-d and accountsservice.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-09-09 23:53:01 +0000
3+++ debian/changelog 2013-09-10 05:13:59 +0000
4@@ -1,3 +1,10 @@
5+gnome-settings-daemon (3.8.5-0ubuntu3) UNRELEASED; urgency=low
6+
7+ * debian/patches/53_sync_input_sources_to_accountsservice.patch:
8+ - Fix type mismatch between g-s-d and accountsservice.
9+
10+ -- William Hua <william.hua@canonical.com> Tue, 10 Sep 2013 01:02:02 -0400
11+
12 gnome-settings-daemon (3.8.5-0ubuntu2) saucy; urgency=low
13
14 * debian/patches/ubuntu-lid-close-suspend.patch:
15
16=== modified file 'debian/patches/53_sync_input_sources_to_accountsservice.patch'
17--- debian/patches/53_sync_input_sources_to_accountsservice.patch 2013-09-01 15:22:24 +0000
18+++ debian/patches/53_sync_input_sources_to_accountsservice.patch 2013-09-10 05:13:59 +0000
19@@ -1,7 +1,5 @@
20-Index: gnome-settings-daemon-3.8.4/plugins/keyboard/gsd-keyboard-manager.c
21-===================================================================
22---- gnome-settings-daemon-3.8.4.orig/plugins/keyboard/gsd-keyboard-manager.c 2013-09-01 11:09:39.478632306 -0400
23-+++ gnome-settings-daemon-3.8.4/plugins/keyboard/gsd-keyboard-manager.c 2013-09-01 11:09:56.110631611 -0400
24+--- a/plugins/keyboard/gsd-keyboard-manager.c
25++++ b/plugins/keyboard/gsd-keyboard-manager.c
26 @@ -50,6 +50,8 @@
27 #include <ibus.h>
28 #endif
29@@ -11,7 +9,7 @@
30 #include "gnome-settings-session.h"
31 #include "gnome-settings-profile.h"
32 #include "gsd-keyboard-manager.h"
33-@@ -969,6 +971,50 @@
34+@@ -969,6 +971,67 @@
35 g_free (rules_file_path);
36 }
37
38@@ -25,10 +23,27 @@
39 +
40 + if (act_user_is_loaded (user)) {
41 + GVariant *sources;
42++ GVariantIter iter;
43++ const gchar *type;
44++ const gchar *name;
45++ GVariantBuilder builder;
46 +
47 + g_signal_handlers_disconnect_by_data (user, user_data);
48 +
49 + sources = g_settings_get_value (settings, KEY_INPUT_SOURCES);
50++
51++ g_variant_builder_init (&builder, G_VARIANT_TYPE ("aa{ss}"));
52++
53++ g_variant_iter_init (&iter, sources);
54++ while (g_variant_iter_next (&iter, "(&s&s)", &type, &name)) {
55++ g_variant_builder_open (&builder, G_VARIANT_TYPE ("a{ss}"));
56++ g_variant_builder_add (&builder, "{ss}", type, name);
57++ g_variant_builder_close (&builder);
58++ }
59++
60++ g_variant_unref (sources);
61++
62++ sources = g_variant_ref_sink (g_variant_builder_end (&builder));
63 + act_user_set_input_sources (user, sources);
64 + g_variant_unref (sources);
65 + }
66@@ -62,7 +77,7 @@
67 static gboolean
68 apply_input_sources_settings (GSettings *settings,
69 gpointer keys,
70-@@ -984,11 +1030,20 @@
71+@@ -984,11 +1047,20 @@
72 gchar *layout = NULL;
73 gchar *variant = NULL;
74 gchar **options = NULL;
75@@ -83,10 +98,8 @@
76 if (n_sources < 1)
77 goto exit;
78
79-Index: gnome-settings-daemon-3.8.4/configure.ac
80-===================================================================
81---- gnome-settings-daemon-3.8.4.orig/configure.ac 2013-09-01 11:09:39.478632306 -0400
82-+++ gnome-settings-daemon-3.8.4/configure.ac 2013-09-01 11:09:39.466632307 -0400
83+--- a/configure.ac
84++++ b/configure.ac
85 @@ -195,7 +195,7 @@
86 fi
87 AM_CONDITIONAL(HAVE_IBUS, test "x$enable_ibus" == "xyes")

Subscribers

People subscribed via source and target branches

to all changes: