Merge lp:~attente/content-hub/1655105 into lp:content-hub

[William Hua]

Prevent crash when creating a paste with a bogus app id

Prevent crash when creating a paste with a bogus app id

[Ken VanDine (ken-vandine)]

Great, thanks!

review: Approve

=== modified file 'src/com/ubuntu/content/utils.cpp'
--- src/com/ubuntu/content/utils.cpp	2016-11-07 14:59:44 +0000
+++ src/com/ubuntu/content/utils.cpp	2017-01-09 18:15:55 +0000
@@ -212,12 +212,16 @@
     auto app_id = ual::AppID::find(id.toStdString());
     if (app_id.empty())
         return false;
-    auto app = ual::Application::create(app_id, reg);
-    if (!app.get()->hasInstances())
-        return false;
-    Q_FOREACH (std::shared_ptr<ual::Application::Instance> instance, app.get()->instances()) {
-        if (instance.get()->hasPid(pid))
-            return true;
+    try {
+        auto app = ual::Application::create(app_id, reg);
+        if (!app.get()->hasInstances())
+            return false;
+        Q_FOREACH (std::shared_ptr<ual::Application::Instance> instance, app.get()->instances()) {
+            if (instance.get()->hasPid(pid))
+                return true;
+        }
+    } catch (...) {
+        qWarning() << Q_FUNC_INFO << "Failed to create Application for" << id;
     }
     return false;
 }