Code review comment for ~athos-ribeiro/ubuntu/+source/tmux:tmux-fix-lp1890406-utempter-focal

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Athos.

It's looking good! I'm leaving a few very minor comments, but it's almost ready to be sponsored.

Just a few comments about the MP itself:

- I try to include as much information as possible in the description. It helps the reviewer to understand the whole picture. For example, explain the problem, the investigation, mention that the build was fine, provide a direct link to the PPA, mention whether the package has dep8 tests and whether they've succeeded, etc.

- Since this is an SRU, we usually file MPs after we've written the SRU template. I don't know if you've had the opportunity to read more about it (we can talk about this later), but the SRU template is needed to explain to the SRU team why this update is important. We usually review the MP *and* the SRU template, and provide any pertinent comments.

I will mark this MP as "Needs Information" because of the SRU template. Once that is done and reviewed, I can approve it and sponsor the upload.


review: Needs Information

« Back to merge proposal