Merge ~athos-ribeiro/ubuntu/+source/squid:halt-build-on-test-failures-kinetic into ubuntu/+source/squid:applied/ubuntu/kinetic-devel
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | ~athos-ribeiro/ubuntu/+source/squid:halt-build-on-test-failures-kinetic | ||||
Merge into: | ubuntu/+source/squid:applied/ubuntu/kinetic-devel | ||||
Diff against target: |
87 lines (+36/-3) 4 files modified
debian/changelog (+14/-0) debian/patches/series (+3/-1) debian/rules (+15/-2) debian/tests/upstream-test-suite (+4/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bryce Harrington (community) | Needs Fixing | ||
Canonical Server Reporter | Pending | ||
Review via email: mp+436605@code.launchpad.net |
This proposal has been superseded by a proposal from 2023-02-03.
Description of the change
As it is being discussed in [1], squid builds will not halt upon upstream unit test failures during dh_auto_test. This could hinder the squid MRE test plan process [2].
This MP proposes a patch set to force squid builds to fail upon test failures. It also includes additional changes to ensure build time and autopkgtests are also passing for those upstream tests.
This is the kinetic SRU for the change applied in lunar in [3]
[1] https:/
[2] https:/
PPA: https:/
[3] https:/
autopkgtest run for the ppa above:
* Results:
- squid/5.
+ ✅ squid on kinetic for amd64 @ 31.01.23 14:52:41 Log️ 🗒️
+ ✅ squid on kinetic for arm64 @ 31.01.23 15:18:39 Log️ 🗒️
+ ❌ squid on kinetic for armhf @ 31.01.23 14:28:20 Log️ 🗒️
• upstream-test-suite PASS 🟩
• squid FAIL 🟥
+ ✅ squid on kinetic for ppc64el @ 31.01.23 14:36:17 Log️ 🗒️
+ ✅ squid on kinetic for s390x @ 31.01.23 14:26:15 Log️ 🗒️
Do note that the armhf failure is not a regression: https:/
Note that I already have
- verified that the s390x LTO change is needed here; and
- tested a build without removing the 0003 patch, which did lead to a build failure due to failing tests, as expected.