Merge ~athos-ribeiro/ubuntu/+source/postgresql-common:merge-lp1986981-kinetic into ubuntu/+source/postgresql-common:debian/sid

Proposed by Athos Ribeiro
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merge reported by: Athos Ribeiro
Merged at revision: 4e3bef20c3d95b0c3f89a30e68355b8579959e7e
Proposed branch: ~athos-ribeiro/ubuntu/+source/postgresql-common:merge-lp1986981-kinetic
Merge into: ubuntu/+source/postgresql-common:debian/sid
Diff against target: 58 lines (+17/-3)
3 files modified
debian/changelog (+13/-0)
debian/control (+2/-1)
debian/rules (+2/-2)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Bryce Harrington (community) Approve
Canonical Server Reporter Pending
Review via email: mp+428574@code.launchpad.net

Description of the change

Merge for new version of postgresql-common. This was a simple merge, where we just needed to carry our one-commit delta to avoid package upgrade regressions.

PPA: https://launchpad.net/~athos-ribeiro/+archive/ubuntu/lp1986981-merge-postgresql-common-kinetic/+packages

autopkgtest local run result summary:

autopkgtest [15:05:53]: @@@@@@@@@@@@@@@@@@@@ summary
default-psql PASS
run-testsuite PASS

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote (last edit ):

From reading over the bug history, it sounds like --no-stop-on-upgrade was added to compensate for some other (Ubuntu?) delta, but there's no other delta in this package. If this also affects debian I wonder if it should be pushed up to them?

In any case, regardless of that this package LGTM, +1. I've queued up autopkgtests:

$ lp-test-ppa ppa:athos-ribeiro/lp1986981-merge-postgresql-common-kinetic -r kinetic
Tests for PPA lp1986981-merge-postgresql-common-kinetic
---- ---- ---- ----
Release: kinetic
Sources:
  SRC: postgresql-common @ 242ubuntu1~ppa1 - Published
Triggers on published Sources:
     postgresql-common @ amd64 for postgresql-common/242ubuntu1~ppa1 Trigger @amd64 ♻️ Trigger all proposed @{arch} ♻️ 💍
     postgresql-common @ s390x for postgresql-common/242ubuntu1~ppa1 Trigger @s390x ♻️ Trigger all proposed @{arch} ♻️ 💍
     postgresql-common @ ppc64el for postgresql-common/242ubuntu1~ppa1 Trigger @ppc64el ♻️ Trigger all proposed @{arch} ♻️ 💍
     postgresql-common @ arm64 for postgresql-common/242ubuntu1~ppa1 Trigger @arm64 ♻️ Trigger all proposed @{arch} ♻️ 💍
     postgresql-common @ armhf for postgresql-common/242ubuntu1~ppa1 Trigger @armhf ♻️ Trigger all proposed @{arch} ♻️ 💍
     postgresql-common @ riscv64 for postgresql-common/242ubuntu1~ppa1 Trigger @riscv64 ♻️ Trigger all proposed @{arch} ♻️ 💍
Running:
    time pkg release arch ppa trigger
    30 postgresql-common kinetic arm64 athos-ribeiro/lp1986981-merge-postgresql-common-kinetic postgresql-common/242ubuntu1~ppa1
    40 postgresql-common kinetic ppc64el athos-ribeiro/lp1986981-merge-postgresql-common-kinetic postgresql-common/242ubuntu1~ppa1
    50 postgresql-common kinetic amd64 athos-ribeiro/lp1986981-merge-postgresql-common-kinetic postgresql-common/242ubuntu1~ppa1
Waiting:
    Q-num pkg release arch ppa trigger
    1 postgresql-common kinetic armhf athos-ribeiro/lp1986981-merge-postgresql-common-kinetic postgresql-common/242ubuntu1~ppa1

Please run 'lp-test-ppa ppa:athos-ribeiro/lp1986981-merge-postgresql-common-kinetic -r kinetic' to check there's no issues.

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: athos-ribeiro, bryce
Uploaders: athos-ribeiro, bryce
MP auto-approved

review: Approve
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Bryce!

The flag compensates a delta in ubuntu dpkg-reconfigure, not in postgresql-common itself. This was forwarded to Debian and discussed in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011067.

Uploaded

$ dput ubuntu ../postgresql-common_242ubuntu1_source.changes
D: Setting host argument.
Checking signature on .changes
gpg: ../postgresql-common_242ubuntu1_source.changes: Valid signature from 033C4CA276024834
Checking signature on .dsc
gpg: ../postgresql-common_242ubuntu1.dsc: Valid signature from 033C4CA276024834
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading postgresql-common_242ubuntu1.dsc: done.
  Uploading postgresql-common_242ubuntu1.tar.xz: done.
  Uploading postgresql-common_242ubuntu1_source.buildinfo: done.
  Uploading postgresql-common_242ubuntu1_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 70880d2..8607cee 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+postgresql-common (242ubuntu1) kinetic; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #1986981). Remaining changes:
9+ - d/rules: do not stop service on package upgrades. (LP #1973382)
10+
11+ -- Athos Ribeiro <athos.ribeiro@canonical.com> Thu, 18 Aug 2022 14:38:54 -0300
12+
13 postgresql-common (242) unstable; urgency=medium
14
15 * server/postgresql.mk: Tell pg_upgrade to create sockets in /tmp.
16@@ -5,6 +12,12 @@ postgresql-common (242) unstable; urgency=medium
17
18 -- Christoph Berg <myon@debian.org> Thu, 11 Aug 2022 11:25:31 +0200
19
20+postgresql-common (241ubuntu1) kinetic; urgency=medium
21+
22+ * d/rules: do not stop service on package upgrades. (LP: #1973382)
23+
24+ -- Athos Ribeiro <athos.ribeiro@canonical.com> Mon, 16 May 2022 09:58:44 -0300
25+
26 postgresql-common (241) unstable; urgency=medium
27
28 * Remove stats_temp_directory in PG 15.
29diff --git a/debian/control b/debian/control
30index 5654e32..091f394 100644
31--- a/debian/control
32+++ b/debian/control
33@@ -1,7 +1,8 @@
34 Source: postgresql-common
35 Section: database
36 Priority: optional
37-Maintainer: Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>
38+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
39+XSBC-Original-Maintainer: Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>
40 Uploaders:
41 Martin Pitt <mpitt@debian.org>,
42 Christoph Berg <myon@debian.org>,
43diff --git a/debian/rules b/debian/rules
44index a4783e4..668e10f 100755
45--- a/debian/rules
46+++ b/debian/rules
47@@ -26,9 +26,9 @@ override_dh_auto_configure:
48
49 # do not (re)start postgresql.service on postgresql-common install/upgrades
50 override_dh_installinit:
51- dh_installinit -ppostgresql-common --name=postgresql -u'defaults 19 21' --no-start
52+ dh_installinit -ppostgresql-common --name=postgresql -u'defaults 19 21' --no-start --no-stop-on-upgrade
53 override_dh_installsystemd:
54- dh_installsystemd --no-start
55+ dh_installsystemd --no-start --no-stop-on-upgrade
56
57 override_dh_gencontrol:
58 dh_gencontrol -ppostgresql-server-dev-all -- -Vserver-dev-all-depends="$(foreach v,$(SUPPORTED_VERSIONS),postgresql-server-dev-$v,)"

Subscribers

People subscribed via source and target branches