Merge ~athos-ribeiro/ubuntu/+source/postgresql-common:lp1973382-no-stop-on-upgrade into ubuntu/+source/postgresql-common:ubuntu/devel
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 890ab3d4cfb7c3fbc275921c547d78cbc59b62c7 | ||||
Proposed branch: | ~athos-ribeiro/ubuntu/+source/postgresql-common:lp1973382-no-stop-on-upgrade | ||||
Merge into: | ubuntu/+source/postgresql-common:ubuntu/devel | ||||
Diff against target: |
44 lines (+10/-3) 3 files modified
debian/changelog (+6/-0) debian/control (+2/-1) debian/rules (+2/-2) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andreas Hasenack | Approve | ||
Canonical Server | Pending | ||
Review via email: mp+422669@code.launchpad.net |
Description of the change
This is a fix proposal for LP: #1973382.
The proposed fix works around a postgresql-common test regression caused by the combination of the following changes:
- https:/
- https:/
The first one results in a new snippet to be injected in the preinst script:
# Automatically added by dh_installsyste
if [ -z "${DPKG_ROOT:-}" ] && [ "$1" = upgrade ] && [ -d /run/systemd/system ] ; then
deb-systemd-invoke stop 'postgresql.
fi
(this new snippet is also available in the debian package).
The second one results in the preinst script to be executed (hence, causing the new snippet to run) on dpkg-reconfigure calls.
One of the postgresql-common tests specifically checks for the service not to be stopped/restarted on dpkg-reconfigure runs.
While the test failure is Ubuntu-specific (due to the second change above being available in the Ubuntu delta), a change of behavior/regression will be seen in Debian upon package upgrades (when the preinst script runs).
A PPA with the proposed changes is available at https:/
Local DEP8 test suite run result summary:
autopkgtest [10:13:06]: @@@@@@@
default-psql PASS
run-testsuite PASS
This is tricky, well done investigating the issue.
I did some tests, and dpkg-reconfigure now behaves as expected by the test, yet normal apt-get upgrades of the full postgresql stack do restart the service, which is something we did not want to lose.
This looks good, but please keep an eye on Dave's PR on debconf, to be aware of any other changes before this lands on debian, and if a different version will land in Ubuntu.