Merge ~athos-ribeiro/ubuntu/+source/php8.2:lp2057576-sigsegv into ubuntu/+source/php8.2:ubuntu/mantic-devel

Proposed by Athos Ribeiro
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merged at revision: ed47a368e4449ab03741a92d24c45b5930171875
Proposed branch: ~athos-ribeiro/ubuntu/+source/php8.2:lp2057576-sigsegv
Merge into: ubuntu/+source/php8.2:ubuntu/mantic-devel
Diff against target: 87 lines (+41/-2)
5 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/control.in (+2/-1)
debian/patches/0048-Fix-segfault-in-fpm_status_export_to_zval.patch (+29/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Bryce Harrington (community) Approve
Canonical Server Reporter Pending
Review via email: mp+463141@code.launchpad.net

Description of the change

Simple fix (upstream oneliner) for LP: #2057576

PPA: https://launchpad.net/~athos-ribeiro/+archive/ubuntu/lp2054621-php-fpm-segfault/+packages

I will upload MPs for jammy and focal as soon as I get an ack on this one.

The SRU paperwork is still pending as well.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

LGTM, quite a think-o. If the pointer is NULL, dereference it in the error message. Doh!

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: athos-ribeiro, bryce
Uploaders: athos-ribeiro, bryce
MP auto-approved

review: Approve
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Bryce, uploaded.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 83f6221..32e101c 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+php8.2 (8.2.10-2ubuntu2) mantic; urgency=medium
7+
8+ * d/p/0048-Fix-segfault-in-fpm_status_export_to_zval.patch: fix segmentation
9+ fault in fpm_status_export_to_zval. (LP: #2057576)
10+
11+ -- Athos Ribeiro <athos.ribeiro@canonical.com> Tue, 26 Mar 2024 11:21:53 -0300
12+
13 php8.2 (8.2.10-2ubuntu1) mantic; urgency=low
14
15 * Merge from Debian unstable. Remaining changes:
16diff --git a/debian/control b/debian/control
17index 0842a11..623ba25 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,7 +1,8 @@
21 Source: php8.2
22 Section: php
23 Priority: optional
24-Maintainer: Debian PHP Maintainers <team+pkg-php@tracker.debian.org>
25+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26+XSBC-Original-Maintainer: Debian PHP Maintainers <team+pkg-php@tracker.debian.org>
27 Uploaders: Ondřej Surý <ondrej@debian.org>,
28 Lior Kaplan <kaplan@debian.org>
29 Build-Depends: apache2-dev (>= 2.4),
30diff --git a/debian/control.in b/debian/control.in
31index a1b677b..a2b86e1 100644
32--- a/debian/control.in
33+++ b/debian/control.in
34@@ -1,7 +1,8 @@
35 Source: php@PHP_VERSION@
36 Section: php
37 Priority: optional
38-Maintainer: Debian PHP Maintainers <team+pkg-php@tracker.debian.org>
39+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
40+XSBC-Original-Maintainer: Debian PHP Maintainers <team+pkg-php@tracker.debian.org>
41 Uploaders: Ondřej Surý <ondrej@debian.org>,
42 Lior Kaplan <kaplan@debian.org>
43 Build-Depends: apache2-dev (>= 2.4),
44diff --git a/debian/patches/0048-Fix-segfault-in-fpm_status_export_to_zval.patch b/debian/patches/0048-Fix-segfault-in-fpm_status_export_to_zval.patch
45new file mode 100644
46index 0000000..e3a7d9d
47--- /dev/null
48+++ b/debian/patches/0048-Fix-segfault-in-fpm_status_export_to_zval.patch
49@@ -0,0 +1,29 @@
50+From df259f88daaf7df5673fd78a0a1b76a1d831d0a2 Mon Sep 17 00:00:00 2001
51+From: Patrick Prasse <patrick.prasse@actindo.com>
52+Date: Fri, 17 Nov 2023 16:32:23 +0000
53+Subject: [PATCH] Fix bug GH-12705: Segmentation fault in fpm_status_export_to_zval
54+
55+Closes GH-12706
56+
57+Bug: https://github.com/php/php-src/issues/12705
58+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/2057576
59+Last-update: 2024-03-26
60+Origin: upstream, https://github.com/php/php-src/commit/df259f88daaf7df5673fd78a0a1b76a1d831d0a2
61+---
62+ NEWS | 4 ++++
63+ sapi/fpm/fpm/fpm_status.c | 2 +-
64+ 2 files changed, 5 insertions(+), 1 deletion(-)
65+
66+diff --git a/sapi/fpm/fpm/fpm_status.c b/sapi/fpm/fpm/fpm_status.c
67+index f0d869444afce..f698753cf4c65 100644
68+--- a/sapi/fpm/fpm/fpm_status.c
69++++ b/sapi/fpm/fpm/fpm_status.c
70+@@ -56,7 +56,7 @@ int fpm_status_export_to_zval(zval *status)
71+
72+ scoreboard_p = fpm_scoreboard_acquire(NULL, 1);
73+ if (!scoreboard_p) {
74+- zlog(ZLOG_NOTICE, "[pool %s] status: scoreboard already in use.", scoreboard_p->pool);
75++ zlog(ZLOG_NOTICE, "[pool (unknown)] status: scoreboard already in use.");
76+ return -1;
77+ }
78+
79diff --git a/debian/patches/series b/debian/patches/series
80index e5ddce6..305dddf 100644
81--- a/debian/patches/series
82+++ b/debian/patches/series
83@@ -45,3 +45,4 @@
84 0045-scripts-php-.in-Explicitly-define-the-path-to-sed.patch
85 0046-Remove-timestamps-from-phar.patch
86 0047-Disable-garbage-collection-routine.patch
87+0048-Fix-segfault-in-fpm_status_export_to_zval.patch

Subscribers

People subscribed via source and target branches