Merge ~athos-ribeiro/ubuntu/+source/pglogical:merge-lp2031532-mantic into ubuntu/+source/pglogical:debian/sid

Proposed by Athos Ribeiro
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merge reported by: Athos Ribeiro
Merged at revision: 54245642b5eea11f1d630cfc5a521b8515cb2f52
Proposed branch: ~athos-ribeiro/ubuntu/+source/pglogical:merge-lp2031532-mantic
Merge into: ubuntu/+source/pglogical:debian/sid
Diff against target: 95 lines (+28/-5)
4 files modified
debian/changelog (+21/-0)
debian/control (+2/-1)
debian/control.in (+2/-1)
debian/patches/test_increase_timeouts.patch (+3/-3)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Lucas Kanashiro (community) Approve
Canonical Server Reporter Pending
Review via email: mp+449272@code.launchpad.net

Description of the change

Merge new version from debian unstable.

PPA: https://launchpad.net/~athos-ribeiro/+archive/ubuntu/lp2031532-merge-pglogical-mantic/+packages

DEP8 tests: pending

To post a comment you must log in.
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for this MP Athos! The changes themselves look good to me.

I'd ask you to make sure this couldn't become a sync but since we are close to FF I think we can move on with this delta and try to run tests without that patch in the next merge.

I checked the test results, and based on the latest run, I see there is still a test failure on s390x:

https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-athos-ribeiro-lp2031532-merge-pglogical-mantic/mantic/s390x/p/pglogical/20230816_190742_e8839@/log.gz

I'd investigate that before uploading, but if you think this is important to get in before FF, I'd upload this version and try to fix the regresscheck test in s390x right after if the failure persists. However, checking the upstream changes in this new release, it does not seem to contain relevant changes, in this case I wouldn't bother too much with this right now. But I'd leave this decision to you :)

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: athos-ribeiro, lucaskanashiro
Uploaders: athos-ribeiro, lucaskanashiro
MP auto-approved

review: Approve
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Lucas!

Since the FF is coming, let me upload this one to ensure we get the new version in mantic.
The migration reference for s290 is already failing there, so this is no regression:
https://autopkgtest.ubuntu.com/packages/p/pglogical/mantic/s390x

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Awesome, I did not check that :) go ahead with the upload then!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 5407d9a..6a2c469 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+pglogical (2.4.3-1ubuntu1) mantic; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #2031532). Remaining changes:
9+ - d/p/test_increase_timeouts.patch: increase timeout for flaky
10+ row_filter test.
11+
12+ -- Athos Ribeiro <athos.ribeiro@canonical.com> Wed, 16 Aug 2023 10:12:07 -0300
13+
14 pglogical (2.4.3-1) unstable; urgency=medium
15
16 * New upstream version.
17@@ -10,6 +18,19 @@ pglogical (2.4.2-3) unstable; urgency=medium
18
19 -- Michael Banck <mnencia@debian.org> Fri, 17 Feb 2023 14:04:05 +0100
20
21+pglogical (2.4.2-2ubuntu1) lunar; urgency=medium
22+
23+ * d/p/test_increase_timeouts.patch: increase timeout for flaky
24+ row_filter test.
25+
26+ -- Athos Ribeiro <athos.ribeiro@canonical.com> Tue, 13 Dec 2022 10:32:25 -0300
27+
28+pglogical (2.4.2-2build1) lunar; urgency=medium
29+
30+ * No-change rebuild to attempt migration.
31+
32+ -- Sergio Durigan Junior <sergio.durigan@canonical.com> Sat, 10 Dec 2022 14:49:54 -0500
33+
34 pglogical (2.4.2-2) unstable; urgency=medium
35
36 * debian/tests/prove: Exit cleanly when test is skipped.
37diff --git a/debian/control b/debian/control
38index 6af7ceb..f917e17 100644
39--- a/debian/control
40+++ b/debian/control
41@@ -1,7 +1,8 @@
42 Source: pglogical
43 Section: database
44 Priority: optional
45-Maintainer: Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>
46+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
47+XSBC-Original-Maintainer: Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>
48 Uploaders: Michael Banck <mbanck@debian.org>, Marco Nenciarini <mnencia@debian.org>
49 Build-Depends:
50 debhelper-compat (= 13),
51diff --git a/debian/control.in b/debian/control.in
52index 9138576..1089580 100644
53--- a/debian/control.in
54+++ b/debian/control.in
55@@ -1,7 +1,8 @@
56 Source: pglogical
57 Section: database
58 Priority: optional
59-Maintainer: Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>
60+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
61+XSBC-Original-Maintainer: Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>
62 Uploaders: Michael Banck <mbanck@debian.org>, Marco Nenciarini <mnencia@debian.org>
63 Build-Depends:
64 debhelper-compat (= 13),
65diff --git a/debian/patches/test_increase_timeouts.patch b/debian/patches/test_increase_timeouts.patch
66index 55cb005..e596873 100644
67--- a/debian/patches/test_increase_timeouts.patch
68+++ b/debian/patches/test_increase_timeouts.patch
69@@ -59,7 +59,7 @@ Index: pglogical/sql/row_filter.sql
70 -- wait for the initial data to copy
71 BEGIN;
72 -SET LOCAL statement_timeout = '10s';
73-+SET LOCAL statement_timeout = '60s';
74++SET LOCAL statement_timeout = '120s';
75 SELECT pglogical.wait_for_subscription_sync_complete('test_subscription');
76 COMMIT;
77
78@@ -72,7 +72,7 @@ Index: pglogical/expected/row_filter.out
79 -- wait for the initial data to copy
80 BEGIN;
81 -SET LOCAL statement_timeout = '10s';
82-+SET LOCAL statement_timeout = '60s';
83++SET LOCAL statement_timeout = '120s';
84 SELECT pglogical.wait_for_subscription_sync_complete('test_subscription');
85 wait_for_subscription_sync_complete
86 -------------------------------------
87@@ -85,7 +85,7 @@ Index: pglogical/expected/row_filter_1.out
88 -- wait for the initial data to copy
89 BEGIN;
90 -SET LOCAL statement_timeout = '10s';
91-+SET LOCAL statement_timeout = '60s';
92++SET LOCAL statement_timeout = '120s';
93 SELECT pglogical.wait_for_subscription_sync_complete('test_subscription');
94 wait_for_subscription_sync_complete
95 -------------------------------------

Subscribers

People subscribed via source and target branches