Merge ~athos-ribeiro/ubuntu/+source/isc-kea:dep8-smoke into ubuntu/+source/isc-kea:ubuntu/devel

Proposed by Athos Ribeiro
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merged at revision: d07c115c7ddff5e14741841f3f33a8642de4ce41
Proposed branch: ~athos-ribeiro/ubuntu/+source/isc-kea:dep8-smoke
Merge into: ubuntu/+source/isc-kea:ubuntu/devel
Diff against target: 47 lines (+27/-0)
3 files modified
debian/changelog (+6/-0)
debian/tests/control (+3/-0)
debian/tests/smoke-tests (+18/-0)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Andreas Hasenack Approve
Canonical Server Reporter Pending
Review via email: mp+436968@code.launchpad.net

Description of the change

Introduce initial smoketests for kea, as per LP: #1863102.

PPA: https://launchpad.net/~athos-ribeiro/+archive/ubuntu/kea-dep8/+packages

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) :
Revision history for this message
Andreas Hasenack (ahasenack) :
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

I addressed the pipefail comment, made sure the remaining service is installed and pushed the changes.

Tests are passing locally.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I didn't know you could squash the options together in one line like "set -eo pipefail", but I trust your testing :)

+1

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: athos-ribeiro, ahasenack
Uploaders: athos-ribeiro, ahasenack
MP auto-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 4076e01..0b48206 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+isc-kea (2.2.0-1ubuntu1) lunar; urgency=medium
7+
8+ * d/tests: add simple DEP8 smoke tests. (LP: #1863102)
9+
10+ -- Athos Ribeiro <athos.ribeiro@canonical.com> Tue, 07 Feb 2023 14:15:06 -0300
11+
12 isc-kea (2.2.0-1build1) lunar; urgency=medium
13
14 * No change rebuild for PostgreSQL 15
15diff --git a/debian/tests/control b/debian/tests/control
16new file mode 100644
17index 0000000..166bd24
18--- /dev/null
19+++ b/debian/tests/control
20@@ -0,0 +1,3 @@
21+Tests: smoke-tests
22+Restrictions: needs-root
23+Depends: kea-dhcp4-server, kea-dhcp6-server, kea-ctrl-agent, kea-dhcp-ddns-server, curl, jq
24diff --git a/debian/tests/smoke-tests b/debian/tests/smoke-tests
25new file mode 100644
26index 0000000..2077b90
27--- /dev/null
28+++ b/debian/tests/smoke-tests
29@@ -0,0 +1,18 @@
30+#!/bin/bash
31+
32+set -eo pipefail
33+
34+# Check dhcp4 server configuration file
35+kea-dhcp4 -t /etc/kea/kea-dhcp4.conf
36+
37+# Check dhcp6 server configuration file
38+kea-dhcp6 -t /etc/kea/kea-dhcp6.conf
39+
40+# Check control agent API
41+curl -s -X POST -H "Content-Type: application/json" -d '{ "command": "version-get", "service": [ "dhcp4" ] }' 127.0.0.1:8000 | jq '.[0].text'
42+
43+# Check control agent API through kea-shell
44+echo | kea-shell --service dhcp4 --host 127.0.0.1 --port 8000 version-get | jq '.[0].text'
45+
46+# Use keactrl to check if services are running
47+keactrl status | grep 'DHCPv[46] server: active'

Subscribers

People subscribed via source and target branches