Merge ~athos-ribeiro/ubuntu/+source/bind9:restart-bionic into ubuntu/+source/bind9:ubuntu/bionic-devel

Proposed by Athos Ribeiro
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merged at revision: f95c5daa5d334c3bed9e4938b8ea0c299baa6c7c
Proposed branch: ~athos-ribeiro/ubuntu/+source/bind9:restart-bionic
Merge into: ubuntu/+source/bind9:ubuntu/bionic-devel
Diff against target: 27 lines (+8/-0)
2 files modified
debian/bind9.service (+1/-0)
debian/changelog (+7/-0)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Bryce Harrington (community) Approve
Canonical Server Reporter Pending
Review via email: mp+438331@code.launchpad.net

Description of the change

Fix for LP: #2006054: restart the named service upon failures.

PPA: https://launchpad.net/~athos-ribeiro/+archive/ubuntu/restart-named/+packages

Tests are running ATM. I will update this MP with results as soon as I get them.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

I can review this, and the focal one too.

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

amd64 tests are taking a while to run, but they did succeed locally.

* Results:
  - bind9/1:9.16.1-0ubuntu2.14~ppa1
    + ✅ bind9 on focal for arm64 @ 03.03.23 17:42:28 Log️ 🗒️
    + ✅ bind9 on focal for armhf @ 03.03.23 17:37:22 Log️ 🗒️
    + ✅ bind9 on focal for i386 @ 03.03.23 17:56:39 Log️ 🗒️
    + ✅ bind9 on focal for ppc64el @ 03.03.23 17:38:37 Log️ 🗒️
    + ✅ bind9 on focal for s390x @ 03.03.23 22:31:29 Log️ 🗒️

  - bind9/1:9.11.3+dfsg-1ubuntu1.19~ppa1
    + ✅ bind9 on bionic for arm64 @ 03.03.23 17:39:09 Log️ 🗒️
    + ✅ bind9 on bionic for armhf @ 03.03.23 17:40:53 Log️ 🗒️
    + ✅ bind9 on bionic for i386 @ 03.03.23 18:08:28 Log️ 🗒️
    + ✅ bind9 on bionic for ppc64el @ 03.03.23 17:35:54 Log️ 🗒️
    + ✅ bind9 on bionic for s390x @ 03.03.23 17:36:38 Log️ 🗒️

Revision history for this message
Bryce Harrington (bryce) wrote :

This seems so straightforward, I only worry there is a catch. But I can find no problems, so LGTM, +1.

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: athos-ribeiro, bryce
Uploaders: athos-ribeiro, bryce
MP auto-approved

review: Approve
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Bryce!

Uploaded

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading bind9_9.11.3+dfsg-1ubuntu1.19.dsc: done.
  Uploading bind9_9.11.3+dfsg-1ubuntu1.19.debian.tar.xz: done.
  Uploading bind9_9.11.3+dfsg-1ubuntu1.19_source.buildinfo: done.
  Uploading bind9_9.11.3+dfsg-1ubuntu1.19_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/bind9.service b/debian/bind9.service
2index 9fc634c..f6a0286 100644
3--- a/debian/bind9.service
4+++ b/debian/bind9.service
5@@ -10,6 +10,7 @@ EnvironmentFile=/etc/default/bind9
6 ExecStart=/usr/sbin/named -f $OPTIONS
7 ExecReload=/usr/sbin/rndc reload
8 ExecStop=/usr/sbin/rndc stop
9+Restart=on-failure
10
11 [Install]
12 WantedBy=multi-user.target
13diff --git a/debian/changelog b/debian/changelog
14index 4d5c3ed..2cea8d5 100644
15--- a/debian/changelog
16+++ b/debian/changelog
17@@ -1,3 +1,10 @@
18+bind9 (1:9.11.3+dfsg-1ubuntu1.19) bionic; urgency=medium
19+
20+ * d/bind9.service: restart the bind9 service on failure.
21+ (LP: #2006054)
22+
23+ -- Athos Ribeiro <athos.ribeiro@canonical.com> Fri, 03 Mar 2023 12:42:18 -0300
24+
25 bind9 (1:9.11.3+dfsg-1ubuntu1.18) bionic-security; urgency=medium
26
27 * SECURITY UPDATE: Processing large delegations may severely degrade

Subscribers

People subscribed via source and target branches